All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Grubb <sgrubb@redhat.com>
To: selinux@vger.kernel.org, Chris PeBenito <chpebeni@linux.microsoft.com>
Subject: Re: [PATCH 2/2] libselinux: Change userspace AVC setenforce and policy load messages to audit format.
Date: Tue, 15 Sep 2020 16:44:12 -0400	[thread overview]
Message-ID: <2574836.mvXUDI8C0e@x2> (raw)
In-Reply-To: <20200915173332.574700-2-chpebeni@linux.microsoft.com>

On Tuesday, September 15, 2020 1:33:32 PM EDT Chris PeBenito wrote:
> Signed-off-by: Chris PeBenito <chpebeni@linux.microsoft.com>
> ---
>  libselinux/src/avc_internal.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libselinux/src/avc_internal.c b/libselinux/src/avc_internal.c
> index 572b2159..53a99a1f 100644
> --- a/libselinux/src/avc_internal.c
> +++ b/libselinux/src/avc_internal.c
> @@ -59,7 +59,7 @@ int avc_process_setenforce(int enforcing)
>  	int rc = 0;
> 
>  	avc_log(SELINUX_SETENFORCE,
> -		"%s:  received setenforce notice (enforcing=%d)\n",
> +		"%s:  op=setenforce lsm=selinux enforcing=%d res=1",
>  		avc_prefix, enforcing);
>  	if (avc_setenforce)
>  		goto out;
> @@ -81,7 +81,7 @@ int avc_process_policyload(uint32_t seqno)
>  	int rc = 0;
> 
>  	avc_log(SELINUX_POLICYLOAD,
> -		"%s:  received policyload notice (seqno=%u)\n",
> +		"%s:  op=load_policy lsm=selinux seqno=%u res=1",
>  		avc_prefix, seqno);
>  	rc = avc_ss_reset(seqno);
>  	if (rc < 0) {

These look good from an audit perspective.

Thanks,
-Steve



  parent reply	other threads:[~2020-09-15 21:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-15 17:33 [PATCH 1/2] libselinux: Add additional log callback details in man page for auditing Chris PeBenito
2020-09-15 17:33 ` [PATCH 2/2] libselinux: Change userspace AVC setenforce and policy load messages to audit format Chris PeBenito
2020-09-15 20:43   ` Stephen Smalley
2020-09-17 20:20     ` Stephen Smalley
2020-09-15 20:44   ` Steve Grubb [this message]
2020-09-15 20:41 ` [PATCH 1/2] libselinux: Add additional log callback details in man page for auditing Stephen Smalley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2574836.mvXUDI8C0e@x2 \
    --to=sgrubb@redhat.com \
    --cc=chpebeni@linux.microsoft.com \
    --cc=selinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.