From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D501EC433EF for ; Wed, 16 Mar 2022 16:55:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6724783A66; Wed, 16 Mar 2022 17:55:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="nlhjevTv"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DCD7383C06; Wed, 16 Mar 2022 17:55:21 +0100 (CET) Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BCFDC83A3A for ; Wed, 16 Mar 2022 17:55:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jernej.skrabec@gmail.com Received: by mail-ej1-x633.google.com with SMTP id a8so5476308ejc.8 for ; Wed, 16 Mar 2022 09:55:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aHBhmakM1s5ndHxh6ULIUUczcC7gOMVYdNiaQDR99O4=; b=nlhjevTvWhGzLjjZnIU3CPuaqZ8QF0YTci7g/yttkLRgVHgZ6WaAMuGmU0sfotq9j1 UtpAhr5W7EfJt/wj45y11rAybeI9Oiu/Iw52LdUMVseTFx41JjeDCsKDKxhgPGB1+wVu oC+RYK47wYtJFnl9b20qrLeQ/Tdr06Mb+/891LppuRGAFYouO0zoFMeMCioj4eBzoQSn gmDpDaXe/oIithWJXm4/GL474JsQn/PcajyEKsuUhuk9um1YpdSRv8LIMuwZRXI/3GEL kxFIG/GrKUeuVNMmrzpI8qW4DxVmixMy7O/b3MhdzyB9VhnOfxddCQ/+AI5SXHEeGtS3 Xmwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aHBhmakM1s5ndHxh6ULIUUczcC7gOMVYdNiaQDR99O4=; b=Fi3BaRP/8fr7dDuzjvXHz6IpZwjDaASWXm8gcu/T3MxCXkjHf5kVVs6Z9gXvpQAN9C DmgxDVLQF1u/rFRfiUX70wremZalEFvlecpSnLkU3R8Riaj0grGmHW1dxxJEuc3X0PTH oAT8KkU+tw9K1R4PgyZ1ByJnVTD4Bf6jKaa1QJBLetfmYsRSEEBDbeRNKvkzCwI8H1kq pCz6taYxiiep05Q7mN1/fPVUlGR7RZSUs5nR6wDNHZSPfxxPrP7tWL0cq0g4jjZHkOdD gOs9Vnb/T0Q3k5aHOirn3CBKs5+wWjuhZTPK+Y+ZAjMzC8wKmMRnnP9pU4DKVQoU9SzC ehXw== X-Gm-Message-State: AOAM532q4x2zSkmWb9KYMt4p8RRwNmUDkqTf5l7GaV1LIbQz/Dc8ZOwJ KIjb4VQryu+GRLFkoU/mBtA= X-Google-Smtp-Source: ABdhPJzrAZlc9tSiNjVcqXM4NofN+LQyK3Hc47CjTw16MqRV9hM37b35Pagy8jygLjdpjkNa3Je31w== X-Received: by 2002:a17:907:9626:b0:6da:6c6f:9825 with SMTP id gb38-20020a170907962600b006da6c6f9825mr756377ejc.600.1647449718271; Wed, 16 Mar 2022 09:55:18 -0700 (PDT) Received: from kista.localnet (cpe-86-58-32-107.static.triera.net. [86.58.32.107]) by smtp.gmail.com with ESMTPSA id nc13-20020a1709071c0d00b006df4e0d352csm1069623ejc.151.2022.03.16.09.55.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 09:55:17 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Jagan Teki , Andre Przywara Cc: u-boot@lists.denx.de, Simon Glass , Tom Rini , Samuel Holland Subject: Re: [PATCH 1/2] sunxi: Fix old GMAC pinmux setup Date: Wed, 16 Mar 2022 17:55:16 +0100 Message-ID: <2575255.X9hSmTKtgW@kista> In-Reply-To: <20220316005443.16260-2-andre.przywara@arm.com> References: <20220316005443.16260-1-andre.przywara@arm.com> <20220316005443.16260-2-andre.przywara@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Dne sreda, 16. marec 2022 ob 01:54:42 CET je Andre Przywara napisal(a): > Commit 5bc4cd05d7d4 ("sunxi: move non-essential code out of s_init()") > moved the call to eth_init_board() from s_init() into board_init_f(). > This means it's now only called from the SPL, which makes sense for > most of the other moved low-level functions. However the GMAC pinmux and > clock setup in eth_init_board() was not happy about that, so it broke > the sun7i GMAC. > > Since Ethernet is of no use in the SPL anyway, just move the call into > board_init(), which is only run in U-Boot proper. > > This fixes Ethernet operation for the A20 SoCs, which broke in > v2022.04-rc1, with the above mentioned commit. > > Signed-off-by: Andre Przywara Reviewed-by: Jernej Skrabec I guess this function will soon go away with introduction of clock and pinctrl driver. Best regards, Jernej > --- > arch/arm/mach-sunxi/board.c | 1 - > board/sunxi/board.c | 3 +++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-sunxi/board.c b/arch/arm/mach-sunxi/board.c > index 0071de19ffd..9a7673d82dc 100644 > --- a/arch/arm/mach-sunxi/board.c > +++ b/arch/arm/mach-sunxi/board.c > @@ -333,7 +333,6 @@ void board_init_f(ulong dummy) > clock_init(); > timer_init(); > gpio_init(); > - eth_init_board(); > > spl_init(); > preloader_console_init(); > diff --git a/board/sunxi/board.c b/board/sunxi/board.c > index a0961590479..28f702bc296 100644 > --- a/board/sunxi/board.c > +++ b/board/sunxi/board.c > @@ -30,6 +30,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -308,6 +309,8 @@ int board_init(void) > #endif > #endif /* CONFIG_DM_MMC */ > > + eth_init_board(); > + > return 0; > } > > -- > 2.35.1 > >