From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751779AbdHAMei (ORCPT ); Tue, 1 Aug 2017 08:34:38 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:50102 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751115AbdHAMeg (ORCPT ); Tue, 1 Aug 2017 08:34:36 -0400 X-AuditID: b6c32a47-f79db6d000003732-48-5980755ac21c From: Bartlomiej Zolnierkiewicz To: "Gustavo A. R. Silva" Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video/chips: constify fb_fix_screeninfo and fb_var_screeninfo structures Date: Tue, 01 Aug 2017 14:34:31 +0200 Message-id: <2575493.n74KlNstDc@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170708011552.GA26138@embeddedgus> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLIsWRmVeSWpSXmKPExsWy7bCmqW5UaUOkwde3khYrl+xnszjR94HV 4vKuOWwOzB7rDqp6fN4kF8AUxWWTkpqTWZZapG+XwJVxf0YDe8E+9oq1C9ewNzC+YO1i5OSQ EDCReDlpPzOELSZx4d56NhBbSGAHo8TBvZ5djFxA9mdGiXMfnjHDNJzrn8gCUbQWKHErHKLo K6PE7L7zYEVsAlYSE9tXMYLYIgLGEtee72MCsZkFbCVenz4DFhcWiJe49+462CAWAVWJvS9b wGp4BTQldh+eDRYXFfCS2LKvHSzOKWAo8ajvMjtEjaDEj8n3WCBmykvs2z+VFcLWkTh7bB0j yEESAq/ZJHa2fwFyOIAcWYlNB6AecAGqucMGYQtLvDq+hR3ClpLo7pgFZU9nlNj+WwJizmZG iVW7J0AlrCUOH78ItYxPouPwX3aI+bwSHW1CECUeEu13DkFD11Fi1o1+ZkhgtTBKTNruPIFR fhaSF2YheWEWkhcWMDKvYhRLLSjOTU8tNiow1itOzC0uzUvXS87P3cQITgRa7jsYt53zOcQo wMGoxMPbYVofKcSaWFZcmXuIUYKDWUmEVz23IVKINyWxsiq1KD++qDQntfgQozQHi5I4b922 axFCAumJJanZqakFqUUwWSYOTqkGxh21O98rz3nyTXJ+mvWyVWxfHI5XPzK5ufaHtm3jyenc OdqzszYvuSYleKP5iY2rqMjiJzqnjd0NEjbV3tr2yHiZYajnyTcH6lO4ZxV8MmY94ab7U/dh 4UyPjXmLBUOrF0ZP/hDwgyuY4elCNQnNBEF+7fIDnl9UjrPccPeevnD7kekfH+jlfVdiKc5I NNRiLipOBADFxj9EAAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprAIsWRmVeSWpSXmKPExsVy+t9jQd2o0oZIg50zuSxWLtnPZnGi7wOr xeVdc9gcmD3WHVT1+LxJLoApys0mIzUxJbVIITUvOT8lMy/dVik0xE3XQkkhLzE31VYpQtc3 JEhJoSwxpxTIMzJAAw7OAe7BSvp2CW4Z92c0sBfsY69Yu3ANewPjC9YuRk4OCQETiXP9E1kg bDGJC/fWs3UxcnEICaxmlDixsYsdwvnKKPFu4TawKjYBK4mJ7asYQWwRAWOJa8/3MYHYzAK2 Eq9PnwGLCwvES9x7dx2snkVAVWLvyxawGl4BTYndh2eDxUUFvCS27GsHi3MKGEo86rsMtayN UaL/yyE2iAZBiR+T77FALJCX2Ld/KiuErSWxfudxpgmMArOQlM1CUjYLSdkCRuZVjGKpBcW5 6bnFRgVGesWJucWleel6yfm5mxiBsbHtsFbADsamc9GHGAU4GJV4eDtM6yOFWBPLiitzDzFK cDArifCq5zZECvGmJFZWpRblxxeV5qQWH2I0BfpvIrOUaHI+MG7zSuINTSyNTAzMzAyNDIzN lMR5JwR+iRASSE8sSc1OTS1ILYLpY+LglGpgNHkyT6Gqa8tbu6+TXzQrBcy/P1NlQ8Bmtl3L /HgXbCzStFUyWe7we7aBQP2FW2LdmyZarZtwZq5j0nSrJs/XoTWdAfE5N+LPLv20Xqpq74mq CYa1UyT2rp82WTr44M7S10eibIOC2F57L1MPKdY996DCTvDeZz4DhsKVRm3RVWdUbx43v7Jv khJLcUaioRZzUXEiAN9DW8ajAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170801123434epcas2p14518b4d0e8cbfe96568540eec2f8f80a X-Msg-Generator: CA X-Sender-IP: 182.195.42.80 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 102P X-CMS-RootMailID: 20170708011556epcas3p2900f8ed5102858fc64d194feb7874305 X-RootMTR: 20170708011556epcas3p2900f8ed5102858fc64d194feb7874305 References: <20170708011552.GA26138@embeddedgus> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, July 07, 2017 08:15:52 PM Gustavo A. R. Silva wrote: > These structures are only used to copy into other structures, > so declare them as const. > > This issue was detected using Coccinelle and the following semantic patch: > > @r disable optional_qualifier@ > identifier i; > position p; > @@ > static struct fb_fix_screeninfo i@p = { ... }; > > @ok@ > identifier r.i; > expression e; > position p; > @@ > e = i@p > > @bad@ > position p != {r.p,ok.p}; > identifier r.i; > struct fb_fix_screeninfo e; > @@ > e@i@p > > @depends on !bad disable optional_qualifier@ > identifier r.i; > @@ > static > +const > struct fb_fix_screeninfo i = { ... }; > > The semantic patch for fb_var_screeninfo is analogous. > > Signed-off-by: Gustavo A. R. Silva Patch queued for 4.14, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Tue, 01 Aug 2017 12:34:31 +0000 Subject: Re: [PATCH] video/chips: constify fb_fix_screeninfo and fb_var_screeninfo structures Message-Id: <2575493.n74KlNstDc@amdc3058> List-Id: References: <20170708011552.GA26138@embeddedgus> In-Reply-To: <20170708011552.GA26138@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Gustavo A. R. Silva" Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org On Friday, July 07, 2017 08:15:52 PM Gustavo A. R. Silva wrote: > These structures are only used to copy into other structures, > so declare them as const. > > This issue was detected using Coccinelle and the following semantic patch: > > @r disable optional_qualifier@ > identifier i; > position p; > @@ > static struct fb_fix_screeninfo i@p = { ... }; > > @ok@ > identifier r.i; > expression e; > position p; > @@ > e = i@p > > @bad@ > position p != {r.p,ok.p}; > identifier r.i; > struct fb_fix_screeninfo e; > @@ > e@i@p > > @depends on !bad disable optional_qualifier@ > identifier r.i; > @@ > static > +const > struct fb_fix_screeninfo i = { ... }; > > The semantic patch for fb_var_screeninfo is analogous. > > Signed-off-by: Gustavo A. R. Silva Patch queued for 4.14, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics