From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7FCFC2D0FA for ; Wed, 13 May 2020 12:58:06 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 69C8F2176D for ; Wed, 13 May 2020 12:58:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="BRFl2OD3"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="qmVITIKH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69C8F2176D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A4E471D59B; Wed, 13 May 2020 14:58:05 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 441DD1D59A; Wed, 13 May 2020 14:58:04 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id E45E27E9; Wed, 13 May 2020 08:58:02 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 13 May 2020 08:58:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= BAOsMXQ+9KoIhS4KHYFmavzHdI39mnpeVoCzw0XdTMc=; b=BRFl2OD3jsAd7hgm LOyIa+8ur+8u7XQGPDK27bwi+eqTECkk8yLVsBt6j5+6/SqtspLum4S8Gd9X9rt6 YOn5utW+6lkSjyLoJKOPcqx0mXkP5CQVO0h5ngo7DTZqxFQ6XGKTIWp48yrCYL6W yD1gWLsMv1sRvsW4p61sIkq7RJWHqyn8IHwnDdL++AuAHjh16TmvsfYR0kq4MsZp +Np6RQb5hEJEdqozhF013vLvukUNQG64BVBixFB11+TFFWlZQmFhvujciqIa0/W7 wQ6I6QkKu5i2jO+rAjBsVHS/8smTFp814fhWiWdmgMNNsav26dKJF1SssrQacaAW l24f6w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=BAOsMXQ+9KoIhS4KHYFmavzHdI39mnpeVoCzw0XdT Mc=; b=qmVITIKHyXL8uB0m+mdu62iLitYGO/RdTvQIYJznktlUks/e/ItX+BaIc UgutGVfMk3SA/EzpEt4l1qSiG8TOWtOdHH2sqFfYzWWE73EOFz4Ua4fmSreeNgEz 4sEwVcRsSrSPCtGlbfB8RhBM5hD9WgMsFYQptZ8IUb0bEjd6GC6By/Fo0oJUZxOJ kEoMhdAYbdJPLvjUr1aRLLiYl/CGZGMArDVIGxqGYWyz46aqfQBss7fMVtkaXUOU alDuvlsKjrPstfBPlbFgfNAQuO3clOuJ/sWK98s6D/3UOmMoxr0yPMET5mRdEpof +oJubmAXcPvlVPBUPB/My6PCsPBIg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrleeggdehkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6A2ED3066315; Wed, 13 May 2020 08:58:01 -0400 (EDT) From: Thomas Monjalon To: "Xu, Ting" , "Iremonger, Bernard" Cc: "dev@dpdk.org" , "Yigit, Ferruh" , "arybchenko@solarflare.com" , "stable@dpdk.org" Date: Wed, 13 May 2020 14:58:00 +0200 Message-ID: <2577108.MsWZr2WtbB@thomas> In-Reply-To: References: <20200511102504.23936-1-ting.xu@intel.com> <20200513100745.13118-1-ting.xu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: fix DCB set failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/05/2020 10:54, Iremonger, Bernard: > The fix is no longer in testpmd, so the commit line should be "ethdev: fix DCB set failure". In general, the word "failure" (or error, etc) is not needed. Because it is a fix, we know there was a failure before :) And specifically here, you are not fixing just DCB.