From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751866AbaLCRak (ORCPT ); Wed, 3 Dec 2014 12:30:40 -0500 Received: from mail.kmu-office.ch ([178.209.48.109]:35208 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751614AbaLCRaN (ORCPT ); Wed, 3 Dec 2014 12:30:13 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Wed, 03 Dec 2014 18:32:22 +0100 From: Stefan Agner To: Arnd Bergmann Cc: shawn.guo@linaro.org, kernel@pengutronix.de, linux@arm.linux.org.uk, u.kleine-koenig@pengutronix.de, jason@lakedaemon.net, olof@lixom.net, daniel.lezcano@linaro.org, tglx@linutronix.de, mark.rutland@arm.com, pawel.moll@arm.com, robh+dt@kernel.org, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/12] irqchip: nvic: support routable irq domain ops In-Reply-To: <4576226.8jDcZiCptE@wuerfel> References: <1417565531-4507-1-git-send-email-stefan@agner.ch> <1417565531-4507-5-git-send-email-stefan@agner.ch> <4576226.8jDcZiCptE@wuerfel> Message-ID: <2586ebb42daf66877335adaad4b4d3e6@agner.ch> User-Agent: Roundcube Webmail/1.0.3 X-DSPAM-Result: Whitelisted X-DSPAM-Processed: Wed Dec 3 18:29:37 2014 X-DSPAM-Confidence: 0.9899 X-DSPAM-Probability: 0.0000 X-DSPAM-Signature: 547f488112811767866895 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014-12-03 11:49, Arnd Bergmann wrote: > On Wednesday 03 December 2014 01:12:03 Stefan Agner wrote: >> +#ifdef CONFIG_ARM_NVIC >> +extern const struct irq_domain_ops *nvic_routable_irq_domain_ops; >> +static inline void __init register_routable_domain_ops >> + (const struct irq_domain_ops *ops) >> +{ >> + nvic_routable_irq_domain_ops = ops; >> +} >> +#endif /* CONFIG_ARM_NVIC */ >> > > As you mentioned, this conflicts with the gic specific declaration. > Why not remove the #ifdef here and rename the function to > nvic_register_routable_domain_ops() ? > > If that doesn't work, I guess we need something more generic > and move the routable_irq_domain_ops to some common location. > This would move the ifdef to the MSCM driver code. I thought of having a generic function to call, no matter what base IRQ chip is used. Anyway, as tglx suggested in patch 3/12, I will try to use the IRQ domain hierarchy stuff... -- Stefan From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Agner Subject: Re: [PATCH 04/12] irqchip: nvic: support routable irq domain ops Date: Wed, 03 Dec 2014 18:32:22 +0100 Message-ID: <2586ebb42daf66877335adaad4b4d3e6@agner.ch> References: <1417565531-4507-1-git-send-email-stefan@agner.ch> <1417565531-4507-5-git-send-email-stefan@agner.ch> <4576226.8jDcZiCptE@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4576226.8jDcZiCptE@wuerfel> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org, olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org, daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 2014-12-03 11:49, Arnd Bergmann wrote: > On Wednesday 03 December 2014 01:12:03 Stefan Agner wrote: >> +#ifdef CONFIG_ARM_NVIC >> +extern const struct irq_domain_ops *nvic_routable_irq_domain_ops; >> +static inline void __init register_routable_domain_ops >> + (const struct irq_domain_ops *ops) >> +{ >> + nvic_routable_irq_domain_ops = ops; >> +} >> +#endif /* CONFIG_ARM_NVIC */ >> > > As you mentioned, this conflicts with the gic specific declaration. > Why not remove the #ifdef here and rename the function to > nvic_register_routable_domain_ops() ? > > If that doesn't work, I guess we need something more generic > and move the routable_irq_domain_ops to some common location. > This would move the ifdef to the MSCM driver code. I thought of having a generic function to call, no matter what base IRQ chip is used. Anyway, as tglx suggested in patch 3/12, I will try to use the IRQ domain hierarchy stuff... -- Stefan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: stefan@agner.ch (Stefan Agner) Date: Wed, 03 Dec 2014 18:32:22 +0100 Subject: [PATCH 04/12] irqchip: nvic: support routable irq domain ops In-Reply-To: <4576226.8jDcZiCptE@wuerfel> References: <1417565531-4507-1-git-send-email-stefan@agner.ch> <1417565531-4507-5-git-send-email-stefan@agner.ch> <4576226.8jDcZiCptE@wuerfel> Message-ID: <2586ebb42daf66877335adaad4b4d3e6@agner.ch> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2014-12-03 11:49, Arnd Bergmann wrote: > On Wednesday 03 December 2014 01:12:03 Stefan Agner wrote: >> +#ifdef CONFIG_ARM_NVIC >> +extern const struct irq_domain_ops *nvic_routable_irq_domain_ops; >> +static inline void __init register_routable_domain_ops >> + (const struct irq_domain_ops *ops) >> +{ >> + nvic_routable_irq_domain_ops = ops; >> +} >> +#endif /* CONFIG_ARM_NVIC */ >> > > As you mentioned, this conflicts with the gic specific declaration. > Why not remove the #ifdef here and rename the function to > nvic_register_routable_domain_ops() ? > > If that doesn't work, I guess we need something more generic > and move the routable_irq_domain_ops to some common location. > This would move the ifdef to the MSCM driver code. I thought of having a generic function to call, no matter what base IRQ chip is used. Anyway, as tglx suggested in patch 3/12, I will try to use the IRQ domain hierarchy stuff... -- Stefan