All of lore.kernel.org
 help / color / mirror / Atom feed
From: hui.liu <hui.liu@mediatek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	<linus.walleij@linaro.org>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <matthias.bgg@gmail.com>
Cc: <Project_Global_Chrome_Upstream_Group@mediatek.com>,
	<jianguo.zhang@mediatek.com>, <zhiyong.tao@mediatek.com>,
	<sean.wang@mediatek.com>, <linux-gpio@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: add support for MediaTek mt8188
Date: Thu, 28 Jul 2022 16:01:20 +0800	[thread overview]
Message-ID: <2588215844090b8f66165d21a9fb812971a94d80.camel@mediatek.com> (raw)
In-Reply-To: <3ebd6dad-038d-eb96-3fed-8735de0cee2e@linaro.org>

On Wed, 2022-07-27 at 12:30 +0200, Krzysztof Kozlowski wrote:
> On 27/07/2022 12:21, Hui Liu wrote:
> > From: "Hui.Liu" <hui.liu@mediatek.com>
> > 
> > Add pinctrl function header file and binding document for mt8188.
> > 
> > Signed-off-by: Hui.Liu <hui.liu@mediatek.com>
> > ---
> >  .../pinctrl/mediatek,mt8188-pinctrl.yaml      |  238 +++
> >  .../pinctrl/mediatek,mt8188-pinfunc.h         | 1280
> > +++++++++++++++++
> >  2 files changed, 1518 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-
> > pinctrl.yaml
> >  create mode 100644 include/dt-bindings/pinctrl/mediatek,mt8188-
> > pinfunc.h
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-
> > pinctrl.yaml
> > b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-
> > pinctrl.yaml
> > new file mode 100644
> > index 000000000000..a9d5e9eec35d
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-
> > pinctrl.yaml
> > @@ -0,0 +1,238 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: 
> > https://urldefense.com/v3/__http://devicetree.org/schemas/pinctrl/pinctrl-mt8188.yaml*__;Iw!!CTRNKA9wMg0ARbw!yuH4ZL9hwU-LDeEBh9ehupQFf_rcaqqRLMFrD8rw4LdDtYdsTiQQQh-eODJU5JU$
> >  
> 
> Does not look like you tested the bindings. Please run `make
> dt_binding_check` (see
> Documentation/devicetree/bindings/writing-schema.rst for
> instructions).
> 
Hi Krzysztof,

I will run dt_bingding_check, and send v3 patch after checking pass.

> 
> Best regards,
> Krzysztof

  reply	other threads:[~2022-07-28  8:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-27 10:21 [PATCH v2 0/2] MediaTek pinctrl patch on mt8188 Hui Liu
2022-07-27 10:21 ` [PATCH v2 1/2] dt-bindings: pinctrl: add support for MediaTek mt8188 Hui Liu
2022-07-27 10:30   ` Krzysztof Kozlowski
2022-07-27 10:30     ` Krzysztof Kozlowski
2022-07-28  8:01     ` hui.liu [this message]
2022-07-27 13:57   ` Rob Herring
2022-07-27 13:57     ` Rob Herring
2022-07-27 10:21 ` [PATCH v2 2/2] pinctrl: mediatek: add mt8188 driver Hui Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2588215844090b8f66165d21a9fb812971a94d80.camel@mediatek.com \
    --to=hui.liu@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jianguo.zhang@mediatek.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sean.wang@mediatek.com \
    --cc=zhiyong.tao@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.