From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20497C43142 for ; Thu, 2 Aug 2018 09:12:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D2B27214F1 for ; Thu, 2 Aug 2018 09:12:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2B27214F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731600AbeHBLCi (ORCPT ); Thu, 2 Aug 2018 07:02:38 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:48136 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726239AbeHBLCi (ORCPT ); Thu, 2 Aug 2018 07:02:38 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C4BD6814DE89; Thu, 2 Aug 2018 09:12:23 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-116.rdu2.redhat.com [10.10.120.116]) by smtp.corp.redhat.com (Postfix) with ESMTP id 32B871C716; Thu, 2 Aug 2018 09:12:23 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20180731215825.GA10268@embeddedor.com> References: <20180731215825.GA10268@embeddedor.com> To: "Gustavo A. R. Silva" Cc: dhowells@redhat.com, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] afs: Mark expected switch fall-throughs MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <25891.1533201142.1@warthog.procyon.org.uk> Date: Thu, 02 Aug 2018 10:12:22 +0100 Message-ID: <25892.1533201142@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 02 Aug 2018 09:12:23 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 02 Aug 2018 09:12:23 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'dhowells@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Gustavo A. R. Silva wrote: > + /* Fall through */ > no_msw: > /* extract the returned data length */ > case 2: That would appear to be added in the wrong place. The fall-through is after the no_msw label. > + > + /* Fall through */ > no_volname_padding: Ditto - and several other dittos too. > - /* Done */ > + /* Fall through - Done */ Yuck. > + > + /* fall through */ Capital 'F' for consistency please. Whilst I understand the argument for explicitly marking the fall-throughs to catch missing breaks, it's a bit irritating at times. Can we have an additional annotation that tells the compiler that every case in a switch statement is going to fall through (so no break before case) except the last? That would be more useful in this case. David