From: Nick Vinson <nvinson234@gmail.com>
To: Daniel Kiper <dkiper@net-space.pl>
Cc: grub-devel@gnu.org
Subject: Re: [GRUB PARTUUID PATCH V9 4/5] Update grub script template files
Date: Tue, 10 Apr 2018 20:00:04 -0700 [thread overview]
Message-ID: <25902d38-4c37-9c9a-19b0-aeda756c8613@gmail.com> (raw)
In-Reply-To: <20180410205228.GB25917@router-fw-old.local.net-space.pl>
On 04/10/2018 01:52 PM, Daniel Kiper wrote:
> On Sat, Apr 07, 2018 at 04:28:13PM -0700, Nicholas Vinson wrote:
>> Update grub-mkconfig.in and 10_linux.in to support grub-probe's new
>> partuuid target. Update grub.texi documentation. The following table
>> shows how GRUB_DISABLE_LINUX_UUID, GRUB_DISABLE_LINUX_PARTUUID, and
>> initramfs detection interact:
>>
>> Initramfs GRUB_DISABLE_LINUX_PARTUUID GRUB_DISABLE_LINUX_UUID Linux Root
>> detected Set Set ID Method
>>
>> False False False part UUID
>> False False True part UUID
>> False True False dev name
>> False True True dev name
>> True False False fs UUID
>> True False True part UUID
>> True True False fs UUID
>> True True True dev name
>
> What will happen if GRUB_DISABLE_LINUX_PARTUUID and/or GRUB_DISABLE_LINUX_UUID
> are not set? I think that you can avoid that by setting defaults. You do that
> for GRUB_DISABLE_LINUX_PARTUUID in next patch but GRUB_DISABLE_LINUX_UUID
> does not have any default.
>
If they're not set, then that's the same as them being set to 'False'.
I should have worded my table above a bit differently and used Yes/No
instead of True/False as that is really what it is trying to convey.
I.E. If there is no initramfs detected and GRUB_DISABLE_LINUX_PARTUUID
is not set and GRUB_DISABLE_LINUX_UUID is not set, set the kernel root
variable to "root=PARTUUID=...".
In the scripts, the only value explicitly checked for is 'true'.
Anything else (including unset) is considered false.
>> Signed-off-by: Nicholas Vinson <nvinson234@gmail.com>
>> ---
>> docs/grub.texi | 10 ++++++++++
>> util/grub-mkconfig.in | 3 +++
>> util/grub.d/10_linux.in | 18 +++++++++++++++---
>
> Could you update util/grub.d/20_linux_xen.in too?
Let me see what I can do. I have never worked with xen before, so I do
not know much about it.
>
>> 3 files changed, 28 insertions(+), 3 deletions(-)
>>
>> diff --git a/docs/grub.texi b/docs/grub.texi
>> index 65b4bbeda..06f0afe45 100644
>> --- a/docs/grub.texi
>> +++ b/docs/grub.texi
>> @@ -1424,6 +1424,16 @@ the Linux kernel, using a @samp{root=UUID=...} kernel parameter. This is
>> usually more reliable, but in some cases it may not be appropriate. To
>> disable the use of UUIDs, set this option to @samp{true}.
>>
>> +@item GRUB_DISABLE_LINUX_PARTUUID
>> +If @command{grub-mkconfig} cannot identify the root filesystem via its
>> +universally-unique indentifier (UUID), @command{grub-mkconfig} will use the UUID
>> +of the partition containing the filesystem to identify the root filesystem to
>> +the Linux kernel via a @samp{root=PARTUUID=...} kernel parameter. This is not
>> +as reliable as using the filesystem UUID, but is more reliable than using the
>> +Linux device names. When enabled, this option requires the Linux kernel version
>
> s/When enabled, /When enabled, GRUB_DISABLE_LINUX_PARTUUID set to false, /
> or something like that. Otherwise it is unclear.
I'll clean up the wording in the next release.
Thanks,
Nicholas Vinson
>
> Daniel
>
next prev parent reply other threads:[~2018-04-11 3:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-07 23:28 [GRUB PARTUUID PATCH V9 0/5] Add PARTUUID detection support Nicholas Vinson
2018-04-07 23:28 ` [GRUB PARTUUID PATCH V9 1/5] Centralize guid prints Nicholas Vinson
2018-04-07 23:28 ` [GRUB PARTUUID PATCH V9 2/5] Update grub_gpt_partentry Nicholas Vinson
2018-04-07 23:28 ` [GRUB PARTUUID PATCH V9 3/5] Add PARTUUID detection support to grub-probe Nicholas Vinson
2018-04-07 23:28 ` [GRUB PARTUUID PATCH V9 4/5] Update grub script template files Nicholas Vinson
2018-04-10 20:52 ` Daniel Kiper
2018-04-11 3:00 ` Nick Vinson [this message]
2018-04-11 8:31 ` Daniel Kiper
2018-04-11 14:45 ` Nick Vinson
2018-04-16 11:47 ` Daniel Kiper
2018-04-17 5:34 ` Nick Vinson
2018-04-07 23:28 ` [GRUB PARTUUID PATCH V9 5/5] Default to disabling partition UUID support Nicholas Vinson
2018-04-10 20:56 ` [GRUB PARTUUID PATCH V9 0/5] Add PARTUUID detection support Daniel Kiper
2018-04-11 3:02 ` Nick Vinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25902d38-4c37-9c9a-19b0-aeda756c8613@gmail.com \
--to=nvinson234@gmail.com \
--cc=dkiper@net-space.pl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.