All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] ASoC: SOF: ipc3-topology: Correct get_control_data for non bytes payload
@ 2022-04-27 12:40 Peter Ujfalusi
  2022-04-27 13:08 ` Sergey Senozhatsky
  2022-04-27 13:13 ` Sergey Senozhatsky
  0 siblings, 2 replies; 8+ messages in thread
From: Peter Ujfalusi @ 2022-04-27 12:40 UTC (permalink / raw)
  To: lgirdwood, broonie, pierre-louis.bossart, senozhatsky
  Cc: cujomalainey, alsa-devel, ranjani.sridharan, kai.vehmanen

It is possible to craft a topology where sof_get_control_data() would do
out of bounds access because it expects that it is only called when the
payload is bytes type.
Confusingly it also handles other types of controls, but the payload
parsing implementation is only valid for bytes.

Fix the code to count the non bytes controls and instead of storing a
pointer to sof_abi_hdr in sof_widget_data (which is only valid for bytes),
store the pointer to the data itself and add a new member to save the size
of the data.

In case of non bytes controls we store the pointer to the chanv itself,
which is just an array of values at the end.

In case of bytes control, drop the wrong cdata->data (wdata[i].pdata) check
against NULL since it is incorrect and invalid in this context.
The data is pointing to the end of cdata struct, so it should never be
null.

Reported-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
---
Hi,

Changes since v2:
- Drop the cdata->data check against NULL as it is not a valid test and since we
  are in sof_get_control_data() the memory has been already allocated

changes since v1:
- adjust the payload size for non bytes controls by subtracting the size of the
  sof_ipc_ctrl_data struct, plus add comment to note this

Regards,
Peter

 sound/soc/sof/ipc3-topology.c | 37 +++++++++++++++++++++++------------
 1 file changed, 25 insertions(+), 12 deletions(-)

diff --git a/sound/soc/sof/ipc3-topology.c b/sound/soc/sof/ipc3-topology.c
index 572bcbfdb356..66034624e479 100644
--- a/sound/soc/sof/ipc3-topology.c
+++ b/sound/soc/sof/ipc3-topology.c
@@ -20,7 +20,8 @@
 struct sof_widget_data {
 	int ctrl_type;
 	int ipc_cmd;
-	struct sof_abi_hdr *pdata;
+	void *pdata;
+	size_t pdata_size;
 	struct snd_sof_control *control;
 };
 
@@ -784,16 +785,26 @@ static int sof_get_control_data(struct snd_soc_component *scomp,
 		}
 
 		cdata = wdata[i].control->ipc_control_data;
-		wdata[i].pdata = cdata->data;
-		if (!wdata[i].pdata)
-			return -EINVAL;
 
 		/* make sure data is valid - data can be updated at runtime */
-		if (widget->dobj.widget.kcontrol_type[i] == SND_SOC_TPLG_TYPE_BYTES &&
-		    wdata[i].pdata->magic != SOF_ABI_MAGIC)
-			return -EINVAL;
+		if (widget->dobj.widget.kcontrol_type[i] == SND_SOC_TPLG_TYPE_BYTES) {
+			if (cdata->data->magic != SOF_ABI_MAGIC)
+				return -EINVAL;
+
+			wdata[i].pdata = cdata->data->data;
+			wdata[i].pdata_size = cdata->data->size;
+		} else {
+			/* points to the control data union */
+			wdata[i].pdata = cdata->chanv;
+			/*
+			 * wdata[i].control->size is calculated with struct_size
+			 * and includes the size of struct sof_ipc_ctrl_data
+			 */
+			wdata[i].pdata_size = wdata[i].control->size -
+					      sizeof(struct sof_ipc_ctrl_data);
+		}
 
-		*size += wdata[i].pdata->size;
+		*size += wdata[i].pdata_size;
 
 		/* get data type */
 		switch (cdata->cmd) {
@@ -876,10 +887,12 @@ static int sof_process_load(struct snd_soc_component *scomp,
 	 */
 	if (ipc_data_size) {
 		for (i = 0; i < widget->num_kcontrols; i++) {
-			memcpy(&process->data[offset],
-			       wdata[i].pdata->data,
-			       wdata[i].pdata->size);
-			offset += wdata[i].pdata->size;
+			if (!wdata[i].pdata_size)
+				continue;
+
+			memcpy(&process->data[offset], wdata[i].pdata,
+			       wdata[i].pdata_size);
+			offset += wdata[i].pdata_size;
 		}
 	}
 
-- 
2.36.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH v3] ASoC: SOF: ipc3-topology: Correct get_control_data for non bytes payload
  2022-04-27 12:40 [PATCH v3] ASoC: SOF: ipc3-topology: Correct get_control_data for non bytes payload Peter Ujfalusi
@ 2022-04-27 13:08 ` Sergey Senozhatsky
  2022-04-27 13:09   ` Sergey Senozhatsky
  2022-04-27 13:26   ` Sergey Senozhatsky
  2022-04-27 13:13 ` Sergey Senozhatsky
  1 sibling, 2 replies; 8+ messages in thread
From: Sergey Senozhatsky @ 2022-04-27 13:08 UTC (permalink / raw)
  To: Peter Ujfalusi
  Cc: pierre-louis.bossart, alsa-devel, kai.vehmanen, cujomalainey,
	ranjani.sridharan, lgirdwood, senozhatsky, broonie

On (22/04/27 15:40), Peter Ujfalusi wrote:
> It is possible to craft a topology where sof_get_control_data() would do
> out of bounds access because it expects that it is only called when the
> payload is bytes type.
> Confusingly it also handles other types of controls, but the payload
> parsing implementation is only valid for bytes.
> 
> Fix the code to count the non bytes controls and instead of storing a
> pointer to sof_abi_hdr in sof_widget_data (which is only valid for bytes),
> store the pointer to the data itself and add a new member to save the size
> of the data.
> 
> In case of non bytes controls we store the pointer to the chanv itself,
> which is just an array of values at the end.
> 
> In case of bytes control, drop the wrong cdata->data (wdata[i].pdata) check
> against NULL since it is incorrect and invalid in this context.
> The data is pointing to the end of cdata struct, so it should never be
> null.
> 
> Reported-by: Sergey Senozhatsky <senozhatsky@chromium.org>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
> ---
> Hi,
> 
> Changes since v2:
> - Drop the cdata->data check against NULL as it is not a valid test and since we
>   are in sof_get_control_data() the memory has been already allocated
> 
> changes since v1:
> - adjust the payload size for non bytes controls by subtracting the size of the
>   sof_ipc_ctrl_data struct, plus add comment to note this

A corresponding 5.10 backport that "works on my computer".

I also have a 5.4 backport but it's entirely untested.

---
 sound/soc/sof/topology.c | 39 ++++++++++++++++++++++++++-------------
 1 file changed, 26 insertions(+), 13 deletions(-)

diff --git a/sound/soc/sof/topology.c b/sound/soc/sof/topology.c
index c1fc7bcf4eb5..04a721f9a7f9 100644
--- a/sound/soc/sof/topology.c
+++ b/sound/soc/sof/topology.c
@@ -50,7 +50,8 @@
 struct sof_widget_data {
 	int ctrl_type;
 	int ipc_cmd;
-	struct sof_abi_hdr *pdata;
+	void *pdata;
+	size_t pdata_size;
 	struct snd_sof_control *control;
 };
 
@@ -2100,6 +2101,7 @@ static int sof_get_control_data(struct snd_soc_component *scomp,
 				size_t *size)
 {
 	const struct snd_kcontrol_new *kc;
+	struct sof_ipc_ctrl_data *cdata;
 	struct soc_mixer_control *sm;
 	struct soc_bytes_ext *sbe;
 	struct soc_enum *se;
@@ -2136,16 +2138,25 @@ static int sof_get_control_data(struct snd_soc_component *scomp,
 			return -EINVAL;
 		}
 
-		wdata[i].pdata = wdata[i].control->control_data->data;
-		if (!wdata[i].pdata)
-			return -EINVAL;
+		cdata = wdata[i].control->control_data;
+		if (widget->dobj.widget.kcontrol_type[i] == SND_SOC_TPLG_TYPE_BYTES) {
+			if (cdata->data->magic != SOF_ABI_MAGIC)
+				return -EINVAL;
 
-		/* make sure data is valid - data can be updated at runtime */
-		if (widget->dobj.widget.kcontrol_type[i] == SND_SOC_TPLG_TYPE_BYTES &&
-		    wdata[i].pdata->magic != SOF_ABI_MAGIC)
-			return -EINVAL;
+			wdata[i].pdata = cdata->data->data;
+			wdata[i].pdata_size = cdata->data->size;
+		} else {
+			/* points to the control data union */
+			wdata[i].pdata = cdata->chanv;
+			/*
+			 * wdata[i].control->size is calculated with struct_size
+			 * and includes the size of struct sof_ipc_ctrl_data
+			 */
+			wdata[i].pdata_size = wdata[i].control->size -
+					      sizeof(struct sof_ipc_ctrl_data);
+		}
 
-		*size += wdata[i].pdata->size;
+		*size += wdata[i].pdata_size;
 
 		/* get data type */
 		switch (wdata[i].control->cmd) {
@@ -2236,10 +2247,12 @@ static int sof_process_load(struct snd_soc_component *scomp, int index,
 	 */
 	if (ipc_data_size) {
 		for (i = 0; i < widget->num_kcontrols; i++) {
-			memcpy(&process->data + offset,
-			       wdata[i].pdata->data,
-			       wdata[i].pdata->size);
-			offset += wdata[i].pdata->size;
+			if (!wdata[i].pdata_size)
+				continue;
+
+			memcpy(&process->data[offset], wdata[i].pdata,
+			       wdata[i].pdata_size);
+			offset += wdata[i].pdata_size;
 		}
 	}
 
-- 
2.31.0

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH v3] ASoC: SOF: ipc3-topology: Correct get_control_data for non bytes payload
  2022-04-27 13:08 ` Sergey Senozhatsky
@ 2022-04-27 13:09   ` Sergey Senozhatsky
  2022-04-27 13:26   ` Sergey Senozhatsky
  1 sibling, 0 replies; 8+ messages in thread
From: Sergey Senozhatsky @ 2022-04-27 13:09 UTC (permalink / raw)
  To: Sergey Senozhatsky
  Cc: pierre-louis.bossart, alsa-devel, kai.vehmanen, cujomalainey,
	ranjani.sridharan, lgirdwood, broonie, Peter Ujfalusi

On (22/04/27 22:08), Sergey Senozhatsky wrote:
> 
> I also have a 5.4 backport but it's entirely untested.

5.4

---

diff --git a/sound/soc/sof/topology.c b/sound/soc/sof/topology.c
index fa299e078156..a70b7e71c235 100644
--- a/sound/soc/sof/topology.c
+++ b/sound/soc/sof/topology.c
@@ -45,7 +45,8 @@
 struct sof_widget_data {
 	int ctrl_type;
 	int ipc_cmd;
-	struct sof_abi_hdr *pdata;
+	void *pdata;
+	size_t pdata_size;
 	struct snd_sof_control *control;
 };
 
@@ -1761,6 +1762,7 @@ static int sof_get_control_data(struct snd_sof_dev *sdev,
 				size_t *size)
 {
 	const struct snd_kcontrol_new *kc;
+	struct sof_ipc_ctrl_data *cdata;
 	struct soc_mixer_control *sm;
 	struct soc_bytes_ext *sbe;
 	struct soc_enum *se;
@@ -1797,15 +1799,25 @@ static int sof_get_control_data(struct snd_sof_dev *sdev,
 			return -EINVAL;
 		}
 
-		wdata[i].pdata = wdata[i].control->control_data->data;
-		if (!wdata[i].pdata)
-			return -EINVAL;
+		cdata = wdata[i].control->control_data;
+		if (widget->dobj.widget.kcontrol_type[i] == SND_SOC_TPLG_TYPE_BYTES) {
+			if (cdata->data->magic != SOF_ABI_MAGIC)
+				return -EINVAL;
 
-		/* make sure data is valid - data can be updated at runtime */
-		if (wdata[i].pdata->magic != SOF_ABI_MAGIC)
-			return -EINVAL;
+			wdata[i].pdata = cdata->data->data;
+			wdata[i].pdata_size = cdata->data->size;
+		} else {
+			/* points to the control data union */
+			wdata[i].pdata = cdata->chanv;
+			/*
+			 * wdata[i].control->size is calculated with struct_size
+			 * and includes the size of struct sof_ipc_ctrl_data
+			 */
+			wdata[i].pdata_size = wdata[i].control->size -
+					      sizeof(struct sof_ipc_ctrl_data);
+		}
 
-		*size += wdata[i].pdata->size;
+		*size += wdata[i].pdata_size;
 
 		/* get data type */
 		switch (wdata[i].control->cmd) {
@@ -1909,10 +1921,12 @@ static int sof_process_load(struct snd_soc_component *scomp, int index,
 	 */
 	if (ipc_data_size) {
 		for (i = 0; i < widget->num_kcontrols; i++) {
-			memcpy(&process->data + offset,
-			       wdata[i].pdata->data,
-			       wdata[i].pdata->size);
-			offset += wdata[i].pdata->size;
+			if (!wdata[i].pdata_size)
+				continue;
+
+			memcpy(&process->data[offset], wdata[i].pdata,
+			       wdata[i].pdata_size);
+			offset += wdata[i].pdata_size;
 		}
 	}
 

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH v3] ASoC: SOF: ipc3-topology: Correct get_control_data for non bytes payload
  2022-04-27 12:40 [PATCH v3] ASoC: SOF: ipc3-topology: Correct get_control_data for non bytes payload Peter Ujfalusi
  2022-04-27 13:08 ` Sergey Senozhatsky
@ 2022-04-27 13:13 ` Sergey Senozhatsky
  2022-04-27 13:20   ` Sergey Senozhatsky
  1 sibling, 1 reply; 8+ messages in thread
From: Sergey Senozhatsky @ 2022-04-27 13:13 UTC (permalink / raw)
  To: Peter Ujfalusi
  Cc: pierre-louis.bossart, alsa-devel, kai.vehmanen, cujomalainey,
	ranjani.sridharan, lgirdwood, senozhatsky, broonie

On (22/04/27 15:40), Peter Ujfalusi wrote:
[..]
>  struct sof_widget_data {
>  	int ctrl_type;
>  	int ipc_cmd;
> -	struct sof_abi_hdr *pdata;
> +	void *pdata;
> +	size_t pdata_size;
>  	struct snd_sof_control *control;
>  };
>  
> @@ -784,16 +785,26 @@ static int sof_get_control_data(struct snd_soc_component *scomp,
>  		}
>  
>  		cdata = wdata[i].control->ipc_control_data;
> -		wdata[i].pdata = cdata->data;
> -		if (!wdata[i].pdata)
> -			return -EINVAL;
>  
>  		/* make sure data is valid - data can be updated at runtime */

A silly nit: does this comment belong to SOF_ABI_MAGIC check below?

> -		if (widget->dobj.widget.kcontrol_type[i] == SND_SOC_TPLG_TYPE_BYTES &&
> -		    wdata[i].pdata->magic != SOF_ABI_MAGIC)
> -			return -EINVAL;
> +		if (widget->dobj.widget.kcontrol_type[i] == SND_SOC_TPLG_TYPE_BYTES) {
> +			if (cdata->data->magic != SOF_ABI_MAGIC)
> +				return -EINVAL;


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v3] ASoC: SOF: ipc3-topology: Correct get_control_data for non bytes payload
  2022-04-27 13:13 ` Sergey Senozhatsky
@ 2022-04-27 13:20   ` Sergey Senozhatsky
  2022-04-27 18:47     ` Péter Ujfalusi
  0 siblings, 1 reply; 8+ messages in thread
From: Sergey Senozhatsky @ 2022-04-27 13:20 UTC (permalink / raw)
  To: Sergey Senozhatsky
  Cc: pierre-louis.bossart, alsa-devel, kai.vehmanen, cujomalainey,
	ranjani.sridharan, lgirdwood, broonie, Peter Ujfalusi

On (22/04/27 22:13), Sergey Senozhatsky wrote:
> > @@ -784,16 +785,26 @@ static int sof_get_control_data(struct snd_soc_component *scomp,
> >  		}
> >  
> >  		cdata = wdata[i].control->ipc_control_data;
> > -		wdata[i].pdata = cdata->data;
> > -		if (!wdata[i].pdata)
> > -			return -EINVAL;
> >  
> >  		/* make sure data is valid - data can be updated at runtime */
> 
> A silly nit: does this comment belong to SOF_ABI_MAGIC check below?

I mean something like this?

---
 
 		cdata = wdata[i].control->ipc_control_data;
 
-		/* make sure data is valid - data can be updated at runtime */
 		if (widget->dobj.widget.kcontrol_type[i] == SND_SOC_TPLG_TYPE_BYTES) {
+			/*
+			 * make sure data is valid - data can be updated at
+			 * runtime
+			 */
 			if (cdata->data->magic != SOF_ABI_MAGIC)
 				return -EINVAL;
 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v3] ASoC: SOF: ipc3-topology: Correct get_control_data for non bytes payload
  2022-04-27 13:08 ` Sergey Senozhatsky
  2022-04-27 13:09   ` Sergey Senozhatsky
@ 2022-04-27 13:26   ` Sergey Senozhatsky
  1 sibling, 0 replies; 8+ messages in thread
From: Sergey Senozhatsky @ 2022-04-27 13:26 UTC (permalink / raw)
  To: Sergey Senozhatsky
  Cc: pierre-louis.bossart, alsa-devel, kai.vehmanen, cujomalainey,
	ranjani.sridharan, lgirdwood, broonie, Peter Ujfalusi

On (22/04/27 22:08), Sergey Senozhatsky wrote:
> 
> A corresponding 5.10 backport that "works on my computer".
> 

+ comment

---
 sound/soc/sof/topology.c | 43 ++++++++++++++++++++++++++++------------
 1 file changed, 30 insertions(+), 13 deletions(-)

diff --git a/sound/soc/sof/topology.c b/sound/soc/sof/topology.c
index c1fc7bcf4eb5..5f14ac120742 100644
--- a/sound/soc/sof/topology.c
+++ b/sound/soc/sof/topology.c
@@ -50,7 +50,8 @@
 struct sof_widget_data {
 	int ctrl_type;
 	int ipc_cmd;
-	struct sof_abi_hdr *pdata;
+	void *pdata;
+	size_t pdata_size;
 	struct snd_sof_control *control;
 };
 
@@ -2100,6 +2101,7 @@ static int sof_get_control_data(struct snd_soc_component *scomp,
 				size_t *size)
 {
 	const struct snd_kcontrol_new *kc;
+	struct sof_ipc_ctrl_data *cdata;
 	struct soc_mixer_control *sm;
 	struct soc_bytes_ext *sbe;
 	struct soc_enum *se;
@@ -2136,16 +2138,29 @@ static int sof_get_control_data(struct snd_soc_component *scomp,
 			return -EINVAL;
 		}
 
-		wdata[i].pdata = wdata[i].control->control_data->data;
-		if (!wdata[i].pdata)
-			return -EINVAL;
+		cdata = wdata[i].control->control_data;
+		if (widget->dobj.widget.kcontrol_type[i] == SND_SOC_TPLG_TYPE_BYTES) {
+			/*
+			 * make sure data is valid - data can be updated at
+			 * runtime
+			 */
+			if (cdata->data->magic != SOF_ABI_MAGIC)
+				return -EINVAL;
 
-		/* make sure data is valid - data can be updated at runtime */
-		if (widget->dobj.widget.kcontrol_type[i] == SND_SOC_TPLG_TYPE_BYTES &&
-		    wdata[i].pdata->magic != SOF_ABI_MAGIC)
-			return -EINVAL;
+			wdata[i].pdata = cdata->data->data;
+			wdata[i].pdata_size = cdata->data->size;
+		} else {
+			/* points to the control data union */
+			wdata[i].pdata = cdata->chanv;
+			/*
+			 * wdata[i].control->size is calculated with struct_size
+			 * and includes the size of struct sof_ipc_ctrl_data
+			 */
+			wdata[i].pdata_size = wdata[i].control->size -
+					      sizeof(struct sof_ipc_ctrl_data);
+		}
 
-		*size += wdata[i].pdata->size;
+		*size += wdata[i].pdata_size;
 
 		/* get data type */
 		switch (wdata[i].control->cmd) {
@@ -2236,10 +2251,12 @@ static int sof_process_load(struct snd_soc_component *scomp, int index,
 	 */
 	if (ipc_data_size) {
 		for (i = 0; i < widget->num_kcontrols; i++) {
-			memcpy(&process->data + offset,
-			       wdata[i].pdata->data,
-			       wdata[i].pdata->size);
-			offset += wdata[i].pdata->size;
+			if (!wdata[i].pdata_size)
+				continue;
+
+			memcpy(&process->data[offset], wdata[i].pdata,
+			       wdata[i].pdata_size);
+			offset += wdata[i].pdata_size;
 		}
 	}
 
-- 
2.31.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH v3] ASoC: SOF: ipc3-topology: Correct get_control_data for non bytes payload
  2022-04-27 13:20   ` Sergey Senozhatsky
@ 2022-04-27 18:47     ` Péter Ujfalusi
  2022-04-28  2:19       ` Sergey Senozhatsky
  0 siblings, 1 reply; 8+ messages in thread
From: Péter Ujfalusi @ 2022-04-27 18:47 UTC (permalink / raw)
  To: Sergey Senozhatsky
  Cc: pierre-louis.bossart, alsa-devel, kai.vehmanen, cujomalainey,
	ranjani.sridharan, lgirdwood, broonie



On 27/04/2022 16:20, Sergey Senozhatsky wrote:
> On (22/04/27 22:13), Sergey Senozhatsky wrote:
>>> @@ -784,16 +785,26 @@ static int sof_get_control_data(struct snd_soc_component *scomp,
>>>  		}
>>>  
>>>  		cdata = wdata[i].control->ipc_control_data;
>>> -		wdata[i].pdata = cdata->data;
>>> -		if (!wdata[i].pdata)
>>> -			return -EINVAL;
>>>  
>>>  		/* make sure data is valid - data can be updated at runtime */
>>
>> A silly nit: does this comment belong to SOF_ABI_MAGIC check below?
> 
> I mean something like this?

yes, makes sense. Although I also played with the idea of dropping the
ABI magic check as well, but let's keep it for now.
> 
> ---
>  
>  		cdata = wdata[i].control->ipc_control_data;
>  
> -		/* make sure data is valid - data can be updated at runtime */
>  		if (widget->dobj.widget.kcontrol_type[i] == SND_SOC_TPLG_TYPE_BYTES) {
> +			/*
> +			 * make sure data is valid - data can be updated at
> +			 * runtime
> +			 */
>  			if (cdata->data->magic != SOF_ABI_MAGIC)
>  				return -EINVAL;
>  

-- 
Péter

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v3] ASoC: SOF: ipc3-topology: Correct get_control_data for non bytes payload
  2022-04-27 18:47     ` Péter Ujfalusi
@ 2022-04-28  2:19       ` Sergey Senozhatsky
  0 siblings, 0 replies; 8+ messages in thread
From: Sergey Senozhatsky @ 2022-04-28  2:19 UTC (permalink / raw)
  To: Péter Ujfalusi
  Cc: pierre-louis.bossart, alsa-devel, kai.vehmanen, cujomalainey,
	ranjani.sridharan, lgirdwood, Sergey Senozhatsky, broonie

On (22/04/27 21:47), Péter Ujfalusi wrote:
> 
> Although I also played with the idea of dropping the
> ABI magic check as well, but let's keep it for now.

Agreed. This is fine for -next, but for -stable we probably would
want only parts that fix issues.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-04-28  2:20 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-27 12:40 [PATCH v3] ASoC: SOF: ipc3-topology: Correct get_control_data for non bytes payload Peter Ujfalusi
2022-04-27 13:08 ` Sergey Senozhatsky
2022-04-27 13:09   ` Sergey Senozhatsky
2022-04-27 13:26   ` Sergey Senozhatsky
2022-04-27 13:13 ` Sergey Senozhatsky
2022-04-27 13:20   ` Sergey Senozhatsky
2022-04-27 18:47     ` Péter Ujfalusi
2022-04-28  2:19       ` Sergey Senozhatsky

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.