From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B0C1C004D4 for ; Thu, 19 Jan 2023 09:31:30 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 61FAF410DD; Thu, 19 Jan 2023 10:31:29 +0100 (CET) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 302944068E for ; Thu, 19 Jan 2023 10:31:28 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 5953A32008FB; Thu, 19 Jan 2023 04:31:26 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 19 Jan 2023 04:31:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1674120685; x= 1674207085; bh=D1ZunzVIWCYvXo0S5jMbOpjVUJDmTYTyFqDYyoFLzd8=; b=S 6l+hxxPOb7Zpnp0Fzx/1ThZxGvJXC4ep6o5a5zudB0lMmOsTrAZPg67wvJZIUUmy 7rR+HfC+rQqVMsrJaWFbCxXI52lN7GeQwYon/vzBff/g/asXmOpboQjjRXljy9RJ DhhGwMkyHF0kMg1NSSvGbkM5trPad9Hq+IqG4XhPgiGhhy1E0h5G3n4vDeB9qqKy rfgCn0yOITLtuFusoInd8lyaOs2zieVnySE46PTth/0qAG9b/2zT3LG+saVtNtZ2 Mr4UyjmKjThk5BZR3Ku+cnX3hdtoc9l66jrVqbezVwAoLJ/8JNCNN2VpWn3JXeKg vXEa3JxHtzzpN2F1gMjnw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1674120685; x= 1674207085; bh=D1ZunzVIWCYvXo0S5jMbOpjVUJDmTYTyFqDYyoFLzd8=; b=H fARI/1RXk0Xo//SQKVrimfC7dZZSX0KgWjuJzF6qB1NphbzEYBYemjcM2+NjFdHC ZeWEV0Ii1pqHzoNrSlgh6HyLNY+jdfN2qYt1cCPwyXT6YQkUqlf38xRgwiMtmJKl 2Ah8Ieh0Ywe2NuQHkLLz9m9+1TP1HHozc1iBxIFUDqvzzmdRzWFSkLusOZwuosqx dX0m3bvZenhH1oxPmS/by9JWOQLM0y7Z/kqLurzeTLrHQLH0MVJCGXanYvpm79tX Cvbitqw+rhqNaSr6Cg6r5rG9Amtj1EE/BXPkTIIz7KYXGMqg/UGMrshRa0Pe0t7C mJTy0wuUEDWyichK5mcxA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddutddgtdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 19 Jan 2023 04:31:24 -0500 (EST) From: Thomas Monjalon To: Gregory Etelson Cc: "dev@dpdk.org" , Matan Azrad , Raslan Darawsheh , Ori Kam , Aman Singh , Yuying Zhang , Ferruh Yigit , Slava Ovsiienko , Andrew Rybchenko , "ivan.malov@oktetlabs.ru" , "jerinj@marvell.com" Subject: Re: [PATCH v4 2/2] ethdev: add quota flow action and item Date: Thu, 19 Jan 2023 10:31:22 +0100 Message-ID: <2597127.MzOyzyC30C@thomas> In-Reply-To: References: <20221221073547.988-1-getelson@nvidia.com> <3529184.clyjiGRsXx@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 19/01/2023 10:13, Gregory Etelson: > Hello Thomas, > > > Is this patch related to query/update of indirect flow action? > > It looks like it should be in a separate series. > > > > Quota flow action updates relay on rte_flow_action_handle_query_update(). > Also, the function is used in the testmd patch section. Yes we still don't have the tool in CI to mark series dependency. > > > + /** > > > + * Apply quota verdict - PASS or BLOCK to a flow. > > > > Is "to" really wanted here? > > What about "pass or block a flow"? > > > > The flow action provides information only - it does not affect flow in any way. > Application needs to match on quota flow item after quota action to discover quota state. > It's also up to application how to react on quota state. I am still not sure to understand the comment. Is this one better? "Apply the quota verdict (PASS or BLOCK) to a flow." > > > +struct rte_flow_action_quota { > > > + enum rte_flow_quota_mode mode; /** quota operational mode */ > > > + int64_t quota; /** quota value */ > > > > What means a negative quota? > > Negative quota is kind of a loan extended by a hardware if it provides such option. > If quota value is -T, application must provide at least (T+1) tokens to return quota to PASS state. OK. Is it documented?