From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA803C433F5 for ; Wed, 6 Oct 2021 08:13:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7AF1610C9 for ; Wed, 6 Oct 2021 08:13:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A7AF1610C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EVe7PsunpKb0HhQaXUKBYq7FsiUE+MtiRwr43MCtGC4=; b=29tKE0Z3fb05ef N/lw9nDfdsoCshrJEEXkCLwMedP0Gjg4ndNgpADTzTKCV/0eDqud5f5ys/KrNIE8NWBI7IdJ678Cb yUvEwvdmukY8dsDm3qcDP2WtFrPAqllWHVEJQcOVxUe36VLgjRpCGjtdUI/TCK7fZ4neMEzl0Z8CP H3xXyI0J2xJh2HQKQEmBIMtqqmvuDppbBpFZp9k19NHf9lnaseeE7af/8UMQMg0kyX/jZlZ64zsPC CpBUdPF3QgFA76ntQXVQcIQU7qhgUmodhgM8/1y+5q6/A8kNc+fon64/tG1EGCHUs04XMoXn/T6Ok asFVOoH4/JxggeOx86mw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mY21W-00DNb4-Ib; Wed, 06 Oct 2021 08:11:34 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mY21R-00DNZZ-ND for linux-arm-kernel@lists.infradead.org; Wed, 06 Oct 2021 08:11:31 +0000 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mY21Q-0004MB-66; Wed, 06 Oct 2021 10:11:28 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1mY21P-0003fq-Ex; Wed, 06 Oct 2021 10:11:27 +0200 Message-ID: <259b33224f9d63437fb746345fefd5309c546faa.camel@pengutronix.de> Subject: Re: [PATCH] ARM: imx: register reset controller from a platform driver From: Philipp Zabel To: Geert Uytterhoeven Cc: Linux ARM , Shawn Guo , Sascha Hauer , Saravana Kannan , Fabio Estevam Date: Wed, 06 Oct 2021 10:11:27 +0200 In-Reply-To: References: <20211005100618.730907-1-p.zabel@pengutronix.de> User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211006_011129_807000_EA259A66 X-CRM114-Status: GOOD ( 17.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Geert, On Wed, 2021-10-06 at 09:23 +0200, Geert Uytterhoeven wrote: > Hi Philipp, > > On Tue, Oct 5, 2021 at 12:12 PM Philipp Zabel wrote: > > Starting with commit 6b2117ad65f1 ("of: property: fw_devlink: Add > > support for "resets" and "pwms""), the imx-drm driver fails to load > > due to forever dormant devlinks to the reset-controller node. This > > node was never associated with a struct device. > > > > Add a platform device to allow fw_devnode to activate the devlinks. > > > > Fixes: 6b2117ad65f1 ("of: property: fw_devlink: Add support for "resets" and "pwms"") > > Signed-off-by: Philipp Zabel > > Thanks for your patch! > > Do you also need a "select RESET_CONTROLLER" somewhere for > this to work? Right now we have this: config SOC_IMX... select HAVE_IMX_SRC config HAVE_IMX_SRC select ARCH_HAS_RESET_CONTROLLER config ARCH_HAS_RESET_CONTROLLER bool config RESET_CONTROLLER default y if ARCH_HAS_RESET_CONTROLLER So it is possible to manually disable RESET_CONTROLLER if the drivers using those resets are not required. regards Philipp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel