From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Louis Luo <llouis@vmware.com>, yongwang@vmware.com
Cc: dev@dpdk.org
Subject: Re: [PATCH] net/vmxnet3: convert to new rx offload api
Date: Tue, 1 May 2018 15:58:52 +0100 [thread overview]
Message-ID: <25c3daf3-4330-68af-1022-bb6450c6af05@intel.com> (raw)
In-Reply-To: <1525126835-21775-1-git-send-email-llouis@vmware.com>
On 4/30/2018 11:20 PM, Louis Luo wrote:
> Ethdev RX offloads API has changed since: commit ce17eddefc20
> ("ethdev: introduce Rx queue offloads API")
>
> This patch adopts the new RX Offload API in vmxnet3 driver.
>
> Signed-off-by: Louis Luo <llouis@vmware.com>
Hi Louis,
Overall patch looks good, only there is 32bits build error because of logging,
more details below.
Can you please send a new version of the patch, keeping Yong's ack.
<...>
> @@ -376,9 +393,25 @@ vmxnet3_dev_configure(struct rte_eth_dev *dev)
> const struct rte_memzone *mz;
> struct vmxnet3_hw *hw = dev->data->dev_private;
> size_t size;
> + uint64_t rx_offloads = dev->data->dev_conf.rxmode.offloads;
> + uint64_t tx_offloads = dev->data->dev_conf.txmode.offloads;
>
> PMD_INIT_FUNC_TRACE();
>
> + if ((rx_offloads & VMXNET3_RX_OFFLOAD_CAP) != rx_offloads) {
> + RTE_LOG(ERR, PMD, "Requested RX offloads 0x%lx"
> + " do not match supported 0x%lx\n",
> + rx_offloads, (uint64_t)VMXNET3_RX_OFFLOAD_CAP);
%lx usage causing build error with 32bit build [1], please prefer PRIx64.
[1]
argument of type "uint64_t={__uint64_t={unsigned long long}}" is incompatible
with format "%lx", expecting argument of type "unsigned long"
<...>
next prev parent reply other threads:[~2018-05-01 14:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 22:20 [PATCH] net/vmxnet3: convert to new rx offload api Louis Luo
2018-04-30 22:50 ` Yong Wang
2018-05-01 14:58 ` Ferruh Yigit [this message]
2018-05-01 17:32 ` Louis Luo
2018-05-02 9:16 ` Ferruh Yigit
2018-05-01 18:10 Louis Luo
2018-05-01 19:01 ` Thomas Monjalon
2018-05-01 21:22 ` Louis Luo
2018-05-02 10:41 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25c3daf3-4330-68af-1022-bb6450c6af05@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=llouis@vmware.com \
--cc=yongwang@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.