* [PATCH] qtest: add a reproducer for LP#1878642
@ 2020-11-02 16:33 Alexander Bulekov
2020-11-02 18:23 ` Paolo Bonzini
2021-02-16 13:25 ` Peter Maydell
0 siblings, 2 replies; 8+ messages in thread
From: Alexander Bulekov @ 2020-11-02 16:33 UTC (permalink / raw)
To: qemu-devel
Cc: Laurent Vivier, Alexander Bulekov, Thomas Huth, f4bug, Paolo Bonzini
https://bugs.launchpad.net/qemu/+bug/1878642
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
---
Based-on: <20200717151705.18611-1-f4bug@amsat.org>
The added testcase will fail, unless this ^^^ patch is applied.
tests/qtest/fuzz-test.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/tests/qtest/fuzz-test.c b/tests/qtest/fuzz-test.c
index 2f38bb1ec2..9cb4c42bde 100644
--- a/tests/qtest/fuzz-test.c
+++ b/tests/qtest/fuzz-test.c
@@ -34,6 +34,19 @@ static void test_lp1878263_megasas_zero_iov_cnt(void)
qtest_quit(s);
}
+static void test_lp1878642_pci_bus_get_irq_level_assert(void)
+{
+ QTestState *s;
+
+ s = qtest_init("-M pc-q35-5.0 "
+ "-nographic -monitor none -serial none "
+ "-d guest_errors -trace pci*");
+
+ qtest_outl(s, 0xcf8, 0x8400f841);
+ qtest_outl(s, 0xcfc, 0xebed205d);
+ qtest_outl(s, 0x5d02, 0xebed205d);
+}
+
int main(int argc, char **argv)
{
const char *arch = qtest_get_arch();
@@ -43,6 +56,8 @@ int main(int argc, char **argv)
if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
qtest_add_func("fuzz/test_lp1878263_megasas_zero_iov_cnt",
test_lp1878263_megasas_zero_iov_cnt);
+ qtest_add_func("fuzz/test_lp1878642_pci_bus_get_irq_level_assert",
+ test_lp1878642_pci_bus_get_irq_level_assert);
}
return g_test_run();
--
2.28.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] qtest: add a reproducer for LP#1878642
2020-11-02 16:33 [PATCH] qtest: add a reproducer for LP#1878642 Alexander Bulekov
@ 2020-11-02 18:23 ` Paolo Bonzini
2020-11-02 18:58 ` Philippe Mathieu-Daudé
2021-02-16 13:25 ` Peter Maydell
1 sibling, 1 reply; 8+ messages in thread
From: Paolo Bonzini @ 2020-11-02 18:23 UTC (permalink / raw)
To: Alexander Bulekov, qemu-devel; +Cc: Laurent Vivier, Thomas Huth, f4bug
On 02/11/20 17:33, Alexander Bulekov wrote:
> https://bugs.launchpad.net/qemu/+bug/1878642
>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> ---
>
> Based-on: <20200717151705.18611-1-f4bug@amsat.org>
>
> The added testcase will fail, unless this ^^^ patch is applied.
>
> tests/qtest/fuzz-test.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/tests/qtest/fuzz-test.c b/tests/qtest/fuzz-test.c
> index 2f38bb1ec2..9cb4c42bde 100644
> --- a/tests/qtest/fuzz-test.c
> +++ b/tests/qtest/fuzz-test.c
> @@ -34,6 +34,19 @@ static void test_lp1878263_megasas_zero_iov_cnt(void)
> qtest_quit(s);
> }
>
> +static void test_lp1878642_pci_bus_get_irq_level_assert(void)
> +{
> + QTestState *s;
> +
> + s = qtest_init("-M pc-q35-5.0 "
> + "-nographic -monitor none -serial none "
> + "-d guest_errors -trace pci*");
> +
> + qtest_outl(s, 0xcf8, 0x8400f841);
> + qtest_outl(s, 0xcfc, 0xebed205d);
> + qtest_outl(s, 0x5d02, 0xebed205d);
> +}
> +
> int main(int argc, char **argv)
> {
> const char *arch = qtest_get_arch();
> @@ -43,6 +56,8 @@ int main(int argc, char **argv)
> if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
> qtest_add_func("fuzz/test_lp1878263_megasas_zero_iov_cnt",
> test_lp1878263_megasas_zero_iov_cnt);
> + qtest_add_func("fuzz/test_lp1878642_pci_bus_get_irq_level_assert",
> + test_lp1878642_pci_bus_get_irq_level_assert);
> }
>
> return g_test_run();
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] qtest: add a reproducer for LP#1878642
2020-11-02 18:23 ` Paolo Bonzini
@ 2020-11-02 18:58 ` Philippe Mathieu-Daudé
2020-11-09 14:37 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-11-02 18:58 UTC (permalink / raw)
To: Paolo Bonzini, Alexander Bulekov, qemu-devel; +Cc: Laurent Vivier, Thomas Huth
On 11/2/20 7:23 PM, Paolo Bonzini wrote:
> On 02/11/20 17:33, Alexander Bulekov wrote:
>> https://bugs.launchpad.net/qemu/+bug/1878642
>>
>> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
>> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
>> ---
>>
>> Based-on: <20200717151705.18611-1-f4bug@amsat.org>
>>
>> The added testcase will fail, unless this ^^^ patch is applied.
>>
>> tests/qtest/fuzz-test.c | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/tests/qtest/fuzz-test.c b/tests/qtest/fuzz-test.c
>> index 2f38bb1ec2..9cb4c42bde 100644
>> --- a/tests/qtest/fuzz-test.c
>> +++ b/tests/qtest/fuzz-test.c
>> @@ -34,6 +34,19 @@ static void test_lp1878263_megasas_zero_iov_cnt(void)
>> qtest_quit(s);
>> }
>>
>> +static void test_lp1878642_pci_bus_get_irq_level_assert(void)
>> +{
>> + QTestState *s;
>> +
>> + s = qtest_init("-M pc-q35-5.0 "
>> + "-nographic -monitor none -serial none "
>> + "-d guest_errors -trace pci*");
>> +
>> + qtest_outl(s, 0xcf8, 0x8400f841);
>> + qtest_outl(s, 0xcfc, 0xebed205d);
>> + qtest_outl(s, 0x5d02, 0xebed205d);
>> +}
>> +
>> int main(int argc, char **argv)
>> {
>> const char *arch = qtest_get_arch();
>> @@ -43,6 +56,8 @@ int main(int argc, char **argv)
>> if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
>> qtest_add_func("fuzz/test_lp1878263_megasas_zero_iov_cnt",
>> test_lp1878263_megasas_zero_iov_cnt);
>> + qtest_add_func("fuzz/test_lp1878642_pci_bus_get_irq_level_assert",
>> + test_lp1878642_pci_bus_get_irq_level_assert);
>> }
>>
>> return g_test_run();
>>
>
> Queued, thanks.
Great, did you queued the fix too?
(https://www.mail-archive.com/qemu-devel@nongnu.org/msg725783.html)
Regards,
Phil.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] qtest: add a reproducer for LP#1878642
2020-11-02 18:58 ` Philippe Mathieu-Daudé
@ 2020-11-09 14:37 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-11-09 14:37 UTC (permalink / raw)
To: Paolo Bonzini, Thomas Huth; +Cc: Laurent Vivier, Alexander Bulekov, qemu-devel
On 11/2/20 7:58 PM, Philippe Mathieu-Daudé wrote:
> On 11/2/20 7:23 PM, Paolo Bonzini wrote:
>> On 02/11/20 17:33, Alexander Bulekov wrote:
>>> https://bugs.launchpad.net/qemu/+bug/1878642
>>>
>>> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
>>> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
>>> ---
>>>
>>> Based-on: <20200717151705.18611-1-f4bug@amsat.org>
>>>
>>> The added testcase will fail, unless this ^^^ patch is applied.
>>>
>>> tests/qtest/fuzz-test.c | 15 +++++++++++++++
>>> 1 file changed, 15 insertions(+)
>>>
>>> diff --git a/tests/qtest/fuzz-test.c b/tests/qtest/fuzz-test.c
>>> index 2f38bb1ec2..9cb4c42bde 100644
>>> --- a/tests/qtest/fuzz-test.c
>>> +++ b/tests/qtest/fuzz-test.c
>>> @@ -34,6 +34,19 @@ static void test_lp1878263_megasas_zero_iov_cnt(void)
>>> qtest_quit(s);
>>> }
>>>
>>> +static void test_lp1878642_pci_bus_get_irq_level_assert(void)
>>> +{
>>> + QTestState *s;
>>> +
>>> + s = qtest_init("-M pc-q35-5.0 "
>>> + "-nographic -monitor none -serial none "
>>> + "-d guest_errors -trace pci*");
>>> +
>>> + qtest_outl(s, 0xcf8, 0x8400f841);
>>> + qtest_outl(s, 0xcfc, 0xebed205d);
>>> + qtest_outl(s, 0x5d02, 0xebed205d);
>>> +}
>>> +
>>> int main(int argc, char **argv)
>>> {
>>> const char *arch = qtest_get_arch();
>>> @@ -43,6 +56,8 @@ int main(int argc, char **argv)
>>> if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
>>> qtest_add_func("fuzz/test_lp1878263_megasas_zero_iov_cnt",
>>> test_lp1878263_megasas_zero_iov_cnt);
>>> + qtest_add_func("fuzz/test_lp1878642_pci_bus_get_irq_level_assert",
>>> + test_lp1878642_pci_bus_get_irq_level_assert);
>>> }
>>>
>>> return g_test_run();
>>>
>>
>> Queued, thanks.
>
> Great, did you queued the fix too?
> (https://www.mail-archive.com/qemu-devel@nongnu.org/msg725783.html)
Ah I see it has been merged in time for rc1 (commit 4177b062fc58d),
thanks. IIRC few months ago there was a bot responding to patches
"your patch has been merged", was it patchew? Maybe we can a job
to do that on GitLab, but the problem is to expose SMTP credentials
in a runner.
>
> Regards,
>
> Phil.
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] qtest: add a reproducer for LP#1878642
2020-11-02 16:33 [PATCH] qtest: add a reproducer for LP#1878642 Alexander Bulekov
2020-11-02 18:23 ` Paolo Bonzini
@ 2021-02-16 13:25 ` Peter Maydell
2021-02-16 15:00 ` Alexander Bulekov
1 sibling, 1 reply; 8+ messages in thread
From: Peter Maydell @ 2021-02-16 13:25 UTC (permalink / raw)
To: Alexander Bulekov
Cc: Laurent Vivier, Paolo Bonzini, Thomas Huth, QEMU Developers,
Philippe Mathieu-Daudé
On Mon, 2 Nov 2020 at 16:35, Alexander Bulekov <alxndr@bu.edu> wrote:
>
> https://bugs.launchpad.net/qemu/+bug/1878642
>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> ---
>
> Based-on: <20200717151705.18611-1-f4bug@amsat.org>
>
> The added testcase will fail, unless this ^^^ patch is applied.
>
> tests/qtest/fuzz-test.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/tests/qtest/fuzz-test.c b/tests/qtest/fuzz-test.c
> index 2f38bb1ec2..9cb4c42bde 100644
> --- a/tests/qtest/fuzz-test.c
> +++ b/tests/qtest/fuzz-test.c
> @@ -34,6 +34,19 @@ static void test_lp1878263_megasas_zero_iov_cnt(void)
> qtest_quit(s);
> }
>
> +static void test_lp1878642_pci_bus_get_irq_level_assert(void)
> +{
> + QTestState *s;
> +
> + s = qtest_init("-M pc-q35-5.0 "
> + "-nographic -monitor none -serial none "
> + "-d guest_errors -trace pci*");
> +
> + qtest_outl(s, 0xcf8, 0x8400f841);
> + qtest_outl(s, 0xcfc, 0xebed205d);
> + qtest_outl(s, 0x5d02, 0xebed205d);
> +}
Hi; I just noticed this, but why does this test case pass
"-trace pci*" to QEMU? It doesn't look like it does anything to
try to capture the trace output, which thus winds up just going
to the stdout/stderr of the "make check" run. Similarly I'm not
sure '-d guest_errors' is going to do anything helpful unless
you take steps to capture the output and check it.
thanks
-- PMM
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] qtest: add a reproducer for LP#1878642
2021-02-16 13:25 ` Peter Maydell
@ 2021-02-16 15:00 ` Alexander Bulekov
2021-02-16 17:31 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 8+ messages in thread
From: Alexander Bulekov @ 2021-02-16 15:00 UTC (permalink / raw)
To: Peter Maydell
Cc: Laurent Vivier, Paolo Bonzini, Thomas Huth, QEMU Developers,
Philippe Mathieu-Daudé
On 210216 1325, Peter Maydell wrote:
> On Mon, 2 Nov 2020 at 16:35, Alexander Bulekov <alxndr@bu.edu> wrote:
> >
> > https://bugs.launchpad.net/qemu/+bug/1878642
> >
> > Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> > Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> > ---
> >
> > Based-on: <20200717151705.18611-1-f4bug@amsat.org>
> >
> > The added testcase will fail, unless this ^^^ patch is applied.
> >
> > tests/qtest/fuzz-test.c | 15 +++++++++++++++
> > 1 file changed, 15 insertions(+)
> >
> > diff --git a/tests/qtest/fuzz-test.c b/tests/qtest/fuzz-test.c
> > index 2f38bb1ec2..9cb4c42bde 100644
> > --- a/tests/qtest/fuzz-test.c
> > +++ b/tests/qtest/fuzz-test.c
> > @@ -34,6 +34,19 @@ static void test_lp1878263_megasas_zero_iov_cnt(void)
> > qtest_quit(s);
> > }
> >
> > +static void test_lp1878642_pci_bus_get_irq_level_assert(void)
> > +{
> > + QTestState *s;
> > +
> > + s = qtest_init("-M pc-q35-5.0 "
> > + "-nographic -monitor none -serial none "
> > + "-d guest_errors -trace pci*");
> > +
> > + qtest_outl(s, 0xcf8, 0x8400f841);
> > + qtest_outl(s, 0xcfc, 0xebed205d);
> > + qtest_outl(s, 0x5d02, 0xebed205d);
> > +}
>
> Hi; I just noticed this, but why does this test case pass
> "-trace pci*" to QEMU? It doesn't look like it does anything to
> try to capture the trace output, which thus winds up just going
> to the stdout/stderr of the "make check" run. Similarly I'm not
> sure '-d guest_errors' is going to do anything helpful unless
> you take steps to capture the output and check it.
>
Ah, I sometimes include those in the initial report, if the device has
trace-events. I can remove this from fuzz-test.c, if it is slowing
things down.
-Alex
> thanks
> -- PMM
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] qtest: add a reproducer for LP#1878642
2021-02-16 15:00 ` Alexander Bulekov
@ 2021-02-16 17:31 ` Philippe Mathieu-Daudé
2021-02-16 17:48 ` Peter Maydell
0 siblings, 1 reply; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-02-16 17:31 UTC (permalink / raw)
To: Alexander Bulekov, Peter Maydell
Cc: Laurent Vivier, Paolo Bonzini, Thomas Huth, QEMU Developers
On 2/16/21 4:00 PM, Alexander Bulekov wrote:
> On 210216 1325, Peter Maydell wrote:
>> On Mon, 2 Nov 2020 at 16:35, Alexander Bulekov <alxndr@bu.edu> wrote:
>>>
>>> https://bugs.launchpad.net/qemu/+bug/1878642
>>>
>>> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
>>> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
>>> ---
>>>
>>> Based-on: <20200717151705.18611-1-f4bug@amsat.org>
>>>
>>> The added testcase will fail, unless this ^^^ patch is applied.
>>>
>>> tests/qtest/fuzz-test.c | 15 +++++++++++++++
>>> 1 file changed, 15 insertions(+)
>>>
>>> diff --git a/tests/qtest/fuzz-test.c b/tests/qtest/fuzz-test.c
>>> index 2f38bb1ec2..9cb4c42bde 100644
>>> --- a/tests/qtest/fuzz-test.c
>>> +++ b/tests/qtest/fuzz-test.c
>>> @@ -34,6 +34,19 @@ static void test_lp1878263_megasas_zero_iov_cnt(void)
>>> qtest_quit(s);
>>> }
>>>
>>> +static void test_lp1878642_pci_bus_get_irq_level_assert(void)
>>> +{
>>> + QTestState *s;
>>> +
>>> + s = qtest_init("-M pc-q35-5.0 "
>>> + "-nographic -monitor none -serial none "
>>> + "-d guest_errors -trace pci*");
>>> +
>>> + qtest_outl(s, 0xcf8, 0x8400f841);
>>> + qtest_outl(s, 0xcfc, 0xebed205d);
>>> + qtest_outl(s, 0x5d02, 0xebed205d);
>>> +}
>>
>> Hi; I just noticed this, but why does this test case pass
>> "-trace pci*" to QEMU? It doesn't look like it does anything to
>> try to capture the trace output, which thus winds up just going
>> to the stdout/stderr of the "make check" run. Similarly I'm not
>> sure '-d guest_errors' is going to do anything helpful unless
>> you take steps to capture the output and check it.
I suppose Alex took it from commit 4177b062fc5 ("hw/isa/lpc_ich9:
Ignore reserved/invalid SCI IRQ") where it is used to show the
problem the fuzzer reproducer triggers. Not useful in regular testing.
> Ah, I sometimes include those in the initial report, if the device has
> trace-events. I can remove this from fuzz-test.c, if it is slowing
> things down.
I doubt it is slowing things down, but it probably make it harder to
find other problems (I suppose Peter got confused when looking for
another failure and found these traces).
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] qtest: add a reproducer for LP#1878642
2021-02-16 17:31 ` Philippe Mathieu-Daudé
@ 2021-02-16 17:48 ` Peter Maydell
0 siblings, 0 replies; 8+ messages in thread
From: Peter Maydell @ 2021-02-16 17:48 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Laurent Vivier, Alexander Bulekov, Thomas Huth, QEMU Developers,
Paolo Bonzini
On Tue, 16 Feb 2021 at 17:31, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> On 2/16/21 4:00 PM, Alexander Bulekov wrote:
> > On 210216 1325, Peter Maydell wrote:
> >> Hi; I just noticed this, but why does this test case pass
> >> "-trace pci*" to QEMU? It doesn't look like it does anything to
> >> try to capture the trace output, which thus winds up just going
> >> to the stdout/stderr of the "make check" run. Similarly I'm not
> >> sure '-d guest_errors' is going to do anything helpful unless
> >> you take steps to capture the output and check it.
>
> I suppose Alex took it from commit 4177b062fc5 ("hw/isa/lpc_ich9:
> Ignore reserved/invalid SCI IRQ") where it is used to show the
> problem the fuzzer reproducer triggers. Not useful in regular testing.
>
> > Ah, I sometimes include those in the initial report, if the device has
> > trace-events. I can remove this from fuzz-test.c, if it is slowing
> > things down.
>
> I doubt it is slowing things down, but it probably make it harder to
> find other problems (I suppose Peter got confused when looking for
> another failure and found these traces).
Not even that; it just looks a bit weird in the 'make check'
output. If there's no particular reason for them to be in there
we might as well remove them.
-- PMM
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-02-16 17:50 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-02 16:33 [PATCH] qtest: add a reproducer for LP#1878642 Alexander Bulekov
2020-11-02 18:23 ` Paolo Bonzini
2020-11-02 18:58 ` Philippe Mathieu-Daudé
2020-11-09 14:37 ` Philippe Mathieu-Daudé
2021-02-16 13:25 ` Peter Maydell
2021-02-16 15:00 ` Alexander Bulekov
2021-02-16 17:31 ` Philippe Mathieu-Daudé
2021-02-16 17:48 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.