All of lore.kernel.org
 help / color / mirror / Atom feed
From: Antti Palosaari <crope@iki.fi>
To: Akihiro TSUKADA <tskd08@gmail.com>, linux-media@vger.kernel.org
Cc: mchehab@s-opensource.com
Subject: Re: [PATCH v4] dvb-usb/friio, dvb-usb-v2/gl861: decompose friio and merge with gl861
Date: Fri, 30 Mar 2018 20:59:44 +0300	[thread overview]
Message-ID: <25d4e91f-454f-bac7-125b-dd1ae5c77d9e@iki.fi> (raw)
In-Reply-To: <30d0270b-852a-39df-14e5-4c12d59aeac7@gmail.com>



On 03/30/2018 04:21 PM, Akihiro TSUKADA wrote:
>> I simply cannot see why it cannot work. Just add i2c adapter and
>> suitable logic there. Transaction on your example is simply and there is
>> no problem to implement that kind of logic to demod i2c adapter.
> 
> I might be totally wrong, but...
> 
> i2c transactions to a tuner must use:
> 1. usb_control_msg(request:3) for the first half (write) of reads
> 2. usb_control_msg(request:1) for the other writes
> 3. usb_control_msg(request:2) for (all) reads
> 
> How can the demod driver control the 'request' argument of USB messages
> that are sent to its parent (not to the demod itself),
> when the bridge of tc90522 cannot be limited to gl861 (or even to USB) ?

I don't understand those control message parts and it is bit too hard to 
read i2c adapter implementation to get understanding. Could you offer 
simple 2 sniff examples, register write to demod and register write to 
tuner.

Anyhow, demod i2c adapter gets request from tuner and then does some 
demod specific i2c algo stuff and then pass proper request to usb-bridge 
i2c adapter.

IIR it was somehing like

write_tuner_reg(0xaa, 0xbb);
  ==> demod i2c algo:
  * write_demod_reg(0xfe, 0x60) // set tuner i2c addr + start i2c write
  * write_demod_reg(0xaa, 0xbb)

so those command now goes to i2c-bridge i2c algo which uses gl861 i2c algo


regards
Antti

-- 
http://palosaari.fi/

  reply	other threads:[~2018-03-30 18:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-27 17:47 [PATCH v4] dvb-usb/friio, dvb-usb-v2/gl861: decompose friio and merge with gl861 tskd08
2018-03-27 23:46 ` Antti Palosaari
2018-03-28 12:37   ` Akihiro TSUKADA
2018-03-28 20:44     ` Antti Palosaari
2018-03-30 13:21       ` Akihiro TSUKADA
2018-03-30 17:59         ` Antti Palosaari [this message]
2018-03-31 15:30           ` Akihiro TSUKADA
2018-03-28 16:45 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25d4e91f-454f-bac7-125b-dd1ae5c77d9e@iki.fi \
    --to=crope@iki.fi \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@s-opensource.com \
    --cc=tskd08@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.