From: Finn Thain <fthain@linux-m68k.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Jason Wang <jasowang@redhat.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, Laurent Vivier <laurent@vivier.eu>
Subject: Re: [RFC PATCH 6/6] dp8393x: Rewrite dp8393x_get() / dp8393x_put()
Date: Sun, 4 Jul 2021 11:46:05 +1000 (AEST) [thread overview]
Message-ID: <25db776f-27b-efb7-ba10-c8da65fc92f@linux-m68k.org> (raw)
In-Reply-To: <20210703141947.352295-7-f4bug@amsat.org>
[-- Attachment #1: Type: text/plain, Size: 802 bytes --]
On Sat, 3 Jul 2021, Philippe Mathieu-Daudé wrote:
> Instead of accessing N registers via a single address_space API
> call using a temporary buffer (stored in the device state) and
> updating each register, move the address_space call in the
> register put/get. The load/store and word size checks are moved
> to put/get too. This simplifies a bit, making the code easier
> to read.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
I tried this series with a Linux/m68k guest but network activity hanged
the emulator. The cause of the problem is somewhere in this patch.
BTW, I've become suspicious of the word "rewrite". In this case I think it
describes a commit that is attempting to do too much and needs to be split
up to make it easier to review (and debug).
next prev parent reply other threads:[~2021-07-04 1:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-03 14:19 [RFC PATCH 0/6] dp8393x: Housekeeping Philippe Mathieu-Daudé
2021-07-03 14:19 ` [PATCH 1/6] dp8393x: fix CAM descriptor entry index Philippe Mathieu-Daudé
2021-07-03 14:19 ` [PATCH 2/6] dp8393x: don't force 32-bit register access Philippe Mathieu-Daudé
2021-07-03 14:39 ` Mark Cave-Ayland
2021-07-03 16:29 ` Philippe Mathieu-Daudé
2021-07-04 15:34 ` Mark Cave-Ayland
2021-07-04 2:06 ` Finn Thain
2021-07-03 14:19 ` [RFC PATCH 3/6] dp8393x: Restrict bus access to 16/32-bit operations Philippe Mathieu-Daudé
2021-07-03 14:52 ` Mark Cave-Ayland
2021-07-04 14:45 ` Mark Cave-Ayland
2021-07-03 14:19 ` [RFC PATCH 4/6] dp8393x: Store CAM registers as 16-bit Philippe Mathieu-Daudé
2021-07-03 14:56 ` Mark Cave-Ayland
2021-07-04 14:48 ` Mark Cave-Ayland
2021-07-06 17:29 ` Philippe Mathieu-Daudé
2021-07-06 19:27 ` Mark Cave-Ayland
2021-07-03 14:19 ` [PATCH 5/6] dp8393x: Replace address_space_rw(is_write=1) by address_space_write() Philippe Mathieu-Daudé
2021-07-03 14:57 ` Mark Cave-Ayland
2021-07-04 14:49 ` Mark Cave-Ayland
2021-07-03 14:19 ` [RFC PATCH 6/6] dp8393x: Rewrite dp8393x_get() / dp8393x_put() Philippe Mathieu-Daudé
2021-07-03 15:00 ` Mark Cave-Ayland
2021-07-03 15:04 ` Philippe Mathieu-Daudé
2021-07-04 1:46 ` Finn Thain [this message]
2021-07-04 15:07 ` Mark Cave-Ayland
2021-07-05 1:36 ` Finn Thain
2021-07-05 6:34 ` Mark Cave-Ayland
2021-07-07 1:30 ` Finn Thain
2021-07-07 10:12 ` Mark Cave-Ayland
2021-07-09 9:13 ` Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25db776f-27b-efb7-ba10-c8da65fc92f@linux-m68k.org \
--to=fthain@linux-m68k.org \
--cc=f4bug@amsat.org \
--cc=jasowang@redhat.com \
--cc=laurent@vivier.eu \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.