From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3BE7C4360C for ; Tue, 8 Oct 2019 09:59:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8885A206C2 for ; Tue, 8 Oct 2019 09:59:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8885A206C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53218 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHmHZ-0001Ls-5L for qemu-devel@archiver.kernel.org; Tue, 08 Oct 2019 05:59:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39588) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHmFM-0007yW-RO for qemu-devel@nongnu.org; Tue, 08 Oct 2019 05:57:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHmFL-0006Pp-5G for qemu-devel@nongnu.org; Tue, 08 Oct 2019 05:57:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57328) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iHmFH-0006N8-Ew; Tue, 08 Oct 2019 05:57:31 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 91476C0546D5; Tue, 8 Oct 2019 09:57:30 +0000 (UTC) Received: from dresden.str.redhat.com (unknown [10.40.205.207]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 615A95C1D4; Tue, 8 Oct 2019 09:57:26 +0000 (UTC) Subject: Re: [PATCH 5/6] block/block-copy: add memory limit To: Vladimir Sementsov-Ogievskiy , "qemu-block@nongnu.org" References: <20191003171539.12327-1-vsementsov@virtuozzo.com> <20191003171539.12327-6-vsementsov@virtuozzo.com> <8aa011d7-3f11-2df5-d77e-5c5176ab63ed@redhat.com> <49b99621-2d8a-f4a8-d31a-e64a727952a9@virtuozzo.com> <8bd41e8a-acfb-8f55-b2d3-ae909dc21ae7@redhat.com> From: Max Reitz Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: <25db8b54-b9cb-e895-d79a-c9e08b12b802@redhat.com> Date: Tue, 8 Oct 2019 11:57:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qiGGMjdXCPvwUahC752osOLXPb2IIWynt" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 08 Oct 2019 09:57:30 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "kwolf@redhat.com" , "jsnow@redhat.com" , "qemu-devel@nongnu.org" , Denis Lunev Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qiGGMjdXCPvwUahC752osOLXPb2IIWynt Content-Type: multipart/mixed; boundary="KbUnMqlOu1C2nVDFxRFzWduKD3bn7Uf7V" --KbUnMqlOu1C2nVDFxRFzWduKD3bn7Uf7V Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 08.10.19 11:20, Vladimir Sementsov-Ogievskiy wrote: > 08.10.2019 12:15, Vladimir Sementsov-Ogievskiy wrote: >> 08.10.2019 12:03, Max Reitz wrote: >>> On 07.10.19 19:10, Vladimir Sementsov-Ogievskiy wrote: >>>> 07.10.2019 18:27, Max Reitz wrote: >>>>> On 03.10.19 19:15, Vladimir Sementsov-Ogievskiy wrote: >>>>>> Currently total allocation for parallel requests to block-copy ins= tance >>>>>> is unlimited. Let's limit it to 128 MiB. >>>>>> >>>>>> For now block-copy is used only in backup, so actually we limit to= tal >>>>>> allocation for backup job. >>>>>> >>>>>> Signed-off-by: Vladimir Sementsov-Ogievskiy >>>>>> --- >>>>>> =C2=A0=C2=A0 include/block/block-copy.h | 3 +++ >>>>>> =C2=A0=C2=A0 block/block-copy.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 | 5 +++++ >>>>>> =C2=A0=C2=A0 2 files changed, 8 insertions(+) >>>>>> >>>>>> diff --git a/include/block/block-copy.h b/include/block/block-copy= =2Eh >>>>>> index e2e135ff1b..bb666e7068 100644 >>>>>> --- a/include/block/block-copy.h >>>>>> +++ b/include/block/block-copy.h >>>>>> @@ -16,6 +16,7 @@ >>>>>> =C2=A0=C2=A0 #define BLOCK_COPY_H >>>>>> =C2=A0=C2=A0 #include "block/block.h" >>>>>> +#include "qemu/co-shared-amount.h" >>>>>> =C2=A0=C2=A0 typedef struct BlockCopyInFlightReq { >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int64_t start_byte; >>>>>> @@ -69,6 +70,8 @@ typedef struct BlockCopyState { >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */ >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ProgressResetCallbackFunc pro= gress_reset_callback; >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 void *progress_opaque; >>>>>> + >>>>>> +=C2=A0=C2=A0=C2=A0 QemuCoSharedAmount *mem; >>>>>> =C2=A0=C2=A0 } BlockCopyState; >>>>>> =C2=A0=C2=A0 BlockCopyState *block_copy_state_new(BdrvChild *sourc= e, BdrvChild *target, >>>>>> diff --git a/block/block-copy.c b/block/block-copy.c >>>>>> index cc49d2345d..e700c20d0f 100644 >>>>>> --- a/block/block-copy.c >>>>>> +++ b/block/block-copy.c >>>>>> @@ -21,6 +21,7 @@ >>>>>> =C2=A0=C2=A0 #include "qemu/units.h" >>>>>> =C2=A0=C2=A0 #define BLOCK_COPY_MAX_COPY_RANGE (16 * MiB) >>>>>> +#define BLOCK_COPY_MAX_MEM (128 * MiB) >>>>>> =C2=A0=C2=A0 static void coroutine_fn block_copy_wait_inflight_req= s(BlockCopyState *s, >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int64_t start, >>>>>> @@ -64,6 +65,7 @@ void block_copy_state_free(BlockCopyState *s) >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bdrv_release_dirty_bitmap(s->= source->bs, s->copy_bitmap); >>>>>> +=C2=A0=C2=A0=C2=A0 qemu_co_shared_amount_free(s->mem); >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 g_free(s); >>>>>> =C2=A0=C2=A0 } >>>>>> @@ -95,6 +97,7 @@ BlockCopyState *block_copy_state_new(BdrvChild *= source, BdrvChild *target, >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .clus= ter_size =3D cluster_size, >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .len = =3D bdrv_dirty_bitmap_size(copy_bitmap), >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .writ= e_flags =3D write_flags, >>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .mem =3D qemu_co_share= d_amount_new(BLOCK_COPY_MAX_MEM), >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }; >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 s->copy_range_size =3D QEMU_A= LIGN_DOWN(max_transfer, cluster_size), >>>>>> @@ -316,7 +319,9 @@ int coroutine_fn block_copy(BlockCopyState *s,= >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bdrv_= reset_dirty_bitmap(s->copy_bitmap, start, chunk_end - start); >>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 qemu_co_get_amount(s->= mem, chunk_end - start); >>>>> >>>>> Now that I see it like this, maybe the name is too short.=C2=A0 Thi= s sounds >>>>> like it was trying to get some amount of coroutines. >>>>> >>>>> Would =E2=80=9Cqemu_co_get_from_shared_amount=E2=80=9D be too long?= =C2=A0 (Something like >>>>> qemu_co_sham_alloc() would be funny, but maybe not.=C2=A0 :-)=C2=A0= Or maybe >>>>> exactly because it=E2=80=9Ds funny.) >>>>> >>>> >>>> hmm sham may be interpreted as shared memory, not only like shame.. >>> >>> =E2=80=9Csham=E2=80=9D is also a word by itself. :-) >> >> Hmm didn't know, me go to google translate. OK, sham looks a lot nicer= than shame) >> >>> >>>> And if we call it _alloc, the opposite should be _free, but how to >>>> distinguish it from freeing the whole object? Hmm, use create/destro= y for >>>> the whole object maybe. >>>> >>>> May be, drop "qemu_" ? It's not very informative. Or may be drop "co= _"?. >>>> >>>> I don't like shaming my shared amount :) >>> >>> It=E2=80=99s worse calling it all a sham. >>> >>>> May be, we should imagine, what are we allocating? May be balls? >>>> >>>> struct BallAllocator >>>> >>>> ball_allocator_create >>>> ball_allocator_destroy >>>> >>>> co_try_alloc_balls >>>> co_alloc_balls >>>> co_free_balls >>>> >>>> Or bars? Or which thing may be used for funny naming and to not inte= rsect >>>> with existing concepts like memory? >>> >>> I love it (thanks for making my morning), but I fear it may be >>> interpreted as risqu=C3=A9. >>> >>> Maybe just shres for shared resource?=C2=A0 So alloc_from_shres? >>> >> >> OK for me. But.. How to name _free function than? >> >> struct SharedResource >> >> shres_create >> shres_destroy >> >> co_try_alloc_from_shres >> co_alloc_from_shres >> co_free_??? >> >> co_free_res_alloced_from_shres ? :) >> >> or >> >> co_try_get_from_shres >> co_get_from_shres >> co_put_to_shres >> >=20 >=20 > Another proposal from Roma: use "budget" word. Instead of shres? Why not. Max --KbUnMqlOu1C2nVDFxRFzWduKD3bn7Uf7V-- --qiGGMjdXCPvwUahC752osOLXPb2IIWynt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl2cXYQACgkQ9AfbAGHV z0Czmgf/UZgH2Rwhe02iJJaPVOJIMMvLy4VqWqffqwNwuU2wcP0ZU6iouIfJHpdO ruTJkwNprWcA71Ypb1DXcBKe/6kkRHF5Oz2Pxi+L/KjUrS/dBktE17cDhHvaLiqo 3TClEMcuw/GOuD3+mr2EuvUtFZoQ1mwjY5Ms7U5aQQZ/2vbGJqdXeLRJEyiOrXCD vZh9YriIs1YhxCDMRm6OnEi973oazzQAI8GPZF+Ska8tveir3fMmAD6nb74PYoDt zjtEkAz7+ty3uZ8pIkypdeP/py6xwU9PgZ1B8W++D9RvMV2T7fsJ2yWYeiZU+RC0 KeLztcJs5TgwNyiOFTEV3gqb69NUew== =KEK5 -----END PGP SIGNATURE----- --qiGGMjdXCPvwUahC752osOLXPb2IIWynt--