From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6B34C433E1 for ; Wed, 1 Jul 2020 09:40:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A2FDD206BE for ; Wed, 1 Jul 2020 09:40:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729392AbgGAJko (ORCPT ); Wed, 1 Jul 2020 05:40:44 -0400 Received: from mail.loongson.cn ([114.242.206.163]:34516 "EHLO loongson.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729267AbgGAJkn (ORCPT ); Wed, 1 Jul 2020 05:40:43 -0400 Received: from [10.130.0.52] (unknown [113.200.148.30]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9DxT2gQWvxeT6FNAA--.1580S3; Wed, 01 Jul 2020 17:40:32 +0800 (CST) Subject: Re: [PATCH v4 11/14] irqchip/omap-intc: Fix potential resource leak To: Markus Elfring , Thomas Gleixner , Jason Cooper , Marc Zyngier , Tony Lindgren , linux-omap@vger.kernel.org References: <1593569786-11500-1-git-send-email-yangtiezhu@loongson.cn> <1593569786-11500-12-git-send-email-yangtiezhu@loongson.cn> Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org From: Tiezhu Yang Message-ID: <25e52567-bda4-e936-f04b-8126eb849520@loongson.cn> Date: Wed, 1 Jul 2020 17:40:32 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID: AQAAf9DxT2gQWvxeT6FNAA--.1580S3 X-Coremail-Antispam: 1UD129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUYs7k0a2IF6FyUM7kC6x804xWl14x267AK xVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wAFIxvE14AKwVWUJVWUGw A2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26ryj 6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j6r4UJwA2z4x0Y4vEx4A2jsIE14v26F 4UJVW0owA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAa Y2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_JrI_JrylYx0Ex4 A2jsIE14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI 62AI1cAE67vIY487MxkIecxEwVAFwVW8uwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7x kEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E 67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCw CI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6Fyj6rWU JwCI42IY6I8E87Iv67AKxVW8JVWxJwCI42IY6I8E87Iv6xkF7I0E14v26r4UJVWxJrUvcS sGvfC2KfnxnUUI43ZEXa7IU8Ntx3UUUUU== X-CM-SenderInfo: p1dqw3xlh2x3gn0dqz5rrqw2lrqou0/ Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/01/2020 05:14 PM, Markus Elfring wrote: >> In the function omap_init_irq_of(), system resource "omap_irq_base" >> was not released in the error case, fix it. > Another small wording adjustment: > … in an error case. Thus add a call of the function “iounmap” > in the if branch. OK, thank you, I will do it in v5 of this patch #11 and next patch #12. > > Regards, > Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tiezhu Yang Date: Wed, 01 Jul 2020 09:40:32 +0000 Subject: Re: [PATCH v4 11/14] irqchip/omap-intc: Fix potential resource leak Message-Id: <25e52567-bda4-e936-f04b-8126eb849520@loongson.cn> List-Id: References: <1593569786-11500-1-git-send-email-yangtiezhu@loongson.cn> <1593569786-11500-12-git-send-email-yangtiezhu@loongson.cn> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Markus Elfring , Thomas Gleixner , Jason Cooper , Marc Zyngier , Tony Lindgren , linux-omap@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On 07/01/2020 05:14 PM, Markus Elfring wrote: >> In the function omap_init_irq_of(), system resource "omap_irq_base" >> was not released in the error case, fix it. > Another small wording adjustment: > … in an error case. Thus add a call of the function “iounmap” > in the if branch. OK, thank you, I will do it in v5 of this patch #11 and next patch #12. > > Regards, > Markus