From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jae.hyun.yoo@linux.intel.com>
Authentication-Results: lists.ozlabs.org;
 spf=none (mailfrom) smtp.mailfrom=linux.intel.com
 (client-ip=134.134.136.24; helo=mga09.intel.com;
 envelope-from=jae.hyun.yoo@linux.intel.com; receiver=<UNKNOWN>)
Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none)
 header.from=linux.intel.com
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.ozlabs.org (Postfix) with ESMTPS id 437qN620Q4zDqMG
 for <openbmc@lists.ozlabs.org>; Tue,  4 Dec 2018 02:54:17 +1100 (AEDT)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 03 Dec 2018 07:54:15 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.56,311,1539673200"; d="scan'208";a="115542174"
Received: from yoojae-mobl1.amr.corp.intel.com (HELO [10.122.128.138])
 ([10.122.128.138])
 by orsmga001.jf.intel.com with ESMTP; 03 Dec 2018 07:54:14 -0800
Subject: Re: [HELP] ipmi-kcs didn't work
To: Samuel Jiang <chyishian.jiang@gmail.com>,
 Vijay Khemka <vijaykhemka@fb.com>, qianlihu <wangzhiqiang8906@gmail.com>,
 Gary Hsu <gary_hsu@aspeedtech.com>,
 "Ryan Chen <Ryan Chen" <ryan_chen@aspeedtech.com>
Cc: "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
References: <CAHkHK08zcycaqmg_Pkq=Oe+8xC8TBYsCoBGLA0CCwH0qvwicWg@mail.gmail.com>
 <3022407b-fa4e-9e80-2044-69dbf4f03586@linux.intel.com>
 <CAHkHK09Km5BVLdq7OMSwTLi05-KgDc8K8j9_+e1ewtGanyr4Tg@mail.gmail.com>
 <47558ef0-d8e9-de42-e1dd-be7293048a91@linux.intel.com>
 <A5419381-84F9-490A-8BF0-70C513741ECF@fb.com>
 <e63c758f-2eec-9e28-9381-4e28d2d8bb64@linux.intel.com>
 <4780f022-1c80-4b53-9eb1-0e3fe313c6a2@Spark>
 <db5cfcea-972d-2f50-05f4-266ab2c8f310@linux.intel.com>
 <87C3DCC8-F773-46A0-B8EC-5E3DC5E3983F@fb.com>
 <660c304f-60eb-f54a-f3b7-4d6d4481a96a@linux.intel.com>
 <A9318AC7-EE0E-4B84-84D1-A16695EE3FC0@fb.com>
 <b20d590b-be35-046e-26c2-2c1b2456309a@linux.intel.com>
 <253b7d32-1230-4111-a6dc-a84afddcc679@Spark>
From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Message-ID: <25e866d4-749c-902b-86b2-3d38975dcc65@linux.intel.com>
Date: Mon, 3 Dec 2018 09:54:13 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <253b7d32-1230-4111-a6dc-a84afddcc679@Spark>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-BeenThere: openbmc@lists.ozlabs.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Development list for OpenBMC <openbmc.lists.ozlabs.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/openbmc>,
 <mailto:openbmc-request@lists.ozlabs.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/openbmc/>
List-Post: <mailto:openbmc@lists.ozlabs.org>
List-Help: <mailto:openbmc-request@lists.ozlabs.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/openbmc>,
 <mailto:openbmc-request@lists.ozlabs.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Dec 2018 15:55:51 -0000

On 12/1/2018 8:29 AM, Samuel Jiang wrote:
> Apologize for sending out no content mail first.
> 
> Jae,
> The aspeed_gates in clk-aspeed.c perhaps as todo suggest asking Aspeed 
> the actual parent data for check initializing?
> 

Yes, that makes sense.

Hi Gary and Ryan,

Can you please tell us what is the actual parent clock source of LPC IP?
I mean the operational clock of LPC IP hardware block, not the interface
clock.

Thanks,
Jae

> Vijay,
> I traced lpc-ctrl module, it seems direct update the same 
> ASPEED_CLK_GATE_LCLK register map bit to enable. If parent data is 
> disabled, it could enable in dts.
> The device tree detail, I reference it from aspeed-g5.dtsi. Hope it 
> could help you for work.
> 
> Thanks,
> 
> Samuel Jiang
> On Dec 1, 2018, 7:04 AM +0800, Jae Hyun Yoo , wrote:
>> On 11/30/2018 4:39 PM, Vijay Khemka wrote:
>>>
>>>
>>> On 11/30/18, 11:29 AM, "Jae Hyun Yoo" <jae.hyun.yoo@linux.intel.com> 
>>> wrote:
>>>
>>> On 11/30/2018 12:57 PM, Vijay Khemka wrote:
>>>>
>>>> On 11/30/18, 7:31 AM, "Jae Hyun Yoo" <jae.hyun.yoo@linux.intel.com> 
>>>> wrote:
>>>>
>>>> On 11/29/2018 9:00 PM, Samuel Jiang wrote:
>>>>> Hi Jae,
>>>>>
>>>>> We also encountered the same situation a month ago.
>>>>> We try to enable the LPC clock on devicetree to resolve this 
>>>>> problem not
>>>>> direct modify clock driver.
>>>>>
>>>>> lpc_ctrl: lpc-ctrl@0 {
>>>>>   compatible = "aspeed,ast2500-lpc-ctrl”;
>>>>>   reg = <0x0 0x80>;
>>>>>   clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
>>>>> status = “okay”;
>>>>> };
>>>>>
>>>>> However, I’m not sure which is better for LPC_CLCK setting.
>>>>> Whether we should modify driver if original data is enabled or should
>>>>> enable on the device tree, correct?
>>>>>
>>>>>
>>>>
>>>> Hi Samuel,
>>>>
>>>> Yes, you are right. I realized that kcs_bmc_aspeed.c doesn't have any
>>>> clock control code so adding a clocks setting into kcs dtsi code doesn't
>>>> make any help. Also, it was the reason why the change is needed on
>>>> clk-aspeed.c. Enabling lpc_ctrl node you suggested seems a right way.
>>>>
>>>> Hi Vijay,
>>>> Can you please try the way Samuel suggested after removing changes I
>>>> gave you. Samuel's solution looks good to me.
>>>>
>>>> Thanks,
>>>> Jae
>>>>
>>>> Jae,
>>>> I can try. We can certainly enable lpc_ctrl node but in my 
>>>> understanding that
>>>> we still need this below patch to redefine ASPEED_CLK_GATE_LCLK value to
>>>> add CRITICAL. I might be missing something here.
>>>> - [ASPEED_CLK_GATE_LCLK] = { 8, 5, "lclk-gate", NULL, 0 }, /* LPC */
>>>> + [ASPEED_CLK_GATE_LCLK] = { 8, 5, "lclk-gate", NULL, 
>>>> CLK_IS_CRITICAL }, /* LPC */
>>>>
>>>
>>> Vijay,
>>>
>>> I checked that lpc_ctrl module has clocks dt property handling code in
>>> the module so I think the LCLK would be enabled without the clk-aspeed.c
>>> fix. I can't test it now because I'm in a business trip so please test
>>> it. I'll also check it when I back to office a week after.
>>>
>>> Thanks,
>>> Jae
>>>
>>> Jae,
>>> I removed above aspeed clock driver patch, and enabled lpc-ctrl node 
>>> in dts also removed clock definition from kcs. And I don't see host 
>>> is getting powered on. It works only with clock driver change.
>>>
>>> And I still didn't understand how enabling lpc-ctrl node will 
>>> initialize ASPEED_CLK_GATE_LCLK to CRITICAL.
>>>
>>> -Vijay
>>>
>>
>> Vijay,
>>
>> Thanks Vijay for sharing the test result. I'll also check it on my
>> hardware when I get back to office. Will share my test result too.
>>
>> Thanks again,
>> Jae