All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Muckle <smuckle@google.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH DRAFT] syscalls/stime: convert to new lib, use direct syscall
Date: Tue, 12 Mar 2019 10:51:36 -0700	[thread overview]
Message-ID: <25ed5f17-df8a-c7f3-1b75-e301dc9a7f12@google.com> (raw)
In-Reply-To: <5C80B40C.7070106@cn.fujitsu.com>

Hi Xiao,

On 03/06/2019 10:02 PM, Xiao Yang wrote:
> Hi Cyril, Steve
> 
> According to the source code of glibc, glibc implements stime() by
> __NR_settimeofday
> instead of __NR_stime, and some arches(e.g. x86_64) don't define
> __NR_stime directly.
> Therefore these updated tests will be skipped on some arches that don't
> define __NR_stime.
> 
> If glibc implements stime(), should we use it diectly?  If not, should
> we use __NR_stime or __NR_settimeofday?

I think both should be tested. Once Cyril's test multiplex addition goes 
into the test lib there probably needs to be an effort to revisit cases 
like these.

cheers,
Steve

      reply	other threads:[~2019-03-12 17:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-02  1:59 [LTP] [PATCH DRAFT] syscalls/stime: convert to new lib, use direct syscall Steve Muckle
2019-03-01 14:48 ` Cyril Hrubis
2019-03-07  6:02   ` Xiao Yang
2019-03-12 17:51     ` Steve Muckle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25ed5f17-df8a-c7f3-1b75-e301dc9a7f12@google.com \
    --to=smuckle@google.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.