From: "Christian König" <deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
To: Rex Zhu <Rex.Zhu-5C7GfCeVMHo@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH 1/3] drm/amdgpu: delete duplicated printk info.
Date: Thu, 30 Mar 2017 10:40:27 +0200 [thread overview]
Message-ID: <25f099d1-4627-e86c-ddd1-5b8e18f9eb7e@vodafone.de> (raw)
In-Reply-To: <1490852538-13276-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org>
Patch 1 and 2 are Reviewed-by: Christian König <christian.koenig@amd.com>.
Patch 3 is a clear NAK. The ring test is there to make sure that the
hardware is working as expected before proceeding.
If it fails randomly with KIQ enabled we need to figure out why and not
just disable the test.
Christian.
Am 30.03.2017 um 07:42 schrieb Rex Zhu:
> Change-Id: I5f336cc41b1868b98f263874fe5c6ea20e430744
> Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 57ccac4..eaf44fb 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -2288,9 +2288,6 @@ int amdgpu_device_resume(struct drm_device *dev, bool resume, bool fbcon)
> if (r)
> DRM_ERROR("amdgpu_resume failed (%d).\n", r);
>
> - if (r)
> - DRM_ERROR("amdgpu_resume failed (%d).\n", r);
> -
> amdgpu_fence_driver_resume(adev);
>
> if (resume) {
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2017-03-30 8:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 5:42 [PATCH 1/3] drm/amdgpu: delete duplicated printk info Rex Zhu
[not found] ` <1490852538-13276-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org>
2017-03-30 5:42 ` [PATCH 2/3] drm/amdgpu: when resume failed, return error to avoid system hang Rex Zhu
2017-03-30 5:42 ` [PATCH 3/3] drm/amdgpu: do not block gpu resume when cp ring test failed Rex Zhu
[not found] ` <1490852538-13276-3-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org>
2017-03-30 6:14 ` Michel Dänzer
2017-03-30 6:43 ` [PATCH 1/3] drm/amdgpu: delete duplicated printk info Michel Dänzer
2017-03-30 8:40 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25f099d1-4627-e86c-ddd1-5b8e18f9eb7e@vodafone.de \
--to=deathsimple-antagkrnahcb1svskn2v4q@public.gmane.org \
--cc=Rex.Zhu-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.