From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEB3CC433F5 for ; Mon, 25 Apr 2022 09:21:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235136AbiDYJYY convert rfc822-to-8bit (ORCPT ); Mon, 25 Apr 2022 05:24:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232645AbiDYJYU (ORCPT ); Mon, 25 Apr 2022 05:24:20 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C44EE114D for ; Mon, 25 Apr 2022 02:21:15 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1niutp-0003uW-GT; Mon, 25 Apr 2022 11:20:53 +0200 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1niuto-0057Sx-PG; Mon, 25 Apr 2022 11:20:51 +0200 Received: from pza by lupine with local (Exim 4.94.2) (envelope-from ) id 1niutm-0004WV-OB; Mon, 25 Apr 2022 11:20:50 +0200 Message-ID: <25fbf4763c28af4c73162dec254af6111e05461b.camel@pengutronix.de> Subject: Re: [PATCH v8 2/5] PCI: dwc: rockchip: reset core at driver probe From: Philipp Zabel To: Peter Geis , Lorenzo Pieralisi , Rob Herring , Krzysztof =?UTF-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Heiko Stuebner Cc: linux-rockchip@lists.infradead.org, Marc Zyngier , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Mon, 25 Apr 2022 11:20:50 +0200 In-Reply-To: <20220423152403.1681222-3-pgwipeout@gmail.com> References: <20220423152403.1681222-1-pgwipeout@gmail.com> <20220423152403.1681222-3-pgwipeout@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, On Sa, 2022-04-23 at 11:24 -0400, Peter Geis wrote: > The PCIe controller is in an unknown state at driver probe. This can > lead to undesireable effects when the driver attempts to configure the > controller. > > Prevent issues in the future by resetting the core during probe. > > Signed-off-by: Peter Geis > --- >  drivers/pci/controller/dwc/pcie-dw-rockchip.c | 22 +++++++------------ >  1 file changed, 8 insertions(+), 14 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c > index c9b341e55cbb..d67ed811e752 100644 > --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c > +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c > @@ -152,7 +152,13 @@ static int rockchip_pcie_resource_get(struct platform_device *pdev, >   if (IS_ERR(rockchip->rst_gpio)) >   return PTR_ERR(rockchip->rst_gpio); > > - return 0; > + rockchip->rst = devm_reset_control_array_get_exclusive(&pdev->dev); > + if (IS_ERR(rockchip->rst)) > + return dev_err_probe(&pdev->dev, PTR_ERR(rockchip->rst), > + "failed to get reset lines\n"); > + > + return reset_control_assert(rockchip->rst); This makes "rockchip_pcie_resource_get" a bit of a misnomer, maybe move this out into rockchip_pcie_probe()? > + Superfluous whitespace. regards Philipp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88E27C433F5 for ; Mon, 25 Apr 2022 09:21:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=omZWxkmz6Mu41Ax8Gn9tcSZHbFCj98szma4aT6WD3dc=; b=c58VWU2DVRQDHf 0lwZpt+SB/oaNwhDtGsk7Hq98ByuqYbtM5wbgT++lyo/Gma6M8XZEahV/xMH+WaFpljOFnfOTcdma NilHB4oyvm4UAhTUTYor7JEhawth4OGujjPaIXaHgNxSPDb5FhAOgjOnZzpo6hppgrJrreyX3rBml uG3Ww4iXDcpa/a2LifleL3Of+f7XwEj24PLcfkajcCer+jq4DfPoxmpbygtVbSSRtDJI1dEcArAd3 fo17NyMH1lFm5vprsJTozdB3MHSOG8wapYoqXBjylp4IIi4dXBZj6wfHnalPiDgrD7er5P94re6KE Mrr/cvpttDgO4h5tUpOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1niuuH-008tSB-Hb; Mon, 25 Apr 2022 09:21:21 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1niuu2-008tOQ-VD for linux-rockchip@lists.infradead.org; Mon, 25 Apr 2022 09:21:10 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1niutp-0003uW-GT; Mon, 25 Apr 2022 11:20:53 +0200 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1niuto-0057Sx-PG; Mon, 25 Apr 2022 11:20:51 +0200 Received: from pza by lupine with local (Exim 4.94.2) (envelope-from ) id 1niutm-0004WV-OB; Mon, 25 Apr 2022 11:20:50 +0200 Message-ID: <25fbf4763c28af4c73162dec254af6111e05461b.camel@pengutronix.de> Subject: Re: [PATCH v8 2/5] PCI: dwc: rockchip: reset core at driver probe From: Philipp Zabel To: Peter Geis , Lorenzo Pieralisi , Rob Herring , Krzysztof =?UTF-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Heiko Stuebner Cc: linux-rockchip@lists.infradead.org, Marc Zyngier , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Mon, 25 Apr 2022 11:20:50 +0200 In-Reply-To: <20220423152403.1681222-3-pgwipeout@gmail.com> References: <20220423152403.1681222-1-pgwipeout@gmail.com> <20220423152403.1681222-3-pgwipeout@gmail.com> User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-rockchip@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220425_022107_043679_0D359C66 X-CRM114-Status: GOOD ( 15.68 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgUGV0ZXIsCgpPbiBTYSwgMjAyMi0wNC0yMyBhdCAxMToyNCAtMDQwMCwgUGV0ZXIgR2VpcyB3 cm90ZToKPiBUaGUgUENJZSBjb250cm9sbGVyIGlzIGluIGFuIHVua25vd24gc3RhdGUgYXQgZHJp dmVyIHByb2JlLiBUaGlzIGNhbgo+IGxlYWQgdG8gdW5kZXNpcmVhYmxlIGVmZmVjdHMgd2hlbiB0 aGUgZHJpdmVyIGF0dGVtcHRzIHRvIGNvbmZpZ3VyZSB0aGUKPiBjb250cm9sbGVyLgo+IAo+IFBy ZXZlbnQgaXNzdWVzIGluIHRoZSBmdXR1cmUgYnkgcmVzZXR0aW5nIHRoZSBjb3JlIGR1cmluZyBw cm9iZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBQZXRlciBHZWlzIDxwZ3dpcGVvdXRAZ21haWwuY29t Pgo+IC0tLQo+IMKgZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS1kdy1yb2NrY2hpcC5j IHwgMjIgKysrKysrKy0tLS0tLS0tLS0tLQo+IMKgMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9u cygrKSwgMTQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNpL2NvbnRy b2xsZXIvZHdjL3BjaWUtZHctcm9ja2NoaXAuYyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdj L3BjaWUtZHctcm9ja2NoaXAuYwo+IGluZGV4IGM5YjM0MWU1NWNiYi4uZDY3ZWQ4MTFlNzUyIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtZHctcm9ja2NoaXAu Ywo+ICsrKyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtZHctcm9ja2NoaXAuYwo+ IEBAIC0xNTIsNyArMTUyLDEzIEBAIHN0YXRpYyBpbnQgcm9ja2NoaXBfcGNpZV9yZXNvdXJjZV9n ZXQoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldiwKPiDCoAlpZiAoSVNfRVJSKHJvY2tjaGlw LT5yc3RfZ3BpbykpCj4gwqAJCXJldHVybiBQVFJfRVJSKHJvY2tjaGlwLT5yc3RfZ3Bpbyk7Cj4g Cj4gLQlyZXR1cm4gMDsKPiArCXJvY2tjaGlwLT5yc3QgPSBkZXZtX3Jlc2V0X2NvbnRyb2xfYXJy YXlfZ2V0X2V4Y2x1c2l2ZSgmcGRldi0+ZGV2KTsKPiArCWlmIChJU19FUlIocm9ja2NoaXAtPnJz dCkpCj4gKwkJcmV0dXJuIGRldl9lcnJfcHJvYmUoJnBkZXYtPmRldiwgUFRSX0VSUihyb2NrY2hp cC0+cnN0KSwKPiArCQkJCSAgICAgImZhaWxlZCB0byBnZXQgcmVzZXQgbGluZXNcbiIpOwo+ICsK PiArCXJldHVybiByZXNldF9jb250cm9sX2Fzc2VydChyb2NrY2hpcC0+cnN0KTsKClRoaXMgbWFr ZXMgInJvY2tjaGlwX3BjaWVfcmVzb3VyY2VfZ2V0IiBhIGJpdCBvZiBhIG1pc25vbWVyLCBtYXli ZSBtb3ZlCnRoaXMgb3V0IGludG8gcm9ja2NoaXBfcGNpZV9wcm9iZSgpPwoKPiArCgpTdXBlcmZs dW91cyB3aGl0ZXNwYWNlLgoKcmVnYXJkcwpQaGlsaXBwCgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0Ckxp bnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63D86C433F5 for ; Mon, 25 Apr 2022 09:22:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7OfjXZFv57EAnOkNCsauFOkN4B6O/1XQmpwwNwXWUo4=; b=AySe+w5AWEsJQz mUmfC5KabXqPas6OMySMkfDXR8gDUVSnHVAMClKnrfMMjs8+JeF4iruczLnpEyzS4PVTfsLhcJI4/ 2rDPzk5hTa9qNaLWpUTVN0LORXDiSdcHxaxPBK6Dp4JkIs4Zb3QiAllykz1AxLIcIheSXjy59G6+4 iNIrtXnpWlnl6aDnKLDFl7x7BdDm5zu0V8msiWH0copPDajLvgHqj5BAsxPp7b86FBZlTW6EvjkOH s8nGpEPzIYB1aPUfNcA7S2AtzJsprTybhd1PrZJEA21DZZTbP+3n+naHAWtsTIvGP6X6oqqdcIpr/ xRaC1r/rbtUX7vLPdIRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1niuu8-008tQG-Gd; Mon, 25 Apr 2022 09:21:12 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1niuu2-008tOb-WD for linux-arm-kernel@lists.infradead.org; Mon, 25 Apr 2022 09:21:10 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1niutp-0003uW-GT; Mon, 25 Apr 2022 11:20:53 +0200 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1niuto-0057Sx-PG; Mon, 25 Apr 2022 11:20:51 +0200 Received: from pza by lupine with local (Exim 4.94.2) (envelope-from ) id 1niutm-0004WV-OB; Mon, 25 Apr 2022 11:20:50 +0200 Message-ID: <25fbf4763c28af4c73162dec254af6111e05461b.camel@pengutronix.de> Subject: Re: [PATCH v8 2/5] PCI: dwc: rockchip: reset core at driver probe From: Philipp Zabel To: Peter Geis , Lorenzo Pieralisi , Rob Herring , Krzysztof =?UTF-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Heiko Stuebner Cc: linux-rockchip@lists.infradead.org, Marc Zyngier , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Mon, 25 Apr 2022 11:20:50 +0200 In-Reply-To: <20220423152403.1681222-3-pgwipeout@gmail.com> References: <20220423152403.1681222-1-pgwipeout@gmail.com> <20220423152403.1681222-3-pgwipeout@gmail.com> User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220425_022107_061398_0459312C X-CRM114-Status: GOOD ( 16.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUGV0ZXIsCgpPbiBTYSwgMjAyMi0wNC0yMyBhdCAxMToyNCAtMDQwMCwgUGV0ZXIgR2VpcyB3 cm90ZToKPiBUaGUgUENJZSBjb250cm9sbGVyIGlzIGluIGFuIHVua25vd24gc3RhdGUgYXQgZHJp dmVyIHByb2JlLiBUaGlzIGNhbgo+IGxlYWQgdG8gdW5kZXNpcmVhYmxlIGVmZmVjdHMgd2hlbiB0 aGUgZHJpdmVyIGF0dGVtcHRzIHRvIGNvbmZpZ3VyZSB0aGUKPiBjb250cm9sbGVyLgo+IAo+IFBy ZXZlbnQgaXNzdWVzIGluIHRoZSBmdXR1cmUgYnkgcmVzZXR0aW5nIHRoZSBjb3JlIGR1cmluZyBw cm9iZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBQZXRlciBHZWlzIDxwZ3dpcGVvdXRAZ21haWwuY29t Pgo+IC0tLQo+IMKgZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS1kdy1yb2NrY2hpcC5j IHwgMjIgKysrKysrKy0tLS0tLS0tLS0tLQo+IMKgMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9u cygrKSwgMTQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNpL2NvbnRy b2xsZXIvZHdjL3BjaWUtZHctcm9ja2NoaXAuYyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdj L3BjaWUtZHctcm9ja2NoaXAuYwo+IGluZGV4IGM5YjM0MWU1NWNiYi4uZDY3ZWQ4MTFlNzUyIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtZHctcm9ja2NoaXAu Ywo+ICsrKyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtZHctcm9ja2NoaXAuYwo+ IEBAIC0xNTIsNyArMTUyLDEzIEBAIHN0YXRpYyBpbnQgcm9ja2NoaXBfcGNpZV9yZXNvdXJjZV9n ZXQoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldiwKPiDCoAlpZiAoSVNfRVJSKHJvY2tjaGlw LT5yc3RfZ3BpbykpCj4gwqAJCXJldHVybiBQVFJfRVJSKHJvY2tjaGlwLT5yc3RfZ3Bpbyk7Cj4g Cj4gLQlyZXR1cm4gMDsKPiArCXJvY2tjaGlwLT5yc3QgPSBkZXZtX3Jlc2V0X2NvbnRyb2xfYXJy YXlfZ2V0X2V4Y2x1c2l2ZSgmcGRldi0+ZGV2KTsKPiArCWlmIChJU19FUlIocm9ja2NoaXAtPnJz dCkpCj4gKwkJcmV0dXJuIGRldl9lcnJfcHJvYmUoJnBkZXYtPmRldiwgUFRSX0VSUihyb2NrY2hp cC0+cnN0KSwKPiArCQkJCSAgICAgImZhaWxlZCB0byBnZXQgcmVzZXQgbGluZXNcbiIpOwo+ICsK PiArCXJldHVybiByZXNldF9jb250cm9sX2Fzc2VydChyb2NrY2hpcC0+cnN0KTsKClRoaXMgbWFr ZXMgInJvY2tjaGlwX3BjaWVfcmVzb3VyY2VfZ2V0IiBhIGJpdCBvZiBhIG1pc25vbWVyLCBtYXli ZSBtb3ZlCnRoaXMgb3V0IGludG8gcm9ja2NoaXBfcGNpZV9wcm9iZSgpPwoKPiArCgpTdXBlcmZs dW91cyB3aGl0ZXNwYWNlLgoKcmVnYXJkcwpQaGlsaXBwCgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=