From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Andrew Jones <drjones@redhat.com>,
qemu-devel@nongnu.org, qemu-arm@nongnu.org
Cc: peter.maydell@linaro.org, Miroslav Rezanina <mrezanin@redhat.com>
Subject: Re: [PATCH] hw/arm/virt: ARM_VIRT must select ARM_GIC
Date: Wed, 11 Nov 2020 17:20:25 +0100 [thread overview]
Message-ID: <2601029e-146f-5b94-6aaa-c0d6ec90227d@redhat.com> (raw)
In-Reply-To: <20201111143440.112763-1-drjones@redhat.com>
On 11/11/20 3:34 PM, Andrew Jones wrote:
> The removal of the selection of A15MPCORE from ARM_VIRT also
> removed what A15MPCORE selects, ARM_GIC. We still need ARM_GIC.
>
> Fixes: bec3c97e0cf9 ("hw/arm/virt: Remove dependency on Cortex-A15 MPCore peripherals")
> Reported-by: Miroslav Rezanina <mrezanin@redhat.com>
> Signed-off-by: Andrew Jones <drjones@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/arm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index 7d022eeefdbc..e69a9009cf0a 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -6,6 +6,7 @@ config ARM_VIRT
> imply VFIO_PLATFORM
> imply VFIO_XGMAC
> imply TPM_TIS_SYSBUS
> + select ARM_GIC
> select ACPI
> select ARM_SMMUV3
> select GPIO_KEY
>
next prev parent reply other threads:[~2020-11-11 16:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 14:34 [PATCH] hw/arm/virt: ARM_VIRT must select ARM_GIC Andrew Jones
2020-11-11 15:05 ` Miroslav Rezanina
2020-11-11 16:00 ` Peter Maydell
2020-11-11 17:39 ` Andrew Jones
2020-11-11 18:32 ` Miroslav Rezanina
2020-11-11 16:20 ` Philippe Mathieu-Daudé [this message]
2020-11-12 15:33 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601029e-146f-5b94-6aaa-c0d6ec90227d@redhat.com \
--to=philmd@redhat.com \
--cc=drjones@redhat.com \
--cc=mrezanin@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.