From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ananyev, Konstantin" Subject: Re: [PATCH] example/ipv4_multicast: fix app hanging when using clone Date: Mon, 12 Nov 2018 22:44:41 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258010CE49844@IRSMSX106.ger.corp.intel.com> References: <20181112204650.7175-1-herakliusz.lipiec@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable To: "Lipiec, Herakliusz" , "dev@dpdk.org" Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C7C351D7 for ; Mon, 12 Nov 2018 23:44:44 +0100 (CET) In-Reply-To: <20181112204650.7175-1-herakliusz.lipiec@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Lipiec, Herakliusz > Sent: Monday, November 12, 2018 8:47 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Lipiec, Heraklius= z > Subject: [PATCH] example/ipv4_multicast: fix app hanging when using clone >=20 > This example was dropping packets when using clone (ip 224.0.0.103). > The problem was that mbufs were not freed. This was caused by coping > ol_flags from cloned mbuf to header mbufs. >=20 > Signed-off-by: Herakliusz Lipiec > --- > examples/ipv4_multicast/main.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/examples/ipv4_multicast/main.c b/examples/ipv4_multicast/mai= n.c > index 4073a4907..428ca4694 100644 > --- a/examples/ipv4_multicast/main.c > +++ b/examples/ipv4_multicast/main.c > @@ -266,8 +266,6 @@ mcast_out_pkt(struct rte_mbuf *pkt, int use_clone) > hdr->tx_offload =3D pkt->tx_offload; > hdr->hash =3D pkt->hash; >=20 > - hdr->ol_flags =3D pkt->ol_flags; > - > __rte_mbuf_sanity_check(hdr, 1); > return hdr; > } > -- Acked-by: Konstantin Ananyev > 2.17.1