From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [PATCH v2] example/ipv4_multicast: fix app hanging
 when using clone
Date: Tue, 13 Nov 2018 11:51:39 +0000
Message-ID: <2601191342CEEE43887BDE71AB977258010CE49D0D@IRSMSX106.ger.corp.intel.com>
References: <20181112204650.7175-1-herakliusz.lipiec@intel.com>
 <20181113114929.9269-1-herakliusz.lipiec@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Wang, Dong1" <dong1.wang@intel.com>, "thomas@monjalon.net"
 <thomas@monjalon.net>, "Burakov, Anatoly" <anatoly.burakov@intel.com>,
 "stable@dpdk.org" <stable@dpdk.org>
To: "Lipiec, Herakliusz" <herakliusz.lipiec@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20181113114929.9269-1-herakliusz.lipiec@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


> -----Original Message-----
> From: Lipiec, Herakliusz
> Sent: Tuesday, November 13, 2018 11:49 AM
> To: dev@dpdk.org
> Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Wang, Dong1 <dong=
1.wang@intel.com>; thomas@monjalon.net; Burakov,
> Anatoly <anatoly.burakov@intel.com>; Lipiec, Herakliusz <herakliusz.lipie=
c@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] example/ipv4_multicast: fix app hanging when using cl=
one
>=20
> The ipv4_multicast sample application was dropping packets
> when using mbuf clone. When creating an L2 header and copying
> metadata from the source packet, the ol_flags were also copied
> along with all the other metadata. Because the cloned packet
> had IND_ATTACHED_MBUF flag set in its ol_flags,
> this caused the packets to never be freed when using rte_pktmbuf_free.
> Since copying ol_flags from the cloned packet is
> not necessary in the first place, just don't do it.
>=20
> Fixes: af75078fece3 ("first public release")
> CC: stable@dpdk.org
>=20
> Reported-by: Wang Dong <dong1.wang@intel.com>
> Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
> ---

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>