From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [PATCH] ipsec-secgw: fix AES-CTR block size in
	legacy mode
Date: Wed, 6 Mar 2019 10:08:30 +0000
Message-ID: <2601191342CEEE43887BDE71AB977258012414014A@irsmsx105.ger.corp.intel.com>
References: <20190305144041.88771-1-roy.fan.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>, "stable@dpdk.org"
 <stable@dpdk.org>
To: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20190305144041.88771-1-roy.fan.zhang@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Zhang, Roy Fan
> Sent: Tuesday, March 5, 2019 2:41 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>; Ananye=
v, Konstantin <konstantin.ananyev@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] ipsec-secgw: fix AES-CTR block size in legacy mode
>=20
> This patch fixes the incorrect block size for AES-CTR in
> legacy mode. Originally, wrong block size will cause
> esp_inbound() drop AES-CTR encrypted packets if the payload
> sizes not equal to multiple times of 16.
>=20
> Fixes: 4470c22de2e1 ("examples/ipsec-secgw: add AES-CTR")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>  examples/ipsec-secgw/sa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
> index 414fcd26c..93e3620bc 100644
> --- a/examples/ipsec-secgw/sa.c
> +++ b/examples/ipsec-secgw/sa.c
> @@ -80,7 +80,7 @@ const struct supported_cipher_algo cipher_algos[] =3D {
>  		.keyword =3D "aes-128-ctr",
>  		.algo =3D RTE_CRYPTO_CIPHER_AES_CTR,
>  		.iv_len =3D 8,
> -		.block_size =3D 16, /* XXX AESNI MB limition, should be 4 */
> +		.block_size =3D 4,
>  		.key_len =3D 20
>  	},
>  	{
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> 2.14.5