From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60D55C5B57D for ; Fri, 5 Jul 2019 08:32:12 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id E5A11218A3 for ; Fri, 5 Jul 2019 08:32:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5A11218A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A26F91B9AA; Fri, 5 Jul 2019 10:32:10 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 9F28A1B9A5 for ; Fri, 5 Jul 2019 10:32:08 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jul 2019 01:32:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,454,1557212400"; d="scan'208";a="175441404" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga002.jf.intel.com with ESMTP; 05 Jul 2019 01:31:59 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.164]) by IRSMSX106.ger.corp.intel.com ([169.254.8.234]) with mapi id 14.03.0439.000; Fri, 5 Jul 2019 09:31:58 +0100 From: "Ananyev, Konstantin" To: Thomas Monjalon , Sunil Kumar Kori CC: "dev@dpdk.org" , "jerinj@marvell.com" Thread-Topic: [dpdk-dev] [PATCH v2 1/3] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags Thread-Index: AQHVLGOaO+OSP95COECK7rqLTgYJcaa6qEWAgAEWd8A= Date: Fri, 5 Jul 2019 08:31:58 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772580168A508B7@irsmsx105.ger.corp.intel.com> References: <1558005895-30340-1-git-send-email-skori@marvell.com> <2601191342CEEE43887BDE71AB97725801616357C3@irsmsx105.ger.corp.intel.com> <1761996.Pc4kcPxEft@xps> <1706997.HcbFlGSI5x@xps> In-Reply-To: <1706997.HcbFlGSI5x@xps> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2Q1MWY0MGMtZmUwNi00M2NlLTg3N2MtNDlkYjYxZmZjYTBlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYzBKXC9seXlLQ3RQRDI1OTJLZW5CNTg5czJ0SXBKT3Vra1ozYXYxTnRtdzd4eFQ3eUgzalVxM2dwSFB5enFcLzhLIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/3] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Thursday, July 4, 2019 5:53 PM > To: Sunil Kumar Kori > Cc: dev@dpdk.org; Ananyev, Konstantin ; jer= inj@marvell.com > Subject: Re: [dpdk-dev] [PATCH v2 1/3] lib/librte_ip_frag: Remove PKT_TX_= IP_CKSUM offload flags >=20 > 26/06/2019 23:10, Thomas Monjalon: > > 18/05/2019 17:18, Ananyev, Konstantin: > > > > > > Hi, > > > > > > > Currently PKT_TX_IP_CKSUM is being set into mbuf->ol_flags > > > > during fragmentation and reassemble operation implicitly. > > > > Because of this, application is forced to use checksum offload > > > > whether it is supported by platform or not. > > > > > > > > Also documentation does not provide any expected value of ol_flags > > > > in returned mbuf (reassembled or fragmented) so application will ne= ver > > > > come to know that which offloads are enabled. So transmission may b= e failed > > > > for the platforms which does not support checksum offload. > > > > > > > > Also, IPv6 does not contain any checksum field in header so setting > > > > mbuf->ol_flags with PKT_TX_IP_CKSUM is itself invalid. > > > > > > > > So removing mentioned flag from the library. > > > > > > As there is a change in public API behavior, I think it deserves upda= te in release notes. > > > Apart from that: > > > Acked-by: Konstantin Ananyev > > > > Is it safe to do this behaviour change? > > You did not reply about updating the release notes. > > Why did you drop this patch in v3? >=20 > No reply? > May I consider this series won't go in 19.08 release? I think we better push it into 19.08. It is a real problem, I hit it myself while working on adding reassemble/fr= agmentation support into ipsec-secgw. Sunil, can you prepare new version as asked by Thomas? Konstantin=20