From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ananyev, Konstantin" Subject: Re: [PATCH] examples/vhost: use library routines instead of local copies Date: Thu, 26 Mar 2015 01:20:47 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725821407936@irsmsx105.ger.corp.intel.com> References: <1427309006-26590-1-git-send-email-zoltan.kiss@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable To: Zoltan Kiss , "dev-VfR2kkLFssw@public.gmane.org" Return-path: In-Reply-To: <1427309006-26590-1-git-send-email-zoltan.kiss-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Zoltan Kiss > Sent: Wednesday, March 25, 2015 6:43 PM > To: dev-VfR2kkLFssw@public.gmane.org > Cc: Zoltan Kiss > Subject: [dpdk-dev] [PATCH] examples/vhost: use library routines instead = of local copies >=20 > This macro and function were copies from the mbuf library, no reason to k= eep > them. NACK You can't use RTE_MBUF_INDIRECT macro here. If you'll look at vhost code carefully, you'll realise that we don't use st= andard rte_pktmbuf_attach() here. As we attach mbuf not to another mbuf but to external memory buffer, passed= to us by virtio device. Look at attach_rxmbuf_zcp(). Though I suppose, we can replace pktmbuf_detach_zcp() , with rte_pktmbuf_d= etach() - they are doing identical things. BTW, I wonder did you ever test your patch? My guess it would cause vhost with '--zero-copy' to crash or corrupt the p= ackets straightway.=20 Konstantin >=20 > Signed-off-by: Zoltan Kiss > --- > examples/vhost/main.c | 38 +++++--------------------------------- > 1 file changed, 5 insertions(+), 33 deletions(-) >=20 > diff --git a/examples/vhost/main.c b/examples/vhost/main.c > index c3fcb80..1c998a5 100644 > --- a/examples/vhost/main.c > +++ b/examples/vhost/main.c > @@ -139,8 +139,6 @@ > /* Number of descriptors per cacheline. */ > #define DESC_PER_CACHELINE (RTE_CACHE_LINE_SIZE / sizeof(struct vring_de= sc)) >=20 > -#define MBUF_EXT_MEM(mb) (RTE_MBUF_FROM_BADDR((mb)->buf_addr) !=3D (mb= )) > - > /* mask of enabled ports */ > static uint32_t enabled_port_mask =3D 0; >=20 > @@ -1538,32 +1536,6 @@ attach_rxmbuf_zcp(struct virtio_net *dev) > return; > } >=20 > -/* > - * Detach an attched packet mbuf - > - * - restore original mbuf address and length values. > - * - reset pktmbuf data and data_len to their default values. > - * All other fields of the given packet mbuf will be left intact. > - * > - * @param m > - * The attached packet mbuf. > - */ > -static inline void pktmbuf_detach_zcp(struct rte_mbuf *m) > -{ > - const struct rte_mempool *mp =3D m->pool; > - void *buf =3D RTE_MBUF_TO_BADDR(m); > - uint32_t buf_ofs; > - uint32_t buf_len =3D mp->elt_size - sizeof(*m); > - m->buf_physaddr =3D rte_mempool_virt2phy(mp, m) + sizeof(*m); > - > - m->buf_addr =3D buf; > - m->buf_len =3D (uint16_t)buf_len; > - > - buf_ofs =3D (RTE_PKTMBUF_HEADROOM <=3D m->buf_len) ? > - RTE_PKTMBUF_HEADROOM : m->buf_len; > - m->data_off =3D buf_ofs; > - > - m->data_len =3D 0; > -} >=20 > /* > * This function is called after packets have been transimited. It fetch= s mbuf > @@ -1590,8 +1562,8 @@ txmbuf_clean_zcp(struct virtio_net *dev, struct vpo= ol *vpool) >=20 > for (index =3D 0; index < mbuf_count; index++) { > mbuf =3D __rte_mbuf_raw_alloc(vpool->pool); > - if (likely(MBUF_EXT_MEM(mbuf))) > - pktmbuf_detach_zcp(mbuf); > + if (likely(RTE_MBUF_INDIRECT(mbuf))) > + rte_pktmbuf_detach(mbuf); > rte_ring_sp_enqueue(vpool->ring, mbuf); >=20 > /* Update used index buffer information. */ > @@ -1653,8 +1625,8 @@ static void mbuf_destroy_zcp(struct vpool *vpool) > for (index =3D 0; index < mbuf_count; index++) { > mbuf =3D __rte_mbuf_raw_alloc(vpool->pool); > if (likely(mbuf !=3D NULL)) { > - if (likely(MBUF_EXT_MEM(mbuf))) > - pktmbuf_detach_zcp(mbuf); > + if (likely(RTE_MBUF_INDIRECT(mbuf))) > + rte_pktmbuf_detach(mbuf); > rte_ring_sp_enqueue(vpool->ring, (void *)mbuf); > } > } > @@ -2149,7 +2121,7 @@ switch_worker_zcp(__attribute__((unused)) void *arg= ) > } > while (likely(rx_count)) { > rx_count--; > - pktmbuf_detach_zcp( > + rte_pktmbuf_detach( > pkts_burst[rx_count]); > rte_ring_sp_enqueue( > vpool_array[index].ring, > -- > 1.9.1