From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ananyev, Konstantin" Subject: Re: [PATCH 2/5] mbuf: use the reserved 16 bits for double vlan Date: Tue, 26 May 2015 15:02:51 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725821431C8F@irsmsx105.ger.corp.intel.com> References: <1430793143-3610-1-git-send-email-helin.zhang@intel.com> <1432629400-25303-1-git-send-email-helin.zhang@intel.com> <1432629400-25303-3-git-send-email-helin.zhang@intel.com> <20150526075515.1bc42ae1@urahara> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: Stephen Hemminger , "Zhang, Helin" Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 65952B3D6 for ; Tue, 26 May 2015 17:04:05 +0200 (CEST) In-Reply-To: <20150526075515.1bc42ae1@urahara> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Stephen, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Tuesday, May 26, 2015 3:55 PM > To: Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/5] mbuf: use the reserved 16 bits for do= uble vlan >=20 > On Tue, 26 May 2015 16:36:37 +0800 > Helin Zhang wrote: >=20 > > Use the reserved 16 bits in rte_mbuf structure for the outer vlan, > > also add QinQ offloading flags for both RX and TX sides. > > > > Signed-off-by: Helin Zhang >=20 > Yet another change that is much needed, but breaks ABI compatibility. Why do you think it breaks ABI compatibility? As I can see, it uses field that was reserved. Konstantin