From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: rte_mbuf.next in 2nd cacheline
Date: Mon, 15 Jun 2015 16:10:44 +0000
Message-ID: <2601191342CEEE43887BDE71AB97725836A0A952@irsmsx105.ger.corp.intel.com>
References: <2601191342CEEE43887BDE71AB97725836A0A838@irsmsx105.ger.corp.intel.com>
 <557EDB91.9010503@6wind.com> <20150615141258.GA580@bricha3-MOBL3>
 <557EE1A0.609@6wind.com>
 <2601191342CEEE43887BDE71AB97725836A0A8A8@irsmsx105.ger.corp.intel.com>
 <557EECFF.3090402@6wind.com> <20150615152346.GC580@bricha3-MOBL3>
 <2601191342CEEE43887BDE71AB97725836A0A8FB@irsmsx105.ger.corp.intel.com>
 <20150615153943.GD580@bricha3-MOBL3>
 <2601191342CEEE43887BDE71AB97725836A0A91C@irsmsx105.ger.corp.intel.com>
 <20150615160208.GE580@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 "Damjan Marion \(damarion\)" <damarion@cisco.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 1835F5A52
 for <dev@dpdk.org>; Mon, 15 Jun 2015 18:10:46 +0200 (CEST)
In-Reply-To: <20150615160208.GE580@bricha3-MOBL3>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Richardson, Bruce
> Sent: Monday, June 15, 2015 5:02 PM
> To: Ananyev, Konstantin
> Cc: Olivier MATZ; dev@dpdk.org; Damjan Marion (damarion)
> Subject: Re: [dpdk-dev] rte_mbuf.next in 2nd cacheline
>=20
> On Mon, Jun 15, 2015 at 04:59:55PM +0100, Ananyev, Konstantin wrote:
> >
> >
> >
> > As I can see, vector TX is the only one that calls __rte_pktmbuf_prefre=
e_seg() directly.
> > All others use rte_pktmbuf_free_seg(), that does ' m->next =3D NULL' an=
yway.
> > For vector TX - yes, need to verify that it would not introduce a slowd=
own.
> > Konstantin
> >
>=20
> But if the function is only directly called from one place, and that does=
n't
> have a problem, why would we bother making any change at all?


For future usages?
But sure, if you believe that we can safely remove 'm->next =3D NULL' at RX=
 path,
without any changes in the __rte_pktmbuf_prefree_seg() -
that seems fine to me.
Konstantin

>=20
> /Bruce