From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [PATCHv5 1/8] ethdev: add new API to retrieve RX/TX
 queue information
Date: Wed, 14 Oct 2015 18:44:38 +0000
Message-ID: <2601191342CEEE43887BDE71AB97725836AAFAC3@irsmsx105.ger.corp.intel.com>
References: <1443729293-20753-1-git-send-email-konstantin.ananyev@intel.com>
 <1443729293-20753-2-git-send-email-konstantin.ananyev@intel.com>
 <20151014090904.3d632d92@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 2EC1D8D8D
 for <dev@dpdk.org>; Wed, 14 Oct 2015 20:44:42 +0200 (CEST)
In-Reply-To: <20151014090904.3d632d92@xeon-e3>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Wednesday, October 14, 2015 5:09 PM
> To: Ananyev, Konstantin
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCHv5 1/8] ethdev: add new API to retrieve RX/=
TX queue information
>=20
> On Thu,  1 Oct 2015 20:54:46 +0100
> Konstantin Ananyev <konstantin.ananyev@intel.com> wrote:
>=20
> > +	if (nb_rx_desc > dev_info.rx_desc_lim.nb_max ||
> > +			nb_rx_desc < dev_info.rx_desc_lim.nb_min ||
> > +			nb_rx_desc % dev_info.rx_desc_lim.nb_align !=3D 0) {
> > +
>=20
> Preferred indentation style is to line up the conditional.
> 	if (nb_rx_desc > dev_info.rx_desc_lim.nb_max ||
> 	    nb_rx_desc < dev_info.rx_desc_lim.nb_min ||
> 	    nb_rx_desc % dev_info.rx_desc_lim.nb_align !=3D 0) {


As I remember within DPDK we use an extra tab as preferred indentation styl=
e for several years.
Why it suddenly changed now?
Konstantin