From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ananyev, Konstantin" Subject: Re: [PATCH v5] net/i40e: fix mirror rule reset when port is stopped Date: Sat, 23 Sep 2017 10:37:22 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772584F24E51D@irsmsx105.ger.corp.intel.com> References: <1505873529-64121-1-git-send-email-wei.dai@intel.com> <1505881001-12200-1-git-send-email-wei.dai@intel.com> <2601191342CEEE43887BDE71AB9772584F24D244@irsmsx105.ger.corp.intel.com> <49759EB36A64CF4892C1AFEC9231E8D650B9A377@PGSMSX106.gar.corp.intel.com> <2601191342CEEE43887BDE71AB9772584F24D80D@irsmsx105.ger.corp.intel.com> <9BB6961774997848B5B42BEC655768F810E7B199@SHSMSX103.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "stable@dpdk.org" To: "Wu, Jingjing" , "Dai, Wei" , "Xing, Beilei" Return-path: In-Reply-To: <9BB6961774997848B5B42BEC655768F810E7B199@SHSMSX103.ccr.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Wu, Jingjing > Sent: Saturday, September 23, 2017 3:27 AM > To: Ananyev, Konstantin ; Dai, Wei ; Xing, Beilei > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v5] net/i40e: fix mirror rule reset when p= ort is stopped >=20 >=20 >=20 > > -----Original Message----- > > From: Ananyev, Konstantin > > Sent: Thursday, September 21, 2017 6:46 AM > > To: Dai, Wei ; Wu, Jingjing ;= Xing, Beilei > > > > Cc: dev@dpdk.org; stable@dpdk.org > > Subject: RE: [dpdk-dev] [PATCH v5] net/i40e: fix mirror rule reset when= port is stopped > > > > Hi Wei, > > > > > > > > Hi, Konstantin > > > > > > Without this patch, when a port is stopped, all mirror SW resource ar= e cleared but HW > > settings are still there. > > > And once the port is started again, creating mirror rule may fail due= to remain HW > > settings. > > > > > > There is a testpmd use case which can show why this patch is needed. > > > 1. bind PF to igb_uio > > > #/root/dpdk-devbind.py -b igb_uio 0000:08:00.0 > > > 2. create 2 VFs > > > #echo 2 > /sys/bus/pci/devices/0000\:08\:00.0/max_vfs > > > 3. launch testpmd with PF, and set port mirror configuration > > > #./x86_64-native-linuxapp-gcc/app/testpmd -c 3 -n 4 -- -i > > > Testpmd > set port 0 mirror-rule 0 pool-mirror-up 0x1 dst-pool 1 on > > > Testpmd > quit > > > 4. relaunch testpmd with PF, and set port mirror as the same configur= ation > > > #./x86_64-native-linuxapp-gcc/app/testpmd -c 3 -n 4 -- -i > > > Testpmd > set port 0 mirror-rule 0 pool-mirror-up 0x1 dst-pool 1 on > > > I40e_mirror_rule_set( ): failed to add mirror rule: ret =3D -53, aq_= err =3D 13. > > > Mirror rule add error: (Function not implemented) > > > > > > When testpmd is quitted, rte_eth_dev_stop( ) and then rte_eth_dev_clo= se( ) are called. > > > In these function, i40e_dev_stop( ) and i40e_dev_close( ) is called. > > > And i40e_dev_stop is also called by i40e_dev_close( ). > > > > > > Without this patch, the error in second running of testpmd always hap= pen. > > > This patch can address this error. > > > > Thanks for explanation. > > Though it seems that the patch while fixing the issue might introduce s= ome > > inconsistences: > > 1. right now for i40e: dev_stop(port); dev_start(port) would keep exist= ing HW mirror rule > > working. > > With your patch is not any more. > > 2. What about ixgbe? Do we also need to change its behavior? > > As I can see right now ixgbe doesn't reset any mirror rules at dev_= stop(). > > Would it be reset automatically, or do we need to update ixgbe PMD t= oo? > > > > About #1 - if we'll decide that this is a desired behavior that dev_sto= p() voids > > all mirror rules, then at least we probably need to update the document= ation. > > As alternative - at dev_stop() we can reset only actual HW rule, but ke= ep SW > > configuration intact, > > and restore them at dev_start(). > > I personally think second option is a bit better - as it preserves exis= ting behavior, > > and probably more convenient for the user. >=20 > Yes, you reminded me the mirror is to VF. The mirror rule should be kept = or at least > be restored when device start again.. > Because the dev_stop should only stop the pf interface, but not affect VF= . It looks > like we don't delete the VEB we dev_stop. > The reset behavior may need to be done in dev_close, but not in dev_stop. if we can move that code into dev_close() , then indeed might be a better a= pproach. >=20 > > > > About the patch itself, why just not: > > while ((p_mirror =3D TAILQ_FIRST(&pf->mirror_list))) > > i40e_mirror_rule_reset(dev, p_mirror->index); > > > Wei's v1 patch is doing like that. But I commented it to change it. Becau= se > i40e_mirror_rule_reset is doing a search in the list which is not necessa= ry. Yes, but it is a control path, so need to be extra quick here. As a plus - avoid code duplication and easier to control/maintain it. Konstantin