From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [PATCH v6 4/6] gso: add GRE GSO support
Date: Wed, 4 Oct 2017 14:15:39 +0000
Message-ID: <2601191342CEEE43887BDE71AB9772585FAA3E00@IRSMSX103.ger.corp.intel.com>
References: <1506636833-25851-1-git-send-email-mark.b.kavanagh@intel.com>
 <1506962749-106779-1-git-send-email-mark.b.kavanagh@intel.com>
 <1506962749-106779-5-git-send-email-mark.b.kavanagh@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Hu, Jiayu" <jiayu.hu@intel.com>, "Tan, Jianfeng"
 <jianfeng.tan@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 "thomas@monjalon.net" <thomas@monjalon.net>
To: "Kavanagh, Mark B" <mark.b.kavanagh@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id B6A921B65E
 for <dev@dpdk.org>; Wed,  4 Oct 2017 16:15:43 +0200 (CEST)
In-Reply-To: <1506962749-106779-5-git-send-email-mark.b.kavanagh@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


> diff --git a/lib/librte_gso/rte_gso.c b/lib/librte_gso/rte_gso.c
> index 6095689..b748ab1 100644
> --- a/lib/librte_gso/rte_gso.c
> +++ b/lib/librte_gso/rte_gso.c
> @@ -60,8 +60,9 @@
>=20
>  	if ((gso_ctx->gso_size >=3D pkt->pkt_len) || (gso_ctx->gso_types &
>  				(DEV_TX_OFFLOAD_TCP_TSO |
> -				 DEV_TX_OFFLOAD_VXLAN_TNL_TSO)) !=3D
> -				gso_ctx->gso_types) {
> +				 DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
> +				 DEV_TX_OFFLOAD_GRE_TNL_TSO)) !=3D
> +				 gso_ctx->gso_types) {
>  		pkt->ol_flags &=3D (~PKT_TX_TCP_SEG);
>  		pkts_out[0] =3D pkt;
>  		return 1;
> @@ -73,7 +74,8 @@
>  	ipid_delta =3D (gso_ctx->ipid_flag !=3D RTE_GSO_IPID_FIXED);
>  	ol_flags =3D pkt->ol_flags;
>=20
> -	if (IS_IPV4_VXLAN_TCP4(pkt->ol_flags)) {
> +	if (IS_IPV4_VXLAN_TCP4(pkt->ol_flags) ||
> +			IS_IPV4_GRE_TCP4(pkt->ol_flags)) {

Same comment as for previous patch: user might want that ctx to=20
Segment vxlan packets and not segment gro packets.
Konstantin

>  		pkt->ol_flags &=3D (~PKT_TX_TCP_SEG);
>  		ret =3D gso_tunnel_tcp4_segment(pkt, gso_size, ipid_delta,
>  				direct_pool, indirect_pool,
> --
> 1.9.3