From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ananyev, Konstantin" Subject: Re: [PATCH 7/7] ethdev: use opaque user callback object Date: Fri, 1 Dec 2017 11:22:12 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772585FAC3718@irsmsx105.ger.corp.intel.com> References: <20171201022957.64329-1-ferruh.yigit@intel.com> <20171201022957.64329-7-ferruh.yigit@intel.com> <20171201103308.GB10384@bricha3-MOBL3.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: Thomas Monjalon , "dev@dpdk.org" , "vladz@cloudius-systems.com" To: "Richardson, Bruce" , "Yigit, Ferruh" Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 92EB8107A for ; Fri, 1 Dec 2017 12:22:16 +0100 (CET) In-Reply-To: <20171201103308.GB10384@bricha3-MOBL3.ger.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > Sent: Friday, December 1, 2017 10:33 AM > To: Yigit, Ferruh > Cc: Thomas Monjalon ; dev@dpdk.org; vladz@cloudius-s= ystems.com > Subject: Re: [dpdk-dev] [PATCH 7/7] ethdev: use opaque user callback obje= ct >=20 > On Fri, Dec 01, 2017 at 02:29:57AM +0000, Ferruh Yigit wrote: > > "struct rte_eth_rxtx_callback" is defined as internal data structure bu= t > > used in public APIs. > > > > Checking the API documentation shows that intention was using this > > object as opaque object. Data structure only used in delete APIs which > > doesn't require to know the internals of the data structure. > > > > Converting callback parameter in API to void pointer should not require > > any modification in user application because this data structure was > > already marked as internal and only should be used as pointer in > > application. > > > > Signed-off-by: Ferruh Yigit > > --- >=20 > I disagree on this patch. The structure itself is not exposed, only the > name, since it is only passed around as a pointer, so there is no need > to change the parameters to void pointer. It's a named opaque type. Personally I think it would be better to do visa-versa:=20 make rte_eth_add_(rx|tx)_callback() to return struct rte_eth_rxtx_callback = * instead of void *. Konstantin