From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ananyev, Konstantin" Subject: Re: [PATCH 1/3] net/ixgbe: remove dependence on Tx queue flags Date: Wed, 2 May 2018 11:22:55 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258AEDC15F0@irsmsx105.ger.corp.intel.com> References: <20180502031626.66443-1-qi.z.zhang@intel.com> <20180502031626.66443-2-qi.z.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "Dai, Wei" , "Lu, Wenzhuo" , "Wang, Xiao W" , "dev@dpdk.org" To: "Zhang, Qi Z" , "Yigit, Ferruh" Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 06B7E23C for ; Wed, 2 May 2018 13:22:58 +0200 (CEST) In-Reply-To: <20180502031626.66443-2-qi.z.zhang@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, May 2, 2018 4:16 AM > To: Yigit, Ferruh > Cc: Dai, Wei ; Lu, Wenzhuo ; Ana= nyev, Konstantin ; > Wang, Xiao W ; dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH 1/3] net/ixgbe: remove dependence on Tx queue flags >=20 > Since we move to new offload APIs, txq_flags is no long needed. > This patch remove the dependence on that. >=20 > Fixes: 51215925a32f ("net/ixgbe: convert to new Tx offloads API") >=20 > Signed-off-by: Qi Zhang > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 6 ------ > drivers/net/ixgbe/ixgbe_rxtx.c | 2 -- > drivers/net/ixgbe/ixgbe_rxtx.h | 1 - > 3 files changed, 9 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_e= thdev.c > index 6088c7e48..709251fbb 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -3727,9 +3727,6 @@ ixgbe_dev_info_get(struct rte_eth_dev *dev, struct = rte_eth_dev_info *dev_info) > }, > .tx_free_thresh =3D IXGBE_DEFAULT_TX_FREE_THRESH, > .tx_rs_thresh =3D IXGBE_DEFAULT_TX_RSBIT_THRESH, > - .txq_flags =3D ETH_TXQ_FLAGS_NOMULTSEGS | > - ETH_TXQ_FLAGS_NOOFFLOADS | > - ETH_TXQ_FLAGS_IGNORE, > .offloads =3D 0, > }; But old apps still use txq_flags returned by dev_info_get. Removing it right now will mean this value will be undefined.=20 >=20 > @@ -3835,9 +3832,6 @@ ixgbevf_dev_info_get(struct rte_eth_dev *dev, > }, > .tx_free_thresh =3D IXGBE_DEFAULT_TX_FREE_THRESH, > .tx_rs_thresh =3D IXGBE_DEFAULT_TX_RSBIT_THRESH, > - .txq_flags =3D ETH_TXQ_FLAGS_NOMULTSEGS | > - ETH_TXQ_FLAGS_NOOFFLOADS | > - ETH_TXQ_FLAGS_IGNORE, > .offloads =3D 0, > }; >=20 > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxt= x.c > index 2892436e9..47045ddd0 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > @@ -2620,7 +2620,6 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_dev *dev, > txq->reg_idx =3D (uint16_t)((RTE_ETH_DEV_SRIOV(dev).active =3D=3D 0) ? > queue_idx : RTE_ETH_DEV_SRIOV(dev).def_pool_q_idx + queue_idx); > txq->port_id =3D dev->data->port_id; > - txq->txq_flags =3D tx_conf->txq_flags; > txq->offloads =3D tx_conf->offloads; > txq->ops =3D &def_txq_ops; > txq->tx_deferred_start =3D tx_conf->tx_deferred_start; > @@ -5441,7 +5440,6 @@ ixgbe_txq_info_get(struct rte_eth_dev *dev, uint16_= t queue_id, >=20 > qinfo->conf.tx_free_thresh =3D txq->tx_free_thresh; > qinfo->conf.tx_rs_thresh =3D txq->tx_rs_thresh; > - qinfo->conf.txq_flags =3D txq->txq_flags; Same here - old apps can still use it. Ideally we'll have to fill it based on txq->offloads value. Konstantin > qinfo->conf.offloads =3D txq->offloads; > qinfo->conf.tx_deferred_start =3D txq->tx_deferred_start; > } > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.h b/drivers/net/ixgbe/ixgbe_rxt= x.h > index 7dbbbe5b3..20ef7b6ff 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx.h > +++ b/drivers/net/ixgbe/ixgbe_rxtx.h > @@ -222,7 +222,6 @@ struct ixgbe_tx_queue { > uint8_t pthresh; /**< Prefetch threshold register. */ > uint8_t hthresh; /**< Host threshold register. */ > uint8_t wthresh; /**< Write-back threshold reg. */ > - uint32_t txq_flags; /**< Holds flags for this TXq */ > uint64_t offloads; /**< Tx offload flags of DEV_TX_OFFLOAD_* */ > uint32_t ctx_curr; /**< Hardware context states. */ > /** Hardware context0 history. */ > -- > 2.13.6