From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [PATCH v4 11/23] rte_mbuf.h: explicit cast
 restricting ptrdiff to uint16
Date: Thu, 17 May 2018 11:03:14 +0000
Message-ID: <2601191342CEEE43887BDE71AB977258AEDC8830@irsmsx105.ger.corp.intel.com>
References: <152627436523.53156.4398253089110011263.stgit@localhost.localdomain>
 <152627462287.53156.1972221889368883834.stgit@localhost.localdomain>
 <20180517105042.GC22048@bricha3-MOBL.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Richardson, Bruce" <bruce.richardson@intel.com>, Andy Green
 <andy@warmcat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 419F158C6
 for <dev@dpdk.org>; Thu, 17 May 2018 13:03:17 +0200 (CEST)
In-Reply-To: <20180517105042.GC22048@bricha3-MOBL.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson
> Sent: Thursday, May 17, 2018 11:51 AM
> To: Andy Green <andy@warmcat.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 11/23] rte_mbuf.h: explicit cast restri=
cting ptrdiff to uint16
>=20
> On Mon, May 14, 2018 at 01:10:22PM +0800, Andy Green wrote:
> > /projects/lagopus/src/dpdk/build/include/rte_common.h:141:34:
> > warning: conversion from 'long unsigned int' to 'uint16_t'
> > {aka 'short unsigned int'} may change value [-Wconversion]
> >  #define RTE_PTR_DIFF(ptr1, ptr2) ((uintptr_t)(ptr1) -
> > (uintptr_t)(ptr2))
> >                                   ^
> > /projects/lagopus/src/dpdk/build/include/rte_mbuf.h:1360:13:
> > note: in expansion of macro 'RTE_PTR_DIFF'
> >   *buf_len =3D RTE_PTR_DIFF(shinfo, buf_addr);
> >
> > Signed-off-by: Andy Green <andy@warmcat.com>
> > ---
> >  lib/librte_mbuf/rte_mbuf.h |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> > index a27dbb878..0580ec8a0 100644
> > --- a/lib/librte_mbuf/rte_mbuf.h
> > +++ b/lib/librte_mbuf/rte_mbuf.h
> > @@ -1358,7 +1358,7 @@ rte_pktmbuf_ext_shinfo_init_helper(void *buf_addr=
, uint16_t *buf_len,
> >  	shinfo->fcb_opaque =3D fcb_opaque;
> >  	rte_mbuf_ext_refcnt_set(shinfo, 1);
> >
> > -	*buf_len =3D RTE_PTR_DIFF(shinfo, buf_addr);
> > +	*buf_len =3D (uint16_t)RTE_PTR_DIFF(shinfo, buf_addr);
> >  	return shinfo;
> >  }
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>


Just as a nit: if all such conversions are unavoidable - might be introduce=
:
RTE_PTR_DIFF_TYPE(.., type)	((type)(RTE_PTR_DIFF(...))
Might look a bit nicer.
Konstantin