From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753335AbaETNGX (ORCPT ); Tue, 20 May 2014 09:06:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34431 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752448AbaETNGV (ORCPT ); Tue, 20 May 2014 09:06:21 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20140508135852.605324173@infradead.org> References: <20140508135852.605324173@infradead.org> <20140508135840.956784204@infradead.org> To: Peter Zijlstra Cc: dhowells@redhat.com, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, mingo@kernel.org, will.deacon@arm.com, paulmck@linux.vnet.ibm.com, Koichi Yasutake Subject: Re: [PATCH 14/20] arch,mn10300: Fold atomic_ops Date: Tue, 20 May 2014 14:05:32 +0100 Message-ID: <26031.1400591132@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Peter Zijlstra wrote: > +#define ATOMIC_OPS(op) ATOMIC_OP(op) ATOMIC_OP_RETURN(op) Can ATOMIC_OP() just be an alias for ATOMIC_OP_RETURN() where that is appropriate? I suspect several arches (MN10300 included) are going to return the value *anyway*. David