From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, kwolf@redhat.com
Subject: Re: [Qemu-devel] [PATCH for-2.9 1/5] test-keyval: Tweaks to improve list coverage
Date: Mon, 20 Mar 2017 14:50:09 -0500 [thread overview]
Message-ID: <260797ce-5d60-d49d-df6e-aff8e05b7460@redhat.com> (raw)
In-Reply-To: <1490014548-15083-2-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 618 bytes --]
On 03/20/2017 07:55 AM, Markus Armbruster wrote:
> We have a negative test case for a list index with leading zero. Add
> positive ones.
>
> Tweak the test case for list index greater or equal the number of
> elements: test "equal" instead of "greater" to guard against
> off-by-one mistakes.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> tests/test-keyval.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-03-20 19:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 12:55 [Qemu-devel] [PATCH for-2.9 0/5] keyval: Doc improvements and additional tests Markus Armbruster
2017-03-20 12:55 ` [Qemu-devel] [PATCH for-2.9 1/5] test-keyval: Tweaks to improve list coverage Markus Armbruster
2017-03-20 19:50 ` Eric Blake [this message]
2017-03-20 12:55 ` [Qemu-devel] [PATCH for-2.9 2/5] keyval: Improve some comments Markus Armbruster
2017-03-20 19:54 ` Eric Blake
2017-03-20 12:55 ` [Qemu-devel] [PATCH for-2.9 3/5] test-keyval: Cover alternate and 'any' type Markus Armbruster
2017-03-20 19:59 ` Eric Blake
2017-03-20 12:55 ` [Qemu-devel] [PATCH for-2.9 4/5] keyval: Document issues with 'any' and alternate types Markus Armbruster
2017-03-20 20:02 ` Eric Blake
2017-03-21 7:14 ` Markus Armbruster
2017-03-20 12:55 ` [Qemu-devel] [PATCH for-2.9 5/5] MAINTAINERS: Add myself for files I touched recently Markus Armbruster
2017-03-20 20:03 ` Eric Blake
2017-03-21 7:17 ` Markus Armbruster
2017-03-21 7:58 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=260797ce-5d60-d49d-df6e-aff8e05b7460@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.