From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([95.142.166.194]:40866 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758357Ab2JKMv5 (ORCPT ); Thu, 11 Oct 2012 08:51:57 -0400 From: Laurent Pinchart To: dri-devel@lists.freedesktop.org Cc: Hans Verkuil , Alan Cox , linaro-mm-sig@lists.linaro.org, Rob Clark , Sumit Semwal , linux-media@vger.kernel.org Subject: Re: [PATCH] dma-buf: Use EXPORT_SYMBOL Date: Thu, 11 Oct 2012 14:52:41 +0200 Message-ID: <2608521.UUolBFecrg@avalon> In-Reply-To: <201210111336.45574.hverkuil@xs4all.nl> References: <1349884592-32485-1-git-send-email-rmorell@nvidia.com> <20121011123407.63b5ecbe@pyramind.ukuu.org.uk> <201210111336.45574.hverkuil@xs4all.nl> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Hans, On Thursday 11 October 2012 13:36:45 Hans Verkuil wrote: > On Thu 11 October 2012 13:34:07 Alan Cox wrote: > > > The whole purpose of this API is to let DRM and V4L drivers share > > > buffers for zero-copy pipelines. Unfortunately it is a fact that > > > several popular DRM drivers are closed source. So we have a choice > > > between keeping the export symbols GPL and forcing those closed-source > > > drivers to make their own incompatible API, thus defeating the whole > > > point of DMABUF, or using EXPORT_SYMBOL and letting the closed source > > > vendors worry about the legality. They are already using such functions > > > (at least nvidia is), so they clearly accept that risk. > > > > Then they can accept the risk of ignoring EXPORT_SYMBOL_GPL and > > calling into it anyway can't they. Your argument makes no rational sense > > of any kind. > > Out of curiosity: why do we have both an EXPORT_SYMBOL and an > EXPORT_SYMBOL_GPL if there is no legal difference? > > And if there is a difference between the two, then what is it? As far as I understand, EXPORT_SYMBOL_GPL means "I consider closed-source kernel modules as a GPL violation, you can have a different opinion, but then don't use my APIs". -- Regards, Laurent Pinchart