From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:52224 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727262AbeJQOpv (ORCPT ); Wed, 17 Oct 2018 10:45:51 -0400 From: Laurent Pinchart To: Fabrizio Castro Cc: Kieran Bingham , David Airlie , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Simon Horman , Geert Uytterhoeven , Chris Paterson , Biju Das Subject: Re: [PATCH v2 3/5] drm: rcar-du: Add r8a77470 support Date: Wed, 17 Oct 2018 09:51:45 +0300 Message-ID: <2608669.V0TntACJSi@avalon> In-Reply-To: <1539709139-20342-1-git-send-email-fabrizio.castro@bp.renesas.com> References: <1539709139-20342-1-git-send-email-fabrizio.castro@bp.renesas.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Fabrizio, Thank you for the patch. On Tuesday, 16 October 2018 19:58:59 EEST Fabrizio Castro wrote: > Add RZ/G1C (a.k.a. r8a77470) support to the R-Car DU driver. > > Signed-off-by: Fabrizio Castro > Reviewed-by: Laurent Pinchart > > --- > v1->v2: > * Added flags RCAR_DU_FEATURE_INTERLACED and RCAR_DU_FEATURE_TVM_SYNC > * Reworked comment This looks all good, applied to my tree. > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 084f58d..d8a02c4 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -77,6 +77,33 @@ static const struct rcar_du_device_info > rzg1_du_r8a7745_info = { }, > }; > > +static const struct rcar_du_device_info rzg1_du_r8a77470_info = { > + .gen = 2, > + .features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK > + | RCAR_DU_FEATURE_EXT_CTRL_REGS > + | RCAR_DU_FEATURE_INTERLACED > + | RCAR_DU_FEATURE_TVM_SYNC, > + .channels_mask = BIT(1) | BIT(0), > + .routes = { > + /* > + * R8A77470 has two RGB outputs, one LVDS output, and > + * one (currently unsupported) analog video output > + */ > + [RCAR_DU_OUTPUT_DPAD0] = { > + .possible_crtcs = BIT(0), > + .port = 0, > + }, > + [RCAR_DU_OUTPUT_DPAD1] = { > + .possible_crtcs = BIT(1), > + .port = 1, > + }, > + [RCAR_DU_OUTPUT_LVDS0] = { > + .possible_crtcs = BIT(0) | BIT(1), > + .port = 2, > + }, > + }, > +}; > + > static const struct rcar_du_device_info rcar_du_r8a7779_info = { > .gen = 2, > .features = RCAR_DU_FEATURE_INTERLACED > @@ -342,6 +369,7 @@ static const struct rcar_du_device_info > rcar_du_r8a7799x_info = { static const struct of_device_id > rcar_du_of_table[] = { > { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info }, > { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info }, > + { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info }, > { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info }, > { .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info }, > { .compatible = "renesas,du-r8a7791", .data = &rcar_du_r8a7791_info }, -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 3/5] drm: rcar-du: Add r8a77470 support Date: Wed, 17 Oct 2018 09:51:45 +0300 Message-ID: <2608669.V0TntACJSi@avalon> References: <1539709139-20342-1-git-send-email-fabrizio.castro@bp.renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3318B6E2F0 for ; Wed, 17 Oct 2018 06:51:41 +0000 (UTC) In-Reply-To: <1539709139-20342-1-git-send-email-fabrizio.castro@bp.renesas.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Fabrizio Castro Cc: Simon Horman , Chris Paterson , Geert Uytterhoeven , David Airlie , dri-devel@lists.freedesktop.org, Biju Das , linux-renesas-soc@vger.kernel.org, Kieran Bingham List-Id: dri-devel@lists.freedesktop.org SGkgRmFicml6aW8sCgpUaGFuayB5b3UgZm9yIHRoZSBwYXRjaC4KCk9uIFR1ZXNkYXksIDE2IE9j dG9iZXIgMjAxOCAxOTo1ODo1OSBFRVNUIEZhYnJpemlvIENhc3RybyB3cm90ZToKPiBBZGQgUlov RzFDIChhLmsuYS4gcjhhNzc0NzApIHN1cHBvcnQgdG8gdGhlIFItQ2FyIERVIGRyaXZlci4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBGYWJyaXppbyBDYXN0cm8gPGZhYnJpemlvLmNhc3Ryb0BicC5yZW5l c2FzLmNvbT4KPiBSZXZpZXdlZC1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFy dEBpZGVhc29uYm9hcmQuY29tPgo+IAo+IC0tLQo+IHYxLT52MjoKPiAqIEFkZGVkIGZsYWdzIFJD QVJfRFVfRkVBVFVSRV9JTlRFUkxBQ0VEIGFuZCBSQ0FSX0RVX0ZFQVRVUkVfVFZNX1NZTkMKPiAq IFJld29ya2VkIGNvbW1lbnQKClRoaXMgbG9va3MgYWxsIGdvb2QsIGFwcGxpZWQgdG8gbXkgdHJl ZS4KCj4gIGRyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmMgfCAyOCArKysrKysr KysrKysrKysrKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAyOCBpbnNlcnRpb25zKCsp Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmMK PiBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmMgaW5kZXggMDg0ZjU4ZC4u ZDhhMDJjNCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2Ry di5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuYwo+IEBAIC03 Nyw2ICs3NywzMyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHJjYXJfZHVfZGV2aWNlX2luZm8KPiBy emcxX2R1X3I4YTc3NDVfaW5mbyA9IHsgfSwKPiAgfTsKPiAKPiArc3RhdGljIGNvbnN0IHN0cnVj dCByY2FyX2R1X2RldmljZV9pbmZvIHJ6ZzFfZHVfcjhhNzc0NzBfaW5mbyA9IHsKPiArCS5nZW4g PSAyLAo+ICsJLmZlYXR1cmVzID0gUkNBUl9EVV9GRUFUVVJFX0NSVENfSVJRX0NMT0NLCj4gKwkJ ICB8IFJDQVJfRFVfRkVBVFVSRV9FWFRfQ1RSTF9SRUdTCj4gKwkJICB8IFJDQVJfRFVfRkVBVFVS RV9JTlRFUkxBQ0VECj4gKwkJICB8IFJDQVJfRFVfRkVBVFVSRV9UVk1fU1lOQywKPiArCS5jaGFu bmVsc19tYXNrID0gQklUKDEpIHwgQklUKDApLAo+ICsJLnJvdXRlcyA9IHsKPiArCQkvKgo+ICsJ CSAqIFI4QTc3NDcwIGhhcyB0d28gUkdCIG91dHB1dHMsIG9uZSBMVkRTIG91dHB1dCwgYW5kCj4g KwkJICogb25lIChjdXJyZW50bHkgdW5zdXBwb3J0ZWQpIGFuYWxvZyB2aWRlbyBvdXRwdXQKPiAr CQkgKi8KPiArCQlbUkNBUl9EVV9PVVRQVVRfRFBBRDBdID0gewo+ICsJCQkucG9zc2libGVfY3J0 Y3MgPSBCSVQoMCksCj4gKwkJCS5wb3J0ID0gMCwKPiArCQl9LAo+ICsJCVtSQ0FSX0RVX09VVFBV VF9EUEFEMV0gPSB7Cj4gKwkJCS5wb3NzaWJsZV9jcnRjcyA9IEJJVCgxKSwKPiArCQkJLnBvcnQg PSAxLAo+ICsJCX0sCj4gKwkJW1JDQVJfRFVfT1VUUFVUX0xWRFMwXSA9IHsKPiArCQkJLnBvc3Np YmxlX2NydGNzID0gQklUKDApIHwgQklUKDEpLAo+ICsJCQkucG9ydCA9IDIsCj4gKwkJfSwKPiAr CX0sCj4gK307Cj4gKwo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IHJjYXJfZHVfZGV2aWNlX2luZm8g cmNhcl9kdV9yOGE3Nzc5X2luZm8gPSB7Cj4gIAkuZ2VuID0gMiwKPiAgCS5mZWF0dXJlcyA9IFJD QVJfRFVfRkVBVFVSRV9JTlRFUkxBQ0VECj4gQEAgLTM0Miw2ICszNjksNyBAQCBzdGF0aWMgY29u c3Qgc3RydWN0IHJjYXJfZHVfZGV2aWNlX2luZm8KPiByY2FyX2R1X3I4YTc3OTl4X2luZm8gPSB7 IHN0YXRpYyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkCj4gcmNhcl9kdV9vZl90YWJsZVtdID0g ewo+ICAJeyAuY29tcGF0aWJsZSA9ICJyZW5lc2FzLGR1LXI4YTc3NDMiLCAuZGF0YSA9ICZyemcx X2R1X3I4YTc3NDNfaW5mbyB9LAo+ICAJeyAuY29tcGF0aWJsZSA9ICJyZW5lc2FzLGR1LXI4YTc3 NDUiLCAuZGF0YSA9ICZyemcxX2R1X3I4YTc3NDVfaW5mbyB9LAo+ICsJeyAuY29tcGF0aWJsZSA9 ICJyZW5lc2FzLGR1LXI4YTc3NDcwIiwgLmRhdGEgPSAmcnpnMV9kdV9yOGE3NzQ3MF9pbmZvIH0s Cj4gIAl7IC5jb21wYXRpYmxlID0gInJlbmVzYXMsZHUtcjhhNzc3OSIsIC5kYXRhID0gJnJjYXJf ZHVfcjhhNzc3OV9pbmZvIH0sCj4gIAl7IC5jb21wYXRpYmxlID0gInJlbmVzYXMsZHUtcjhhNzc5 MCIsIC5kYXRhID0gJnJjYXJfZHVfcjhhNzc5MF9pbmZvIH0sCj4gIAl7IC5jb21wYXRpYmxlID0g InJlbmVzYXMsZHUtcjhhNzc5MSIsIC5kYXRhID0gJnJjYXJfZHVfcjhhNzc5MV9pbmZvIH0sCgoK LS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgoKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=