All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yong Wang <yongwang@vmware.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: handle bad host framing
Date: Wed, 13 May 2020 22:24:14 +0000	[thread overview]
Message-ID: <260BA1B6-74AE-40D4-B415-E566C570D202@vmware.com> (raw)
In-Reply-To: <20200512204003.26686-1-stephen@networkplumber.org>

-----Original Message-----
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Tuesday, May 12, 2020 at 1:40 PM
To: Yong Wang <yongwang@vmware.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH] net/vmxnet3: handle bad host framing

    The VMXNet3 protocol has a start-of-packet (SOP) and end-of-packet (EOP)
    marker. If there was a bug where mbuf arrived without SOP the code
    that chains the mbuf would dereference a null pointer.
    Also, record any mbuf's dropped in statistics.

    Although did the initial code no longer have access to VMware.
    Compile tested only!

    Coverity issue: 124563
    Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
    ---

<Acked-by> Yong Wang <yongwang@vmware.com>

     drivers/net/vmxnet3/vmxnet3_rxtx.c | 6 +++++-
     1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c
    index dd99684bee4d..73e270f30f00 100644
    --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
    +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
    @@ -950,13 +950,17 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)

     			RTE_ASSERT(rxd->btype == VMXNET3_RXD_BTYPE_BODY);

    -			if (rxm->data_len) {
    +			if (likely(start && rxm->data_len > 0)) {
     				start->pkt_len += rxm->data_len;
     				start->nb_segs++;

     				rxq->last_seg->next = rxm;
     				rxq->last_seg = rxm;
     			} else {
    +				PMD_RX_LOG(ERR, "Error received empty or out of order frame.");
    +				rxq->stats.drop_total++;
    +				rxq->stats.drop_err++;
    +
     				rte_pktmbuf_free_seg(rxm);
     			}
     		}
    -- 
    2.20.1



  reply	other threads:[~2020-05-13 22:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-12 20:40 [dpdk-dev] [PATCH] net/vmxnet3: handle bad host framing Stephen Hemminger
2020-05-13 22:24 ` Yong Wang [this message]
2020-05-14 16:15   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=260BA1B6-74AE-40D4-B415-E566C570D202@vmware.com \
    --to=yongwang@vmware.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.