From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FD9DC6FD1C for ; Wed, 22 Mar 2023 13:34:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229487AbjCVNet (ORCPT ); Wed, 22 Mar 2023 09:34:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229766AbjCVNer (ORCPT ); Wed, 22 Mar 2023 09:34:47 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A981F1C7C2; Wed, 22 Mar 2023 06:34:46 -0700 (PDT) Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32MAqXta016074; Wed, 22 Mar 2023 13:34:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=YgVZtbUR9p2k85+G8QC4fqCb8I2QJV0Myy+6LpBaJ1o=; b=dtuVHfOXuCuS939os10u+epPm9NBN3oVRXg8tUU5bnZTRZkN0IZ6AuIJrNQB1kpDFKlX zq52YVW6F7Cen+xZGb9x0g09FfZU36TRVDbHmxRAlbZ6cNRFN2C0ywPe2V7mhAXQoP81 ippKpSi3b338N1Fg3gjGPtblmLJHEcDAHqwoy7Jp6upFDWWToNINJOjMAsuwTm7CRLpE CiAwaDUMVR3qIvp/iZ+jnXOVxrglFXe0fV4x7z+QdRhR4mJYusnb5bReBtas3TMSx9kM 13ImDxDqB/twa6PwvhiyK2K7gyILnjIngaonK5j86RT0ThqCPvf4/jiUvDOX+8k1onrR qA== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3pfhntj7y3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Mar 2023 13:34:33 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 32MDYNOR015936 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Mar 2023 13:34:23 GMT Received: from [10.50.8.113] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 22 Mar 2023 06:34:19 -0700 Message-ID: <260cf3ae-1acd-c4ac-a42d-4ca848ec5664@quicinc.com> Date: Wed, 22 Mar 2023 19:04:05 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH V1 1/4] dt-bindings: sram: qcom,imem: Add Boot Stat region within IMEM To: Krzysztof Kozlowski , Andy Gross , Konrad Dybcio , "Krzysztof Kozlowski" , Bjorn Andersson , Rob Herring CC: , , , , Sibi Sankar , Rajendra Nayak References: <1589f33deda07cb9f9e6c3c26bce6e02e53c168e.1679403696.git.quic_schowdhu@quicinc.com> Content-Language: en-US From: Souradeep Chowdhury In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: kGOUVGme2fb9q39K6jMWZNO8b2mzgs2Z X-Proofpoint-ORIG-GUID: kGOUVGme2fb9q39K6jMWZNO8b2mzgs2Z X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-22_11,2023-03-22_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 suspectscore=0 phishscore=0 mlxlogscore=971 bulkscore=0 mlxscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 priorityscore=1501 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002 definitions=main-2303220099 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 3/21/2023 11:01 PM, Krzysztof Kozlowski wrote: > On 21/03/2023 14:51, Souradeep Chowdhury wrote: >> All Qualcomm bootloaders log useful timestamp information related >> to bootloader stats in the IMEM region. Add the child node within >> IMEM for the boot stat region containing register address and >> compatible string. >> >> Signed-off-by: Souradeep Chowdhury >> --- >> .../devicetree/bindings/sram/qcom,imem.yaml | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml >> index 665c06e..c8c3890 100644 >> --- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml >> +++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml >> @@ -48,6 +48,26 @@ patternProperties: >> $ref: /schemas/remoteproc/qcom,pil-info.yaml# >> description: Peripheral image loader relocation region >> >> + "^boot-stat@[0-9a-f]+$": >> + type: object >> + description: >> + node for boot stat. > > This basically copies the name of node, so not really helpful. Describe > what's this. Ack > >> + > > additionalProperties: false > >> + properties: >> + compatible: >> + items: > > Drop items. > >> + - const: qcom,imem-boot_stats > > No underscores in compatibles. Why this is not SoC specific compatible? Ack. The boot_stats module is not specific to a device. It is written to read some values from this imem region which is present for almost all QCOM SoCs. So SoC specific compatible is not given in this case. > >> + >> + reg: >> + maxItems: 1 >> + description: >> + The base address of the register region in case of >> + imem boot stats. > > Drop description, it's obvious. Ack >> + >> + required: >> + - compatible >> + - reg >> + > Best regards, > Krzysztof > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD531C6FD1C for ; Wed, 22 Mar 2023 13:35:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=js4JXJARylxprV+/bT7oeKEiLx0DI+os43P/K8/DGDQ=; b=y9FFNWg9kcRLaJ 7cksli1KSmveGsSSw1bwPhzGp6uOkCj9uESAjCmoupZAXL5YFpsjev/v5ga2BYuukiMOYsPInX2bx /3mU5SIpGcs4rzwj3tKdFMWVcwXZ3oAAoPBrMShN6so4Kc80K17xWR760yKUMbIkTIXUyoi2nuoID je7osM+gwuvbtKf0JMaOv7LMO6VCJ2HAiCqwleSt59NpUVlluIcCakr0wbCkH65DERbBmKdhZkY4/ slTpQZZwt0zl9tQIIxWRSVW2OK/opK763OGAAjXIHCpTidLC0QvW3BXRCRKphcrZpZJ0hV9XjM5Nb uwQK7uNXuwi0sGvJVQZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peyc0-00G8Pu-2S; Wed, 22 Mar 2023 13:34:44 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peybv-00G8OY-2T for linux-arm-kernel@lists.infradead.org; Wed, 22 Mar 2023 13:34:43 +0000 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32MAqXta016074; Wed, 22 Mar 2023 13:34:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=YgVZtbUR9p2k85+G8QC4fqCb8I2QJV0Myy+6LpBaJ1o=; b=dtuVHfOXuCuS939os10u+epPm9NBN3oVRXg8tUU5bnZTRZkN0IZ6AuIJrNQB1kpDFKlX zq52YVW6F7Cen+xZGb9x0g09FfZU36TRVDbHmxRAlbZ6cNRFN2C0ywPe2V7mhAXQoP81 ippKpSi3b338N1Fg3gjGPtblmLJHEcDAHqwoy7Jp6upFDWWToNINJOjMAsuwTm7CRLpE CiAwaDUMVR3qIvp/iZ+jnXOVxrglFXe0fV4x7z+QdRhR4mJYusnb5bReBtas3TMSx9kM 13ImDxDqB/twa6PwvhiyK2K7gyILnjIngaonK5j86RT0ThqCPvf4/jiUvDOX+8k1onrR qA== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3pfhntj7y3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Mar 2023 13:34:33 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 32MDYNOR015936 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Mar 2023 13:34:23 GMT Received: from [10.50.8.113] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 22 Mar 2023 06:34:19 -0700 Message-ID: <260cf3ae-1acd-c4ac-a42d-4ca848ec5664@quicinc.com> Date: Wed, 22 Mar 2023 19:04:05 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH V1 1/4] dt-bindings: sram: qcom,imem: Add Boot Stat region within IMEM To: Krzysztof Kozlowski , Andy Gross , Konrad Dybcio , "Krzysztof Kozlowski" , Bjorn Andersson , Rob Herring CC: , , , , Sibi Sankar , Rajendra Nayak References: <1589f33deda07cb9f9e6c3c26bce6e02e53c168e.1679403696.git.quic_schowdhu@quicinc.com> Content-Language: en-US From: Souradeep Chowdhury In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: kGOUVGme2fb9q39K6jMWZNO8b2mzgs2Z X-Proofpoint-ORIG-GUID: kGOUVGme2fb9q39K6jMWZNO8b2mzgs2Z X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-22_11,2023-03-22_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 suspectscore=0 phishscore=0 mlxlogscore=971 bulkscore=0 mlxscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 priorityscore=1501 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002 definitions=main-2303220099 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230322_063439_811537_140952E0 X-CRM114-Status: GOOD ( 18.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/21/2023 11:01 PM, Krzysztof Kozlowski wrote: > On 21/03/2023 14:51, Souradeep Chowdhury wrote: >> All Qualcomm bootloaders log useful timestamp information related >> to bootloader stats in the IMEM region. Add the child node within >> IMEM for the boot stat region containing register address and >> compatible string. >> >> Signed-off-by: Souradeep Chowdhury >> --- >> .../devicetree/bindings/sram/qcom,imem.yaml | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml >> index 665c06e..c8c3890 100644 >> --- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml >> +++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml >> @@ -48,6 +48,26 @@ patternProperties: >> $ref: /schemas/remoteproc/qcom,pil-info.yaml# >> description: Peripheral image loader relocation region >> >> + "^boot-stat@[0-9a-f]+$": >> + type: object >> + description: >> + node for boot stat. > > This basically copies the name of node, so not really helpful. Describe > what's this. Ack > >> + > > additionalProperties: false > >> + properties: >> + compatible: >> + items: > > Drop items. > >> + - const: qcom,imem-boot_stats > > No underscores in compatibles. Why this is not SoC specific compatible? Ack. The boot_stats module is not specific to a device. It is written to read some values from this imem region which is present for almost all QCOM SoCs. So SoC specific compatible is not given in this case. > >> + >> + reg: >> + maxItems: 1 >> + description: >> + The base address of the register region in case of >> + imem boot stats. > > Drop description, it's obvious. Ack >> + >> + required: >> + - compatible >> + - reg >> + > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel