All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: anatoly.burakov@intel.com
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>, dev@dpdk.org
Subject: Re: [PATCH v2] eal: enable vfio independent of no PCI flag
Date: Tue, 10 Oct 2017 18:27:22 +0200	[thread overview]
Message-ID: <2615630.Np2p4rFThG@xps> (raw)
In-Reply-To: <6e9b5a3b-4a5c-13b4-f0d2-776313b08f93@nxp.com>

10/10/2017 15:46, Hemant Agrawal:
> Hi Thomas, Anatoly,
> 
> On 10/7/2017 5:07 PM, Thomas Monjalon wrote:
> > 07/10/2017 13:20, Hemant Agrawal:
> >> In case no_pci is configured, other buses e.g. fslmc bus will
> >> still need the the vfio to be enabled.
> >>
> >> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> >> ---
> >> v2: enabled VFIO, independent of no-pci flag as suggested by Thomas
> > [...]
> >> --- a/lib/librte_eal/linuxapp/eal/eal.c
> >> +++ b/lib/librte_eal/linuxapp/eal/eal.c
> >> @@ -733,10 +733,8 @@ static int rte_eal_vfio_setup(void)
> >>  {
> >>  	int vfio_enabled = 0;
> >>
> >> -	if (!internal_config.no_pci) {
> >> -		pci_vfio_enable();
> >> -		vfio_enabled |= pci_vfio_is_enabled();
> >> -	}
> >> +	pci_vfio_enable();
> >> +	vfio_enabled |= pci_vfio_is_enabled();
> >
> > You are enabling vfio_pci.
> > This part could stay conditionned by no_pci.
> >
> > I was thinking you need vfio without vfio_pci. Am I right?
> 
> yes
> > If yes, I suggest to enable only vfio root module.
> >
> 
> vfio_enable should be done only once. So, if I enable it for "vfio", 
> pci_vfio_enable is not required.
> In any case it is not storing any PCI specific data and there are no 
> error checks here of "vfio_pci" enable failure.
> 
> So, if we use,
> 	vfio_enable("vfio");
> 	vfio_enabled |= vfio_is_enabled("vfio");
> 
> It seems no_pci check will not have any value.
> 
> let me know your thoughts?

I don't know the code managing VFIO.
Anatoly, please can you help meeting the requirement of
VFIO always enabled?

  reply	other threads:[~2017-10-10 16:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-13 11:48 [PATCH] eal: fslmc bus need vfio enabled for non PCI case as well Hemant Agrawal
2017-10-05 23:41 ` Thomas Monjalon
2017-10-06 16:22   ` Hemant Agrawal
2017-10-06 17:08     ` Thomas Monjalon
2017-10-07 11:22       ` Hemant Agrawal
2017-10-07 11:20 ` [PATCH v2] eal: enable vfio independent of no PCI flag Hemant Agrawal
2017-10-07 11:37   ` Thomas Monjalon
2017-10-10 13:46     ` Hemant Agrawal
2017-10-10 16:27       ` Thomas Monjalon [this message]
2017-10-11  6:42   ` [PATCH v3] eal: enable vfio independent of PCI bus Hemant Agrawal
2017-10-23  6:33     ` FW: " Hemant Agrawal
2017-10-23 11:00       ` Burakov, Anatoly
2017-10-23 11:47     ` Burakov, Anatoly
2017-10-23 22:32       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2615630.Np2p4rFThG@xps \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.