From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753185AbdKIQAW (ORCPT ); Thu, 9 Nov 2017 11:00:22 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:41560 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750909AbdKIQAT (ORCPT ); Thu, 9 Nov 2017 11:00:19 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20171109160018epoutp0250cd6ea2662aea54f34527b82346d90d~1djSltR--3164731647epoutp02h X-AuditID: b6c32a48-905ff7000000103e-2b-5a047b917e6d From: Bartlomiej Zolnierkiewicz To: "Gustavo A. R. Silva" Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: fbdev: cirrusfb: mark expected switch fall-throughs Date: Thu, 09 Nov 2017 17:00:16 +0100 Message-id: <2619770.VHeb1jtPGe@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20171106224550.GA2583@embeddedor.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsWy7bCmme7EapYog3fPbCyufH3PZrFyyX42 ixN9H1gtLu+aw+bA4rHuoKrH/e7jTB6fN8kFMEdx2aSk5mSWpRbp2yVwZaxv3cVS0MdSca7r M3MD4wrmLkZODgkBE4mFr18zdjFycQgJ7GCU+PP4HSuE851Rou/3KUaYqmddE5ggEhsYJeZ3 TWAFSQgJfAVqeRUFYrMJWElMbF8F1iAiYCxx7fk+JhCbWSBB4vSieywgtrBAoER/YwdYL4uA qsSv9QvBangFNCWetPWBnSQq4CWxZV87WJwTaE7j2aWMEDWCEj8mQ8xhFpCX2Ld/KiuErSNx 9tg6sBckBGawSfyb3AN1tYvEgb3XoGxhiVfHt7BD2NISz1ZthIpPZ5TY/lsConkzo8Sq3ROg iqwlDh+/CLWBT6Lj8F+gOAdQnFeio00IwvSQmHNLDKLaUeLEoRfQAGpjlHgx6wbrBEbZWUju noXk7llI7l7AyLyKUSy1oDg3PbXYqMBErzgxt7g0L10vOT93EyM44rU8djAeOOdziFGAg1GJ h/fFKuYoIdbEsuLK3EOMEhzMSiK8pjksUUK8KYmVValF+fFFpTmpxYcYpTlYlMR567ZdixAS SE8sSc1OTS1ILYLJMnFwSjUwzk7sLm+743hLadYLhW/vbM5o55xY9sHa2Whex4mDBoIMm2c9 PuK9jOmGwuG7EpG3y0Jtc2fYX3icevn12RtKK64IuK/5b3VVxe3H2c//FBwMNBWXJm08VPbo 8BstyTCen1Kmh18kaWw9H3N3AuuRd7svOTtqBRSKFdesXCpb4BN4zIzj0/Okh0osxRmJhlrM RcWJADb6Lrb0AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrJLMWRmVeSWpSXmKPExsVy+t9jQd2J1SxRBpdWK1tc+fqezWLlkv1s Fif6PrBaXN41h82BxWPdQVWP+93HmTw+b5ILYI7isklJzcksSy3St0vgyljfuouloI+l4lzX Z+YGxhXMXYycHBICJhLPuiYwdTFycQgJrGOUmHD5NyOE85VRom/JHUaQKjYBK4mJ7avAbBEB Y4lrz/cBdXBwMAskSDyblwJiCgv4S/xvFgCpYBFQlfi1fiETiM0roCnxpK0PbJeogJfEln3t YHFOoCmNZ5dCrepglJj2fTsrRIOgxI/J91hAbGYBeYl9+6eyQthaEut3HmeawMg/C0nZLCRl s5CULWBkXsUomVpQnJueW2xUYJSXWq5XnJhbXJqXrpecn7uJERig2w5r9e9gfLwk/hCjAAej Eg+vw1rmKCHWxLLiytxDjBIczEoivKY5LFFCvCmJlVWpRfnxRaU5qcWHGKU5WJTEefnzj0UK CaQnlqRmp6YWpBbBZJk4OKUaGHdxB8lwsP4Nt9C1fjjt2HqfxAdv3EPuzHk6n3PH8zNH5i26 Hjzx2IkdBQ/LeGbM4DnR+FdNK/fT0/pbQqVFXKuV82WmRQcxrDVQL0reOt9KrevIoRtBbGUp S7nVihbMY1R53lMY9CQ5JfDIhvfer7ml9B35b/HsWlv+IKNpHqtY+S6F79Nvv1ViKc5INNRi LipOBADBIwfDTAIAAA== X-CMS-MailID: 20171109160017epcas2p1a2a0566418d1eaa5ac5d81ee2d77366c X-Msg-Generator: CA CMS-TYPE: 102P X-CMS-RootMailID: 20171106224555epcas3p153ad90e2c81169658eded4e40655cb31 X-RootMTR: 20171106224555epcas3p153ad90e2c81169658eded4e40655cb31 References: <20171106224550.GA2583@embeddedor.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, November 06, 2017 04:45:50 PM Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case I placed the "fall through" comment > on its own line, which is what GCC is expecting to find. > > Signed-off-by: Gustavo A. R. Silva Patch queued for 4.15, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Thu, 09 Nov 2017 16:00:16 +0000 Subject: Re: [PATCH] video: fbdev: cirrusfb: mark expected switch fall-throughs Message-Id: <2619770.VHeb1jtPGe@amdc3058> List-Id: References: <20171106224550.GA2583@embeddedor.com> In-Reply-To: <20171106224550.GA2583@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Gustavo A. R. Silva" Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org On Monday, November 06, 2017 04:45:50 PM Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case I placed the "fall through" comment > on its own line, which is what GCC is expecting to find. > > Signed-off-by: Gustavo A. R. Silva Patch queued for 4.15, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] video: fbdev: cirrusfb: mark expected switch fall-throughs Date: Thu, 09 Nov 2017 17:00:16 +0100 Message-ID: <2619770.VHeb1jtPGe@amdc3058> References: <20171106224550.GA2583@embeddedor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by gabe.freedesktop.org (Postfix) with ESMTPS id 24AEA6E8F5 for ; Thu, 9 Nov 2017 16:00:20 +0000 (UTC) In-reply-to: <20171106224550.GA2583@embeddedor.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Gustavo A. R. Silva" Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uZGF5LCBOb3ZlbWJlciAwNiwgMjAxNyAwNDo0NTo1MCBQTSBHdXN0YXZvIEEuIFIuIFNp bHZhIHdyb3RlOgo+IEluIHByZXBhcmF0aW9uIHRvIGVuYWJsaW5nIC1XaW1wbGljaXQtZmFsbHRo cm91Z2gsIG1hcmsgc3dpdGNoIGNhc2VzCj4gd2hlcmUgd2UgYXJlIGV4cGVjdGluZyB0byBmYWxs IHRocm91Z2guCj4gCj4gTm90aWNlIHRoYXQgaW4gdGhpcyBwYXJ0aWN1bGFyIGNhc2UgSSBwbGFj ZWQgdGhlICJmYWxsIHRocm91Z2giIGNvbW1lbnQKPiBvbiBpdHMgb3duIGxpbmUsIHdoaWNoIGlz IHdoYXQgR0NDIGlzIGV4cGVjdGluZyB0byBmaW5kLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEd1c3Rh dm8gQS4gUi4gU2lsdmEgPGdhcnNpbHZhQGVtYmVkZGVkb3IuY29tPgoKUGF0Y2ggcXVldWVkIGZv ciA0LjE1LCB0aGFua3MuCgpCZXN0IHJlZ2FyZHMsCi0tCkJhcnRsb21pZWogWm9sbmllcmtpZXdp Y3oKU2Ftc3VuZyBSJkQgSW5zdGl0dXRlIFBvbGFuZApTYW1zdW5nIEVsZWN0cm9uaWNzCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK