From: David Howells <dhowells@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available
Date: Fri, 18 Nov 2016 09:43:38 +0000 [thread overview]
Message-ID: <26219.1479462218@warthog.procyon.org.uk> (raw)
In-Reply-To: <20161117234047.GE28177@dastard>
Dave Chinner <david@fromorbit.com> wrote:
> > STATX_ATTR_KERNEL_API File is kernel API (eg: procfs/sysfs)
> > STATX_ATTR_REMOTE File is remote and needs network
> > STATX_ATTR_FABRICATED File was made up by fs
>
> Every file is fabricated by a filesystem :P
>
> Perhaps you're wanting "virtual file" because it is has no physical
> presence?
Yeah - that might be a better name. The idea of FABRICATED is to note objects
that have no actual existence in the backing store. Directories that had to
be invented to act as mountpoints would be a good example of this.
> > Fields in struct statx come in a number of classes:
> >
> > (0) stx_dev_*, stx_blksize.
> >
> > These are local system information and are always available.
>
> What does stx_blksize actually mean? It's completely ambiguous in
> stat() because we don't actually report the physical block size
> here - we report the "minimum unit of efficient IO" that we expect
> applications to use. Please define :P
Definition: "Same as struct stat::st_blksize".
> > The following test program can be used to test the statx system call:
> >
> > samples/statx/test-statx.c
> >
> > Just compile and run, passing it paths to the files you want to examine.
> > The file is built automatically if CONFIG_SAMPLES is enabled.
>
> Can we get xfstests written to exercise and validate all this
> functionality, please? I'd suggest that adding xfs_io support for
> the statx syscall would be far more useful for xfstests than a
> standalone test program, too. We already have equivalent stat()
> functionality in xfs_io and that's used quite a bit in xfstests....
Feel free to write some! ;-)
But I need a simple standalone test program to be able to test what I write,
and I've no inclination to wheel out huge testsuites for an interface that
people are still arguing about and wanting changed.
David
next prev parent reply other threads:[~2016-11-18 9:43 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 13:34 [RFC][PATCH 0/4] Enhanced file stat system call David Howells
2016-11-17 13:35 ` [PATCH 1/4] statx: Add a system call to make enhanced file info available David Howells
2016-11-17 18:39 ` Jeff Layton
2016-11-18 2:32 ` Andreas Dilger
2016-11-18 8:59 ` David Howells
2016-11-18 8:59 ` David Howells
2016-11-18 9:25 ` Andreas Dilger
2016-11-18 9:25 ` Andreas Dilger
2016-11-17 23:40 ` Dave Chinner
2016-11-18 3:28 ` Andreas Dilger
2016-11-18 22:07 ` Dave Chinner
2016-11-18 22:54 ` David Howells
2016-11-19 22:43 ` Dave Chinner
2016-11-21 14:30 ` One Thousand Gnomes
2016-11-21 20:43 ` Dave Chinner
2016-11-22 10:39 ` David Howells
2016-11-22 13:55 ` Jeff Layton
2016-11-22 20:58 ` Dave Chinner
2016-11-18 9:53 ` David Howells
2016-11-18 8:48 ` David Howells
2016-11-18 12:01 ` Jeff Layton
2016-11-18 9:36 ` David Howells
2016-11-18 17:17 ` Jeff Layton
2016-11-18 18:04 ` David Howells
2016-11-18 18:54 ` Jeff Layton
2016-11-18 19:08 ` David Howells
2016-11-18 9:43 ` David Howells [this message]
2016-11-18 21:41 ` Dave Chinner
2016-11-18 22:24 ` David Howells
2016-11-18 10:29 ` David Howells
2016-11-18 10:29 ` David Howells
2016-11-18 21:27 ` Dave Chinner
2016-11-18 21:48 ` David Howells
2016-11-18 21:48 ` David Howells
2016-11-18 22:17 ` Dave Chinner
2016-11-18 22:17 ` Dave Chinner
2016-11-19 10:21 ` Michael Kerrisk (man-pages)
2016-11-17 13:35 ` [PATCH 2/4] statx: Ext4: Return enhanced file attributes David Howells
2016-11-18 3:30 ` Andreas Dilger
2016-11-17 13:35 ` [PATCH 3/4] statx: NFS: " David Howells
2016-11-17 13:35 ` [PATCH 4/4] statx: AFS: " David Howells
2016-11-18 3:34 ` Andreas Dilger
2016-11-18 8:47 ` David Howells
2016-11-17 14:39 ` [RFC][PATCH 0/4] Enhanced file stat system call One Thousand Gnomes
2016-11-17 15:10 ` Michael Kerrisk
2016-11-17 16:33 ` David Howells
2016-11-17 16:45 ` David Howells
2016-11-17 20:00 ` J. Bruce Fields
2016-11-18 2:30 ` Andreas Dilger
2016-11-18 4:29 ` NeilBrown
2016-11-18 13:41 ` One Thousand Gnomes
2016-11-18 13:49 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26219.1479462218@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.