From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] KVM: nVMX: Eliminate vmcs02 pool
Date: Thu, 23 Nov 2017 18:17:42 +0100
Message-ID: <26283781-05b3-475c-5cb6-1b2022b8e640@redhat.com>
References: <e0e08f11f9d4a0c06e462a4a4217e996da058913.1511284598.git.mark.kanda@oracle.com>
 <5de0d265-be48-ec6a-3ec9-c55c742c4213@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: rkrcmar@redhat.com, ameya.more@oracle.com,
        Jim Mattson <jmattson@google.com>
To: David Hildenbrand <david@redhat.com>,
        Mark Kanda <mark.kanda@oracle.com>, kvm@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:36810 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753156AbdKWRRr (ORCPT <rfc822;kvm@vger.kernel.org>);
        Thu, 23 Nov 2017 12:17:47 -0500
In-Reply-To: <5de0d265-be48-ec6a-3ec9-c55c742c4213@redhat.com>
Content-Language: en-US
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 23/11/2017 17:59, David Hildenbrand wrote:
> On 21.11.2017 18:22, Mark Kanda wrote:
>> The potential performance advantages of a vmcs02 pool have never been
>> realized. To simplify the code, eliminate the pool. Instead, a single
>> vmcs02 is allocated per VCPU when the VCPU enters VMX operation.
> 
> Did you do any performance measurement to come to the conclusion that we
> can remove it? :)

This is enough I guess:

#define VMCS02_POOL_SIZE 1

so there wasn't really a pool of them...

Paolo

>>
>> Signed-off-by: Jim Mattson <jmattson@google.com>
> 
> -> why is that in here?
> 
>> Signed-off-by: Mark Kanda <mark.kanda@oracle.com>
>> Reviewed-by: Ameya More <ameya.more@oracle.com>
>> ---
>>  arch/x86/kvm/vmx.c | 146 
>