From: David Howells <email@example.com> To: Andreas Dilger <firstname.lastname@example.org> Cc: email@example.com, Dave Chinner <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org Subject: Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available Date: Fri, 18 Nov 2016 09:53:43 +0000 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <F276D85E-16FE-404B-BA51-A2EBA9DADCF2@dilger.ca> Andreas Dilger <firstname.lastname@example.org> wrote: > > What happens when an application uses STATX_ALL from a future kernel > > that defines more flags than are initially supported, and that > > application then is run on a kernel that onyl supports the initial > > fields? > > Fields that are unknown by the current kernel/filesystem will not be set, > and this is reflected in the flags that are returned to userspace. Yep. A userspace program can stick 0xffffffff in there if it wants. No error will be incurred. It just won't necessarily get anything back for each of those bits. That said, if we, say, want to reserve bit 31 as a struct extension bit, sticking in 0xffffffff without knowing what this is going to do to you on a kernel that supports a longer struct might give you a problem. But, basically, STATX_ALL indicates what flags have fields in the copy of the struct you got from the header file. There's an extra scenario: you could compile your userspace program against the headers for a particular kernel and then run against a later kernel. In such a case, you may find bits set that are outside STATX_ALL in stx_mask. However, you don't have definitions for those bits and can only ignore them. > > Again, we have many more common and extended flags than this. > > NOATIME and SYNC are two that immediately come to mind as generic > > flags that should be in this... > > Sure, and they can be added incrementally in a later patch. I'm not > sure why NOATIME and SYNC are missing, and I'm not against adding them, > but it is equally likely that they were removed in a previous round of > bikeshedding to avoid some real or perceived issue, so that this patch > can finally land rather than being in limbo for another 5 years. Does it make sense to return them through statx? Note that NOATIME might be considered superfluous given that STATX_ATIME is cleared in such a case. > >> New flags include: > >> > >> STATX_ATTR_NONUNIX_OWNERSHIP File doesn't have Unixy ownership > >> STATX_ATTR_HAS_ACL File has an ACL > > > > So statx will require us to do ACL lookups? i.e. instead of just > > reading the inode to get the information, we'll also have to do > > extended attribute lookups? That's potentially very expensive if > > the extended attribute is not stored in the inode.... > > No, there is no requirement to return anything that the caller didn't > ask for. Only fields that are explicitly requested need to be returned, > and others can optionally be returned if it is easy for the filesystem > to do so. Actually, Dave might have a point. We don't necessarily know that the file has an ACL without doing a getxattr() to probe for it - on the other hand, I would expect the permissions check to have done precisely that. David
next prev parent reply other threads:[~2016-11-18 9:53 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-11-17 13:34 [RFC][PATCH 0/4] Enhanced file stat system call David Howells 2016-11-17 13:35 ` [PATCH 1/4] statx: Add a system call to make enhanced file info available David Howells 2016-11-17 18:39 ` Jeff Layton 2016-11-18 2:32 ` Andreas Dilger 2016-11-18 8:59 ` David Howells 2016-11-18 8:59 ` David Howells 2016-11-18 9:25 ` Andreas Dilger 2016-11-18 9:25 ` Andreas Dilger 2016-11-17 23:40 ` Dave Chinner 2016-11-18 3:28 ` Andreas Dilger 2016-11-18 22:07 ` Dave Chinner 2016-11-18 22:54 ` David Howells 2016-11-19 22:43 ` Dave Chinner 2016-11-21 14:30 ` One Thousand Gnomes 2016-11-21 20:43 ` Dave Chinner 2016-11-22 10:39 ` David Howells 2016-11-22 13:55 ` Jeff Layton 2016-11-22 20:58 ` Dave Chinner 2016-11-18 9:53 ` David Howells [this message] 2016-11-18 8:48 ` David Howells 2016-11-18 12:01 ` Jeff Layton 2016-11-18 9:36 ` David Howells 2016-11-18 17:17 ` Jeff Layton 2016-11-18 18:04 ` David Howells 2016-11-18 18:54 ` Jeff Layton 2016-11-18 19:08 ` David Howells 2016-11-18 9:43 ` David Howells 2016-11-18 21:41 ` Dave Chinner 2016-11-18 22:24 ` David Howells 2016-11-18 10:29 ` David Howells 2016-11-18 10:29 ` David Howells 2016-11-18 21:27 ` Dave Chinner 2016-11-18 21:48 ` David Howells 2016-11-18 21:48 ` David Howells 2016-11-18 22:17 ` Dave Chinner 2016-11-18 22:17 ` Dave Chinner 2016-11-19 10:21 ` Michael Kerrisk (man-pages) 2016-11-17 13:35 ` [PATCH 2/4] statx: Ext4: Return enhanced file attributes David Howells 2016-11-18 3:30 ` Andreas Dilger 2016-11-17 13:35 ` [PATCH 3/4] statx: NFS: " David Howells 2016-11-17 13:35 ` [PATCH 4/4] statx: AFS: " David Howells 2016-11-18 3:34 ` Andreas Dilger 2016-11-18 8:47 ` David Howells 2016-11-17 14:39 ` [RFC][PATCH 0/4] Enhanced file stat system call One Thousand Gnomes 2016-11-17 15:10 ` Michael Kerrisk 2016-11-17 16:33 ` David Howells 2016-11-17 16:45 ` David Howells 2016-11-17 20:00 ` J. Bruce Fields 2016-11-18 2:30 ` Andreas Dilger 2016-11-18 4:29 ` NeilBrown 2016-11-18 13:41 ` One Thousand Gnomes 2016-11-18 13:49 ` David Howells
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.