From: Luca Weiss <luca@z3ntu.xyz>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Brian Masney <masneyb@onstation.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH 03/14] ARM: dts: qcom: use generic sram as name for imem and ocmem nodes
Date: Fri, 10 Jun 2022 22:53:55 +0200 [thread overview]
Message-ID: <2632793.mvXUDI8C0e@g550jk> (raw)
In-Reply-To: <20220607171848.535128-3-krzysztof.kozlowski@linaro.org>
Hi Krzysztof,
On Dienstag, 7. Juni 2022 19:18:37 CEST Krzysztof Kozlowski wrote:
> According to Devicetree specification, the device nodes should be
> generic, reflecting the function of the device. The typical name for
> memory regions is "sram".
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Luca Weiss <luca@z3ntu.xyz>
Regards
Luca
> ---
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts | 2 +-
> arch/arm/boot/dts/qcom-msm8974.dtsi | 4 ++--
> arch/arm/boot/dts/qcom-sdx55.dtsi | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
> b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts index
> ca9f73528196..de01e34409f2 100644
> --- a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
> +++ b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
> @@ -341,7 +341,7 @@ mmc@12400000 {
> };
> };
>
> - imem@2a03f000 {
> + sram@2a03f000 {
> compatible = "syscon", "simple-mfd";
> reg = <0x2a03f000 0x1000>;
>
> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi
> b/arch/arm/boot/dts/qcom-msm8974.dtsi index 814ad0b46232..09b181bb5365
> 100644
> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
> @@ -1603,7 +1603,7 @@ opp-27000000 {
> };
> };
>
> - ocmem@fdd00000 {
> + sram@fdd00000 {
> compatible = "qcom,msm8974-ocmem";
> reg = <0xfdd00000 0x2000>,
> <0xfec00000 0x180000>;
> @@ -1650,7 +1650,7 @@ smd-edge {
> };
> };
>
> - imem: imem@fe805000 {
> + imem: sram@fe805000 {
> compatible = "syscon", "simple-mfd";
> reg = <0xfe805000 0x1000>;
>
> diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi
> b/arch/arm/boot/dts/qcom-sdx55.dtsi index 1c2b208a5670..710c7f772d42 100644
> --- a/arch/arm/boot/dts/qcom-sdx55.dtsi
> +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
> @@ -561,7 +561,7 @@ tlmm: pinctrl@f100000 {
> #interrupt-cells = <2>;
> };
>
> - imem@1468f000 {
> + sram@1468f000 {
> compatible = "simple-mfd";
> reg = <0x1468f000 0x1000>;
next prev parent reply other threads:[~2022-06-10 20:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 17:18 [PATCH 01/14] dt-bindings: sram: qcom,ocmem: cleanup example coding style Krzysztof Kozlowski
2022-06-07 17:18 ` [PATCH 02/14] dt-bindings: sram: qcom,imem: add IMEM memory region Krzysztof Kozlowski
2022-06-09 20:40 ` Rob Herring
2022-06-07 17:18 ` [PATCH 03/14] ARM: dts: qcom: use generic sram as name for imem and ocmem nodes Krzysztof Kozlowski
2022-06-10 20:53 ` Luca Weiss [this message]
2022-06-22 11:59 ` Krzysztof Kozlowski
2022-06-07 17:18 ` [PATCH 04/14] ARM: dts: qcom: apq8064-asus-nexus7: add dedicated IMEM compatible Krzysztof Kozlowski
2022-06-07 17:18 ` [PATCH 05/14] ARM: dts: qcom: msm8974: " Krzysztof Kozlowski
2022-06-10 20:54 ` Luca Weiss
2022-06-07 17:18 ` [PATCH 06/14] ARM: dts: qcom: sdx55: add dedicated IMEM and syscon compatibles Krzysztof Kozlowski
2022-06-07 17:18 ` [PATCH 07/14] ARM: dts: qcom: msm8974: add required ranges to OCMEM Krzysztof Kozlowski
2022-06-10 20:56 ` Luca Weiss
2022-06-07 17:18 ` [PATCH 08/14] arm64: dts: qcom: use generic sram as name for imem and ocmem nodes Krzysztof Kozlowski
2022-06-07 17:18 ` [PATCH 09/14] arm64: dts: qcom: qcs404: add dedicated IMEM and syscon compatibles Krzysztof Kozlowski
2022-06-07 17:18 ` [PATCH 10/14] arm64: dts: qcom: sc7180: " Krzysztof Kozlowski
2022-06-07 17:18 ` [PATCH 11/14] arm64: dts: qcom: sc7280: add simple-mfd to IMEM Krzysztof Kozlowski
2022-06-07 17:18 ` [PATCH 12/14] arm64: dts: qcom: sdm630: add dedicated IMEM and syscon compatibles Krzysztof Kozlowski
2022-06-07 17:18 ` [PATCH 13/14] arm64: dts: qcom: sdm845: " Krzysztof Kozlowski
2022-06-07 17:18 ` [PATCH 14/14] arm64: dts: qcom: msm8994: add required ranges to OCMEM Krzysztof Kozlowski
2022-06-09 20:40 ` [PATCH 01/14] dt-bindings: sram: qcom,ocmem: cleanup example coding style Rob Herring
2022-07-03 3:56 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2632793.mvXUDI8C0e@g550jk \
--to=luca@z3ntu.xyz \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masneyb@onstation.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.