All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Tal Shnaiderman <talshn@nvidia.com>
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	Olivier Matz <olivier.matz@6wind.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Ranjit Menon <ranjit.menon@intel.com>, Aaron <aconole@redhat.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] build: fix using ELF-only linker flags with COFF
Date: Thu, 14 Jan 2021 10:30:29 +0100	[thread overview]
Message-ID: <2637046.0b4CQWxj9Z@thomas> (raw)
In-Reply-To: <DM6PR12MB3945D6FB0DFDA2C2B16B23A6A4A80@DM6PR12MB3945.namprd12.prod.outlook.com>

14/01/2021 10:27, Tal Shnaiderman:
> > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] build: fix using ELF-only linker
> > flags with COFF
> > 
> > External email: Use caution opening links or attachments
> > 
> > 
> > 13/01/2021 21:27, Ranjit Menon:
> > > On 1/11/2021 4:36 PM, Dmitry Kozlyuk wrote:
> > > > The --export-dynamic linker option is only applicable to ELF.
> > > > On Windows, where COFF is used, it causes warnings:
> > > >
> > > >      x86_64-w64-mingw32-ld: warning: --export-dynamic is not supported
> > > >      for PE+ targets, did you mean --export-all-symbols? (MinGW)
> > > >
> > > >      LINK : warning LNK4044: unrecognized option '/-export-dynamic';
> > > >      ignored (clang)
> > > >
> > > > Don't add --export-dynamic on Windows anywhere.
> > > >
> > > > Fixes: b031e13d7f0d ("build: fix plugin load on static build")
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> > > > ---
> > > > Using TLS variables with DLLs is problematic on Windows for now, so
> > > > not attempting to check or solve the issue with plugin load.
> > >
> > > Acked-by: Ranjit Menon <ranjit.menon@intel.com>
> > 
> > Applied, thanks
> > 
> > Why we didn't catch it in advance in CI?
> > 
> 
> I think Windows CI still passes on builds with warnings, maybe we can change it now that we cleared all of them.

Yes.
Please can you open a ticket in bugs.dpdk.org in the section lab/jobs?
Thank you



  reply	other threads:[~2021-01-14  9:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-12  0:36 [dpdk-dev] [PATCH] build: fix using ELF-only linker flags with COFF Dmitry Kozlyuk
2021-01-13 20:27 ` Ranjit Menon
2021-01-13 20:55   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2021-01-14  9:27     ` Tal Shnaiderman
2021-01-14  9:30       ` Thomas Monjalon [this message]
2021-01-14 10:30         ` Tal Shnaiderman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2637046.0b4CQWxj9Z@thomas \
    --to=thomas@monjalon.net \
    --cc=aconole@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=olivier.matz@6wind.com \
    --cc=ranjit.menon@intel.com \
    --cc=talshn@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.