Re: [Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test by default

From: Alexander Graf <agraf@suse.de>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test by default
Date: Sun, 12 Apr 2015 10:34:06 +0200	[thread overview]
Message-ID: <263F0FD9-0CC8-428D-A72D-B119ED3D983F@suse.de> (raw)
In-Reply-To: <55299647.10303@suse.de>

> Am 11.04.2015 um 23:46 schrieb Andreas Färber <afaerber@suse.de>:
> 
>> Am 11.04.2015 um 23:33 schrieb Peter Maydell:
>>> On 11 April 2015 at 21:28, Andreas Färber <afaerber@suse.de> wrote:
>>> Are you sure that QEMU / runcom / pi_10.com still try to map to that
>>> address zero?
>> 
>> It's the first thing runcom.c's main() does after checking you've
>> passed it enough command line arguments.
> 
> This?
> 
>    vm86_mem = mmap((void *)0x00000000, 0x110000,
>                    PROT_WRITE | PROT_READ | PROT_EXEC,
>                    MAP_FIXED | MAP_ANON | MAP_PRIVATE, -1, 0);
>    if (vm86_mem == MAP_FAILED) {
>        perror("mmap");
>        exit(1);
>    }
> 
> For whatever reason it does not take the MAP_FAILED path here...

Wasn't a NULL argument for the address a hint saying "map wherever you please"? I also feel like I'm missing context here - what exactly is broken?

Alex

> 
> But I can certainly live with dropping this patch, it's the last for a
> reason. :)
> 
> Andreas
> 
> -- 
> SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
> Graham Norton; HRB 21284 (AG Nürnberg)