[PATCH net-next] net: mdio: Fix a typo

[PATCH net-next] net: mdio: Fix a typo

[Zheng Yongjun]

Hz  ==> hz

Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
 drivers/net/mdio/mdio-bcm-unimac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mdio/mdio-bcm-unimac.c b/drivers/net/mdio/mdio-bcm-unimac.c
index 63348716b426..bfc9be23c973 100644
--- a/drivers/net/mdio/mdio-bcm-unimac.c
+++ b/drivers/net/mdio/mdio-bcm-unimac.c
@@ -203,7 +203,7 @@ static void unimac_mdio_clk_set(struct unimac_mdio_priv *priv)
 		return;
 	}
 
-	/* The MDIO clock is the reference clock (typically 250MHz) divided by
+	/* The MDIO clock is the reference clock (typically 250Mhz) divided by
 	 * 2 x (MDIO_CLK_DIV + 1)
 	 */
 	reg = unimac_mdio_readl(priv, MDIO_CFG);
-- 
2.25.1

Re: [PATCH net-next] net: mdio: Fix a typo

[Joe Perches]

On Wed, 2021-06-02 at 14:39 +0800, Zheng Yongjun wrote:
> Hz  ==> hz
[]
> diff --git a/drivers/net/mdio/mdio-bcm-unimac.c b/drivers/net/mdio/mdio-bcm-unimac.c
[]
> @@ -203,7 +203,7 @@ static void unimac_mdio_clk_set(struct unimac_mdio_priv *priv)
>  		return;
>  	}
> 
> -	/* The MDIO clock is the reference clock (typically 250MHz) divided by
> +	/* The MDIO clock is the reference clock (typically 250Mhz) divided by

No thanks.

MHz is typical, Mhz is not.

$ git grep -w -i -o -h mhz | sort |uniq -c | sort -rn
   5042 MHz
    571 MHZ
    398 Mhz
    353 mhz
     10 mHz

答复: [PATCH net-next] net: mdio: Fix a typo

[zhengyongjun]

Russell King told me to do so...  Did I understand it wrong?  
But from your opinion, I think "Hz" is more appropriate :)

```
Russell King <linux@armlinux.org.uk>

On Tue, Jun 01, 2021 at 10:18:59PM +0800, Zheng Yongjun wrote:
> informations  ==> information
> typicaly  ==> typically
> derrive  ==> derive
> eventhough  ==> even though

If you're doing this, then please also change "hz" to "Hz". The unit of frequency is the latter, not the former. Thanks.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
```

-----邮件原件-----
发件人: Joe Perches [mailto:joe@perches.com] 
发送时间: 2021年6月2日 15:25
收件人: zhengyongjun <zhengyongjun3@huawei.com>; andrew@lunn.ch; hkallweit1@gmail.com; davem@davemloft.net; kuba@kernel.org; bcm-kernel-feedback-list@broadcom.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
抄送: opendmb@gmail.com; f.fainelli@gmail.com; linux@armlinux.org.uk
主题: Re: [PATCH net-next] net: mdio: Fix a typo

On Wed, 2021-06-02 at 14:39 +0800, Zheng Yongjun wrote:
> Hz  ==> hz
[]
> diff --git a/drivers/net/mdio/mdio-bcm-unimac.c b/drivers/net/mdio/mdio-bcm-unimac.c
[]
> @@ -203,7 +203,7 @@ static void unimac_mdio_clk_set(struct unimac_mdio_priv *priv)
>  		return;
>  	}
> 
> -	/* The MDIO clock is the reference clock (typically 250MHz) divided by
> +	/* The MDIO clock is the reference clock (typically 250Mhz) divided by

No thanks.

MHz is typical, Mhz is not.

$ git grep -w -i -o -h mhz | sort |uniq -c | sort -rn
   5042 MHz
    571 MHZ
    398 Mhz
    353 mhz
     10 mHz

Re: 答复: [PATCH net-next] net: mdio: Fix a typo

[Russell King (Oracle)]

On Wed, Jun 02, 2021 at 07:43:19AM +0000, zhengyongjun wrote:
> Russell King told me to do so...  Did I understand it wrong?  
> But from your opinion, I think "Hz" is more appropriate :)

Sadly, you understood wrong. I requested to change from hz to Hz.

> ```
> Russell King <linux@armlinux.org.uk>
> 
> On Tue, Jun 01, 2021 at 10:18:59PM +0800, Zheng Yongjun wrote:
> > informations  ==> information
> > typicaly  ==> typically
> > derrive  ==> derive
> > eventhough  ==> even though
> 
> If you're doing this, then please also change "hz" to "Hz". The unit of frequency is the latter, not the former. Thanks.
> 
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
> ```
> 
> -----邮件原件-----
> 发件人: Joe Perches [mailto:joe@perches.com] 
> 发送时间: 2021年6月2日 15:25
> 收件人: zhengyongjun <zhengyongjun3@huawei.com>; andrew@lunn.ch; hkallweit1@gmail.com; davem@davemloft.net; kuba@kernel.org; bcm-kernel-feedback-list@broadcom.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> 抄送: opendmb@gmail.com; f.fainelli@gmail.com; linux@armlinux.org.uk
> 主题: Re: [PATCH net-next] net: mdio: Fix a typo
> 
> On Wed, 2021-06-02 at 14:39 +0800, Zheng Yongjun wrote:
> > Hz  ==> hz
> []
> > diff --git a/drivers/net/mdio/mdio-bcm-unimac.c b/drivers/net/mdio/mdio-bcm-unimac.c
> []
> > @@ -203,7 +203,7 @@ static void unimac_mdio_clk_set(struct unimac_mdio_priv *priv)
> >  		return;
> >  	}
> > 
> > -	/* The MDIO clock is the reference clock (typically 250MHz) divided by
> > +	/* The MDIO clock is the reference clock (typically 250Mhz) divided by
> 
> No thanks.
> 
> MHz is typical, Mhz is not.
> 
> $ git grep -w -i -o -h mhz | sort |uniq -c | sort -rn
>    5042 MHz
>     571 MHZ
>     398 Mhz
>     353 mhz
>      10 mHz
> 
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

Re: 答复: [PATCH net-next] net: mdio: Fix a typo

[Russell King - ARM Linux admin]

On Wed, Jun 02, 2021 at 11:07:49AM +0100, Russell King (Oracle) wrote:
> On Wed, Jun 02, 2021 at 07:43:19AM +0000, zhengyongjun wrote:
> > Russell King told me to do so...  Did I understand it wrong?  
> > But from your opinion, I think "Hz" is more appropriate :)
> 
> Sadly, you understood wrong. I requested to change from hz to Hz.

... which is odd, because you did the correct thing in your v2 spelling
fix patch posted previously.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!